Issue information

Issue ID
#417
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Nov 16, 2007 7:57
Last Post
Hercules Elf Bot
Nov 16, 2007 7:57
Confirmation
N/A

Hercules Elf Bot - Nov 16, 2007 7:57

Originally posted by [b]Barron-Monster[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=417

if you read at the code...
CODE
                case 2:
                    mes "[Phelix]";
                    mes "I'm not giving you more than 100";
                    mes "at a time so don't bother, OK? If";
                    mes "you don't want any, just say '0'.";
                    mes "Right now, the most you can get is";
                    mes ""+.@max+" but remember, 100 at most,";
                    mes "you want to break my back?";
                    input .@amount;
                    next;
                    mes "[Phelix]";
                    if (.@amount <= 0) {
                        mes "Much obliged, come again anytime.";
                        close;
                    }
                    if (.@amount > 100) {
                        mes "Hey, what'd I say? 100 at a time at";
                        mes "most, you're trying to kill me";
                        mes "aren't you!";
                        close;
                    }
                    if (countitem(909) < .@amount*10) {
                        mes "Hmmm, it looks like you don't have";
                        mes "enough. Go get more jellopies if";
                        mes "you want anything else from me.";
                        close;
                    }
                    delitem 909,.@amount*10;
                    next;
                    getitem 501,.@amount;
                    mes "[Phelix]";
                    mes "There you go! As I promised. Don't";
                    mes "go suckin' them all down at once.";
                    close;

This:
CODE
                    delitem 909,.@amount*10;
                    next;
                    getitem 501,.@amount;
                    mes "[Phelix]";
                    mes "There you go! As I promised. Don't";
                    mes "go suckin' them all down at once.";
                    close;

Should be replace by
CODE
                    delitem 909,.@amount*10;
                    getitem 501,.@amount;
                    mes "There you go! As I promised. Don't";
                    mes "go suckin' them all down at once.";
                    close;

There is no reason to do a empty windows...

And
CODE
                next;
                switch(select("As many as I can get, please","I want this many.","Never mind, I like my jellopy.")) {
                case 1:
                    delitem 909,.@max*3;
                    next;
                    getitem 515,.@max;
                    mes "[Phelix]";
                    mes "There you go~! As I promised. Try";
                    mes "not to stuff yer face.";
                    close;

replace by
CODE
                next;
                switch(select("As many as I can get, please","I want this many.","Never mind, I like my jellopy.")) {
                case 1:
                    delitem 909,.@max*3;
                    getitem 515,.@max;
                    mes "[Phelix]";
                    mes "There you go~! As I promised. Try";
                    mes "not to stuff yer face.";
                    close;

And the last.
CODE
                    delitem 909,.@amount*3;
                    next;
                    getitem 515,.@amount;
                    mes "[Phelix]";
                    mes "There you go~! As I promised. Try";
                    mes "not to stuff yer face.";
                    close;

replace by
CODE
                    delitem 909,.@amount*3;
                    getitem 515,.@amount;
                    mes "There you go~! As I promised. Try";
                    mes "not to stuff yer face.";
                    close;

I realy don't understand why you guy love empty windows...