Issue information

Issue ID
#4193
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Apr 18, 2010 16:23
Last Post
Hercules Elf Bot
Apr 18, 2010 16:23
Confirmation
N/A

Hercules Elf Bot - Apr 18, 2010 16:23

Originally posted by [b]Kazukin[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4193

Changing 'date_format' in login_athena.conf breaks last login saving since MySQL uses YYYY-MM-DD HH:MM:SS. timestamp2string() (login.c) applies the new 'date_format' to 'acc.lastlogin' and this is used to save the formatted last login time to the lastlogin field from the login table (account_sql.c).

Quickfix:
QUOTE
// update account data
- timestamp2string(acc.lastlogin, sizeof(acc.lastlogin), time(NULL), login_config.date_format);
+ timestamp2string(acc.lastlogin, sizeof(acc.lastlogin), time(NULL), "%Y-%m-%d %H:%M:%S");
safestrncpy(acc.last_ip, ip, sizeof(acc.last_ip));
acc.unban_time = 0;
acc.logincount++;

accounts->save(accounts, &acc);