Hercules Elf Bot - May 26, 2010 1:23
Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4253
An idea I had while working on autotrade - do the open vending shop check last instead of first. There's a bunch of conditions to be satisfied before autotrade activates - shop open, not dead, autotrade mapflag allowed. However, since the vending check comes before the mapflag check, you'll only know that you're not allowed to use @autotrade on your current map after you've already opened your shop. Moving the shop check would improve things a bit.
Oh, and replace that ugly nested cascade of if() statements with a nice linear sequence of "if( failure ) { clif_displaymessage(); return -1; }" blocks.