Arrow Shower not working on Land Protector + fix
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#4347
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
Jul 8, 2010 18:57
Last Post
Hercules Elf Bot
Mar 5, 2012 17:45
Confirmation
Hercules Elf Bot - Jul 8, 2010 18:57
Originally posted by [b]Damlug[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4347
Hello
Arrow shower is supposed to work on Land Protector, but it doesn't on eAthena. I made a video on an Aegis server (fro) then you will see it works perfectly.
The video is here
http://www.megaupload.com/?d=T7FQLCIC
Here is a diff file you need to put in src/map)
http://baha922.free.fr/ro/arrowshower.diff
It works for me with trunk 14363, but you should test it too, we never know; or maybe you have a better way to fix it.
Thank you
This post has been edited by Damlug: Jul 13 2010, 08:34 AM
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4347
Hello
Arrow shower is supposed to work on Land Protector, but it doesn't on eAthena. I made a video on an Aegis server (fro) then you will see it works perfectly.
The video is here
http://www.megaupload.com/?d=T7FQLCIC
Here is a diff file you need to put in src/map)
http://baha922.free.fr/ro/arrowshower.diff
It works for me with trunk 14363, but you should test it too, we never know; or maybe you have a better way to fix it.
Thank you
This post has been edited by Damlug: Jul 13 2010, 08:34 AM
Hercules Elf Bot - Dec 15, 2011 4:30
Originally posted by [b]Ind[/b]
Fixed in [rev=15129]
Fixed in [rev=15129]
Hercules Elf Bot - Dec 15, 2011 5:14
Originally posted by [b]mrjnumber1[/b]
This fix is incomplete, as it does not fix MA_SHOWER.
[CODE]
switch(group->skill_id)
{
case AC_SHOWER:
case MA_SHOWER:
break;
default:
if( !(skill_get_inf2(group->skill_id)&(INF2_SONG_DANCE|INF2_TRAP)) && map_getcell(bl->m, bl->x, bl->y, CELL_CHKLANDPROTECTOR) )
return 0; //AoE skills are ineffective. [Skotlex]
break;
}
[/CODE]
This would fix it however
This fix is incomplete, as it does not fix MA_SHOWER.
[CODE]
switch(group->skill_id)
{
case AC_SHOWER:
case MA_SHOWER:
break;
default:
if( !(skill_get_inf2(group->skill_id)&(INF2_SONG_DANCE|INF2_TRAP)) && map_getcell(bl->m, bl->x, bl->y, CELL_CHKLANDPROTECTOR) )
return 0; //AoE skills are ineffective. [Skotlex]
break;
}
[/CODE]
This would fix it however
Hercules Elf Bot - Dec 15, 2011 6:54
Originally posted by [b]Ind[/b]
Thanks for pointing out.
I've added a new skill info type so it gets easier to modify when new ones show up.
Fixed in [rev=15132]
Thanks for pointing out.
I've added a new skill info type so it gets easier to modify when new ones show up.
Fixed in [rev=15132]