Issue information

Issue ID
#456
Status
Fixed
Severity
Critical
Started
Hercules Elf Bot
Nov 20, 2007 11:14
Last Post
Hercules Elf Bot
Nov 20, 2007 11:14
Confirmation
N/A

Hercules Elf Bot - Nov 20, 2007 11:14

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=456

Several commands use a statically-dimensioned text buffer to perform mass string concatenation on. In some cases the overall string length becomes too large and the mapserver crashes due to a smashed stack.

Commands known to suffer from this problem:
- #storagelist
- #itemlist
perhaps more. They're rather easy to see - char output[200] and such.

A possible fix would be to use StringBuf as it can do the 'append' operation pretty quickly.