Creating identical nicknames

Originally posted by [b]xazax[/b]
The value is read in char server sql implementation, but not used.

My solution, ( I did not test it yet ):

[codebox]
Index: char.c
===================================================================
--- char.c (revision 15270)
+++ char.c (working copy)
@@ -1327,11 +1327,31 @@
}

// check name (already in use?)
- if( SQL_ERROR == Sql_Query(sql_handle, "SELECT 1 FROM `%s` WHERE `name` = '%s' LIMIT 1", char_db, esc_name) )
+ if ( name_ignoring_case )
{
- Sql_ShowDebug(sql_handle);
- return -2;
+ if( SQL_ERROR == Sql_Query(sql_handle, "SELECT 1 FROM `%s` WHERE `name` = '%s' LIMIT 1", char_db, esc_name) )
+ {
+ Sql_ShowDebug(sql_handle);
+ return -2;
+ }
}
+ else
+ {
+ char lower_esc_name[NAME_LENGTH*2+1];
+ int i = 0;
+
+ while(esc_name[i])
+ {
+ lower_esc_name[i] = tolower(esc_name[i]);
+ ++i;
+ }
+
+ if( SQL_ERROR == Sql_Query(sql_handle, "SELECT 1 FROM `%s` WHERE LOWER(`name`) = '%s' LIMIT 1", char_db, lower_esc_name) )
+ {
+ Sql_ShowDebug(sql_handle);
+ return -2;
+ }
+ }
if( Sql_NumRows(sql_handle) > 0 )
return -1; // name already exists


[/codebox]

Originally posted by [b]arp[/b]
I've had a chat to xazax about this, and unfortunately his above provided is a little wrong. I've spent a little while looking at this, and have provided a patch that I'm confident will work as intended. It turns out that the piece of code used to lower() a string actually ended up adding garbage on to strings of len(str)==4.

I can't find an attach button, so here's the diff:
[url="http://bawx.depha.se/.rathena/issue_4700.diff"]http://bawx.depha.se/.rathena/issue_4700.diff[/url]

Originally posted by [b]Ind[/b]
[quote name='arp' timestamp='1325208912' post='6215']
I've had a chat to xazax about this, and unfortunately his above provided is a little wrong. I've spent a little while looking at this, and have provided a patch that I'm confident will work as intended. It turns out that the piece of code used to lower() a string actually ended up adding garbage on to strings of len(str)==4.I can't find an attach button, so here's the diff:[url="http://bawx.depha.se/.rathena/issue_4700.diff"]http://bawx.depha.se...issue_4700.diff[/url]
[/quote]
yours is a little wrong too XD I didn't test either yet but at taking a glance at the diff file, for example, you declare a lower_esc_name which is not used anywhere

Originally posted by [b]arp[/b]
Ah, I must have missed that out, lower_esc_name is from the old code and I forgot to remove it, I'll attach an updated diff.

Originally posted by [b]arp[/b]
Diff has been updated to remove the two unused declarations.

Originally posted by [b]Ind[/b]
I've got to this and I've fixed it simply by adding a 'BINARY `name` = <name>'. Fixed in [rev=15374]