Issue information

Issue ID
#4718
Status
Confirmed
Severity
Medium
Started
Hercules Elf Bot
Jan 18, 2011 23:33
Last Post
Hercules Elf Bot
Jul 17, 2012 17:28
Confirmation
Yes (5)
No (0)

Hercules Elf Bot - Jan 18, 2011 23:33

Originally posted by [b]Alair[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4718

In eAthena MaxHP and MaxSP for TAEKWON, STAR GLADIATOR, LINKER, GUNSLINGER and NINJA calculating linearly, but:

Aegis HP table: http://up.5cm.ru/u/zJNN/maxhp3.scp
Aegis SP table: http://up.5cm.ru/u/z3QK/maxsp3.scp

does not match.

Sorry my english. Please, fix.

Hercules Elf Bot - Dec 6, 2011 15:10

Originally posted by [b]Ind[/b]
moving to db bug tracker -- not a core issue.

Hercules Elf Bot - Dec 11, 2011 19:25

Originally posted by [b]Kenpachi[/b]
The current database layout doesn't allow to realize this because the HP is calculated by [i]HPFactor [/i]and [i]HPMultiplicator [/i]in job_db1.txt.

Hercules Elf Bot - Mar 19, 2012 19:30

Originally posted by [b]Kenpachi[/b]
We have to create a new layout. I can't accept that we're not able to be officia in such an important thing.

Hercules Elf Bot - Mar 19, 2012 19:55

Originally posted by [b]Daegaladh[/b]
I did the whole system some time ago :3
I'll post it later because I have to leave now, sorry

Hercules Elf Bot - Mar 19, 2012 23:53

Originally posted by [b]Daegaladh[/b]
Here's the diff for status.c (rev r15734) [url="http://pastebin.com/qzyFrkNb"]http://pastebin.com/qzyFrkNb[/url]

And here the db files:
The real only difference is on ninja & guns HP, the rest is on Munak/Bongun classes (yep, they are on aegis files XD) and aren't relevant, so you can delete those classes and join job_maxsp files into one.

pre-re/job_maxhp.txt [url="http://pastebin.com/PHSB3F5T"]http://pastebin.com/PHSB3F5T[/url]
pre-re/job_maxsp.txt [url="http://pastebin.com/C3QVMgts"]http://pastebin.com/C3QVMgts[/url]

re/job_maxhp.txt [url="http://pastebin.com/CvyN34hF"]http://pastebin.com/CvyN34hF[/url]
re/job_maxsp.txt [url="http://pastebin.com/EycnqLff"]http://pastebin.com/EycnqLff[/url]

Edit: Oops! I forgot: You have to remove HPFactor,HPMultiplicator & SPFactor fields from job_db1.txt too

This post has been edited by Daegaladh on Mar 20, 2012 0:18

Hercules Elf Bot - Mar 21, 2012 10:11

Originally posted by [b]Kenpachi[/b]
I'll check this. But since we're in a major organzation discussion it will may take some time.
Thanks, Daegaladh. :)

Hercules Elf Bot - Mar 23, 2012 17:44

Originally posted by [b]Kenpachi[/b]
The DB files Daegaladh provided look good to me.
Please check the source diff and implement this update, (Or your version if you don't like the provided one.)

-> Moving this to Core.

This post has been edited by Kenpachi on Mar 23, 2012 17:46

Hercules Elf Bot - Mar 24, 2012 22:26

Originally posted by [b]Ind[/b]
this have to be thought a bit further, this certainly takes changing the max level to a higher level of difficulty

Hercules Elf Bot - Mar 24, 2012 22:48

Originally posted by [b]Kenpachi[/b]
We could provide custom values that goes up to level 999/1000 like we did in exp.txt and simply remove the level column from the layout and just read as many values as max level is set to in exp.txt.
(Putting those values within exp.txt and rename it to a more fitting name is a solution, too but somehow I don't like it.)

This post has been edited by Kenpachi on Mar 24, 2012 22:48

Hercules Elf Bot - Jun 26, 2012 10:35

Originally posted by [b]Daegaladh[/b]
Here's an updated (and fixed) version of my patch: [url="http://pastebin.com/2sDnEnk2"]http://pastebin.com/2sDnEnk2[/url] (rev 16347)
Tested and working :3

Also I added Expanded Super Novice, Expanded Super Baby, Kagerou and Oboro to the tables, but since I have no info about their HP and SP, I used Rune Knight's values as dummy data, so you can do the same or add the real data if you have it.

Hercules Elf Bot - Jun 27, 2012 5:10

Originally posted by [b]Protimus[/b]
It seems to be functional, but maybe we can improve the code.

This post has been edited by Protimus on Jun 27, 2012 5:12

Hercules Elf Bot - Jul 17, 2012 17:28

Originally posted by [b]michieru[/b]
bump

there is some info too:
http://rathena.org/board/topic/67005-comparative-renewal-sakray-vs-rathena/

This post has been edited by michieru on Jul 17, 2012 17:30