callshop use flag 0 bug buy anyware
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#4883
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Apr 27, 2011 22:26
Last Post
Hercules Elf Bot
Apr 4, 2012 9:50
Confirmation
Hercules Elf Bot - Apr 27, 2011 22:26
Originally posted by [b]BabyIze[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4883
[quote]BUILDIN_FUNC(callshop)
*
*
*
*
if( nd->subtype == SHOP )
{
switch( flag )
{
case 1: npc_buysellsel(sd,nd->bl.id,0); break; //Buy window
case 2: npc_buysellsel(sd,nd->bl.id,1); break; //Sell window
[b]default: clif_npcbuysell(sd,nd->bl.id); break; //Show menu[/b]
}
}[/quote]
sample script
[quote]
- script test -1,{
[b]callshop "testbuy",0; <--- flag 0 show menu[/b]
end;
}
- shop testbuy -1,505:-1
new_1-1,54,109,5 duplicate(test) buy 69
[/quote]
If player buy item with [b]WPE[/b]
He can buy items from shops.
Without going through the check area that NPC
I Test flag 1 ok no bug
[quote]callshop "testbuy",1;[/quote]
By send packet [b][ showmenu -> selectbuy --> selectitem -> input amount --> buybottom ][/b] getitem anywhere
This post has been edited by [b]BabyIze[/b]: Apr 27 2011, 07:17 PM
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=4883
[quote]BUILDIN_FUNC(callshop)
*
*
*
*
if( nd->subtype == SHOP )
{
switch( flag )
{
case 1: npc_buysellsel(sd,nd->bl.id,0); break; //Buy window
case 2: npc_buysellsel(sd,nd->bl.id,1); break; //Sell window
[b]default: clif_npcbuysell(sd,nd->bl.id); break; //Show menu[/b]
}
}[/quote]
sample script
[quote]
- script test -1,{
[b]callshop "testbuy",0; <--- flag 0 show menu[/b]
end;
}
- shop testbuy -1,505:-1
new_1-1,54,109,5 duplicate(test) buy 69
[/quote]
If player buy item with [b]WPE[/b]
He can buy items from shops.
Without going through the check area that NPC
I Test flag 1 ok no bug
[quote]callshop "testbuy",1;[/quote]
By send packet [b][ showmenu -> selectbuy --> selectitem -> input amount --> buybottom ][/b] getitem anywhere
This post has been edited by [b]BabyIze[/b]: Apr 27 2011, 07:17 PM
This post has been edited by Xantara on Dec 13, 2011 7:33
Hercules Elf Bot - Dec 6, 2011 14:22
Originally posted by [b]Ind[/b]
I'd like some other dev to confirm my logic (because i'm not sure).
[quote]
the guy sends the packet to go straight to clif_parse_NpcBuySellSelected correct? if this is correct a check for npc_id (if target id = recorded npc id) in npc_buysellsel should work, shouldn't it? -- a legit would be attached to npc_id when he clicked it, where a wpe wouldn't
[/quote]
I'd like some other dev to confirm my logic (because i'm not sure).
[quote]
the guy sends the packet to go straight to clif_parse_NpcBuySellSelected correct? if this is correct a check for npc_id (if target id = recorded npc id) in npc_buysellsel should work, shouldn't it? -- a legit would be attached to npc_id when he clicked it, where a wpe wouldn't
[/quote]
This post has been edited by Ind on Dec 8, 2011 16:03
Hercules Elf Bot - Dec 14, 2011 0:39
Originally posted by [b]Epoque[/b]
Fixed in [rev=15099]. Needs amending though due to a conflict of interest with another bug.
Fixed in [rev=15099]. Needs amending though due to a conflict of interest with another bug.
This post has been edited by Kenpachi on Apr 4, 2012 9:44