Skills not granted permanently through script - Hercules bug tracker archive

Issue information

Issue ID

#5018

Status

Fixed

Severity

Medium

Started

Hercules Elf Bot

Aug 8, 2011 4:06

Last Post

Ind

Feb 15, 2013 2:20

Confirmation

Yes (5)

No (0)

Hercules Elf Bot - Aug 8, 2011 4:06

Originally posted by [b]Epoque[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=5018

I've just implemented an NPC which will grant a player ALL_BUYING_STORE once paid for. I expected: skill "ALL_BUYING_STORE", 1, 0; to permanently grant the player the skill. However whenever I logout and login on the character, the skill is removed (and must talk to the NPC again). I'm not sure if this is a skill specific problem, or a general script problem.

The NPC code is below.

CODE

    set Zeny, Zeny - 500000;
    set BUYING_STORE, 1;
    skill "ALL_BUYING_STORE", 1, 0;

Upon re-login, the skill has been lost. It seems permanent skills are saved in the database, but not sent to the client upon login.

This post has been edited by Epoque: Aug 7 2011, 09:22 PM

Hercules Elf Bot - Dec 6, 2011 15:18

Originally posted by [b]Ind[/b]
I couldn't reproduce, works fine on latest rAthena

Hercules Elf Bot - Apr 2, 2012 23:51

Originally posted by [b]Ind[/b]
Issue identified. Working on it.

Hercules Elf Bot - Apr 2, 2012 23:55

Originally posted by [b]Ind[/b]
[s]Should be fixed in [rev=15825][/s] reverted in [rev=15827]

This post has been edited by Ind on Apr 3, 2012 0:58

Hercules Elf Bot - Apr 3, 2012 14:43

Originally posted by [b]Rozeniiz[/b]
when relogin buying store skill still hide

Hercules Elf Bot - Apr 4, 2012 2:01

Originally posted by [b]Earthlingz[/b]
couldnt we just add them to all jobs skill_tree.txt?

or probably make something like inherit the jobs so the skills doesnt need to put to each jobs just like the client skilltreeview and jobinheritlist luas (sounds like a not easy job to do though)

Hercules Elf Bot - Apr 4, 2012 13:16

Originally posted by [b]Rozeniiz[/b]
i try with merchant when i logout and login again the skill is disappear

Hercules Elf Bot - Aug 21, 2012 9:24

Originally posted by [b]Vali[/b]
bump

Hercules Elf Bot - Aug 30, 2012 21:04

Originally posted by [b]Altimage[/b]
bump

Hercules Elf Bot - Nov 20, 2012 3:26

Originally posted by [b]mkbu95[/b]
I think I did fix that in [rev=16908].
Let me know if I broke something/didn't fix properly.

Hercules Elf Bot - Nov 20, 2012 12:15

Originally posted by [b]Ind[/b]
[quote name='mkbu95' timestamp='1353381969' post='15767']
I think I did fix that in [rev=16908].Let me know if I broke something/didn't fix properly.
[/quote]
you fixed this particular case; but overall any script-granted skill that is not preset in their skill tree goes away on relog (because they're not properly saved in the db)

Ind - Feb 14, 2013 18:55

will update this reply with link to commit once it reaches the repository.

mkbu95 - Feb 14, 2013 22:30

Finally :D
I tried fixing this on late nov but my fix was a bit of messy !_!

Ind - Feb 15, 2013 2:20

Fixed in here [url="https://github.com/HerculesWS/Hercules/commit/2bc85620e0b91aaaa29f929e618d5f6d6623b4f0"]https://github.com/HerculesWS/Hercules/commit/2bc85620e0b91aaaa29f929e618d5f6d6623b4f0[/url]