Issue information

Issue ID
#503
Status
Fixed
Severity
Medium
Started
Hercules Elf Bot
Nov 27, 2007 22:29
Last Post
Hercules Elf Bot
Nov 27, 2007 22:29
Confirmation
N/A

Hercules Elf Bot - Nov 27, 2007 22:29

Originally posted by [b]theultramage[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=503

(previously mentioned in this topic)

The client since 2004 supports a 'security-enhanced' trade window. It displays the trade partner's base level, and an alphabeticized char id. These should make you more aware about who you're dealing your items to. It isn't rare for me to get a trade when accidentally standing next to some other char, and getting dealed good equip this way. A mistake like this could mean losing your items and malicious players could trigger situations like this intentionally, so I guess it's an improvement.

Fix implemented as r11830.
QUOTE
* Reconstructed a list of all PACKETVER types, by reverse-engineering it from places in the code where the define is used
- recovered PACKETVER 6 which was added in r51, but overwritten by r141, one of the dumbest commits that I have seen so far
- since 6 was the 'new trade window' update, it and its corresponding reply packet will now be used from now on instead the old version

Tested and it works. Of course, this was originally implemented several years ago, but it got overwritten shortly afterwards. Too bad, eh?

This post has been edited by theultramage: Nov 27 2007, 02:30 PM