Issue information

Issue ID
#5046
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Sep 9, 2011 7:31
Last Post
Hercules Elf Bot
Mar 5, 2012 15:49
Confirmation
N/A

Hercules Elf Bot - Sep 9, 2011 7:31

Originally posted by [b]Kazukin[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=5046

There is a bug on Einbroch's Factory Quest that allows unlimited monster spawning due to no check being done to find whether the 'event' (Einbroch Smog Alert) is already running. It is possible to walk in and out of this OnTouch to spawn monsters:

QUOTE
OnTouch:
- if ($EinPolution > 9) {
+ if ($EinPolution > 9 && !$@AlrdEinPoll) {
mes "[Liotzburg]";
mes "What's going on?!";
mes "Who's responsible?!";
mes "God, I can't believe";
mes "this is happening!";
mes "^333333*Cough Cough!*^000000";
next;
mes "[Liotzburg]";
mes "I need to get out of here!";
mes "You! D-do something and";
mes "fix this! I gotta hide and find";
mes "someplace safe!";
close2;
- donpcevent "Einbroch Smog Alert::OnEnable";
- hideonnpc "Liotzburg#ein";
+ if ($EinPolution > 9 && !$@AlrdEinPoll) {
+ donpcevent "Einbroch Smog Alert::OnEnable";
+ hideonnpc "Liotzburg#ein";
+ }
end;
}
else {
end;
}
}


Curious thing is that the event tracking variable ($@AlrdEinPoll) is properly set and unset, but no check whatsoever is done on such variable anywhere on the script. Provided diff fixes the issue.

P.D: Is it me or codeboxes don't work on the bugtracker?

This post has been edited by Kazukin: Sep 9 2011, 12:33 AM

Hercules Elf Bot - Dec 8, 2011 10:59

Originally posted by [b]calciumkid[/b]
Fixed