Asura combo stopped working
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#5052
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Sep 11, 2011 23:53
Last Post
Hercules Elf Bot
Mar 5, 2012 17:45
Confirmation
Hercules Elf Bot - Sep 11, 2011 23:53
Originally posted by [b]Kazukin[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=5052
After r14939 Asura Strike is broken when casted as part of a combo. Issue is that it is invoked with no target_id and as result it takes oneself as target_id (default target). This causes sp, spirit spheres and fury to be consumed but no damage is done (since you are the target).
Quickfix:
Also, packet 0x07e1 is still commented on the packet_db, maybe it should be uncommented even if its size is already defined on clif.c
This post has been edited by Kazukin: Sep 11 2011, 05:17 PM
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=5052
After r14939 Asura Strike is broken when casted as part of a combo. Issue is that it is invoked with no target_id and as result it takes oneself as target_id (default target). This causes sp, spirit spheres and fury to be consumed but no damage is done (since you are the target).
Quickfix:
QUOTE
unit_skilluse_id2()
if ( target_id == src->id &&
skill_get_inf(skill_num)&INF_SELF_SKILL &&
skill_get_inf2(skill_num)&INF2_NO_TARGET_SELF )
{
target_id = ud->target; //Auto-select target. [Skotlex]
temp = 1;
- }
+ } else //Asura combo
+ if (skill_num == MO_EXTREMITYFIST &&
+ sc && sc->data[SC_COMBO] &&
+ (sc->data[SC_COMBO]->val1 == MO_COMBOFINISH ||
+ sc->data[SC_COMBO]->val1 == CH_TIGERFIST ||
+ sc->data[SC_COMBO]->val1 == CH_CHAINCRUSH))
+ {
+ target_id = ud->target;
+ temp = 1;
+ }
if ( target_id == src->id &&
skill_get_inf(skill_num)&INF_SELF_SKILL &&
skill_get_inf2(skill_num)&INF2_NO_TARGET_SELF )
{
target_id = ud->target; //Auto-select target. [Skotlex]
temp = 1;
- }
+ } else //Asura combo
+ if (skill_num == MO_EXTREMITYFIST &&
+ sc && sc->data[SC_COMBO] &&
+ (sc->data[SC_COMBO]->val1 == MO_COMBOFINISH ||
+ sc->data[SC_COMBO]->val1 == CH_TIGERFIST ||
+ sc->data[SC_COMBO]->val1 == CH_CHAINCRUSH))
+ {
+ target_id = ud->target;
+ temp = 1;
+ }
Also, packet 0x07e1 is still commented on the packet_db, maybe it should be uncommented even if its size is already defined on clif.c
This post has been edited by Kazukin: Sep 11 2011, 05:17 PM
Hercules Elf Bot - Dec 15, 2011 4:36
Originally posted by [b]Ind[/b]
Fixed in [rev=15130]
Fixed in [rev=15130]
Hercules Elf Bot - Dec 15, 2011 17:17
Originally posted by [b]QQfoolsorellina[/b]
After updated to r15130 I can't cast the skill [b]MO_EXTREMITYFIST[/b]
After updated to r15130 I can't cast the skill [b]MO_EXTREMITYFIST[/b]
Hercules Elf Bot - Dec 15, 2011 20:32
Originally posted by [b]Ind[/b]
Thanks. Fixed in [rev=15136]
Thanks. Fixed in [rev=15136]