Issue information

Issue ID
#5129
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
Dec 19, 2011 18:25
Last Post
Hercules Elf Bot
Mar 5, 2012 16:05
Confirmation
N/A

Hercules Elf Bot - Dec 19, 2011 18:25

Originally posted by [b]mkbu95[/b]
from quests_ayothaya.txt

[QUOTE]...
mes "[Mr. Jun]";
mes "Okay...";
mes "As you kids say,";
mes "^990000Let's get eXtreme!^000000";
next;
[b]set user_score,0;
set pc_score,0;[/b]
mes "[Mr. Jun]";
mes "Rock!";
mes "Paper!";
mes "Scissors!";
...[/QUOTE]

[QUOTE]...
if ([b].@pc_score[/b] == 5 || [b].@user_score[/b] == 3) {
break;
}
...[/QUOTE]

[QUOTE]...
[b]set .@pc_score,.@pc_score + 1;
set .@user_score,.@user_score + 1;[/b]
mes "[Mr. Jun]";
mes "What...?";
...[/QUOTE]

And it goes all long the NPC, the variable declared is permanent char but the one which is used is a scope variable.
I'm pretty sure it does reset to 0 when the NPC finishes the interaction with the player, so there's actually no reason for keeping the permanent char variable declared. Altough you might want to keep it there, and change to a .@ var for security ends.

Hercules Elf Bot - Dec 24, 2011 21:53

Originally posted by [b]Xantara[/b]
[b]Confirmed.[/b] Typo is in the first quote (ie. it should be a scope variable). Or, I believe, those two lines can be deleted.

This post has been edited by Xantara on Dec 24, 2011 21:55

Hercules Elf Bot - Dec 25, 2011 21:07

Originally posted by [b]Masao[/b]
[b]Fixed.[/b] Changed variable type from .@ to @ and added missing @ variable at the shown lines above.