Issue information

Issue ID
#5130
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
Dec 20, 2011 6:33
Last Post
Hercules Elf Bot
Apr 18, 2012 9:36
Confirmation
Yes (0)
No (1)

Hercules Elf Bot - Dec 20, 2011 6:33

Originally posted by [b]dreamunreal[/b]
test charater:
job: assassin baselv:95 joblv: 50
cRo screenshot:
[attachment=345:官方截图.jpg]


ra sceeenshot:
[attachment=346:ra截图.jpg]

RA formulas is right
[CODE]
status->hit += level + status->dex + status->luk/3 + 175; //base level + ( every 1 dex = +1 hit ) + (every 3 luk = +1 hit) + 175
status->flee += level + status->agi + status->luk/5 + 100; //base level + ( every 1 agi = +1 flee ) + (every 5 luk = +1 flee) + 100
status->def2 += (int)(((float)level + status->vit)/2 + ((float)status->agi/5)); //base level + (every 2 agi = +1 def) + (every 5 agi = +1 def)
status->mdef2 += (int)(status->int_ + ((float)level/4) + ((float)status->dex/5) + ((float)status->vit/5)); //(every 4 base level = +1 mdef) + (every 1 int = +1 mdef) + (every 5 dex = +1 mdef) + (every 5 vit = +1 mdef)
[/CODE]

but why use this function to edit hit/flee after calc?
[CODE]
#if REMODE
/**
* Renewal Absolute Bonus to be applied after all bonuses were applied (so % bonuses on say, skills, don't affect them)
**/
void status_renewal_postcalc(struct status_data* status, int flag) {
if( flag&SCB_FLEE )
status->flee += 100;
if( flag&SCB_HIT )
status->hit += 175;
return;
}
#endif
[/CODE]

Hercules Elf Bot - Dec 20, 2011 6:52

Originally posted by [b]Protimus[/b]
You are right.

I hadn't noticed that there was this new function. You can do a test for me? Remove the status_renewal_postcalc function and see if the status are correct.

I think that function it is not necessary. If is, just remove the part of the additions in the formulas.

This post has been edited by Protimus on Dec 20, 2011 6:56

Hercules Elf Bot - Dec 20, 2011 6:57

Originally posted by [b]Ind[/b]
which one is correct? are these 175/100 rough bonuses affected (in officials) by % modifiers such as archer's concentration skill? if it's not affected then postcalc function is correct (and the 175/100 should be removed from status_calc_misc), otherwise if the rough bonus are effected by % modifiers then postcalc should be removed

This post has been edited by Ind on Dec 20, 2011 6:58

Hercules Elf Bot - Dec 20, 2011 7:00

Originally posted by [b]dreamunreal[/b]
If you remove this function,
flee / hit on the perfect equivalent official
Screenshot ignored.
Please discuss your own, if confirmed as a bug

sorry for my bad english.

Hercules Elf Bot - Dec 20, 2011 7:08

Originally posted by [b]Protimus[/b]
I think it applies to the formula, modifiers are used up in the formula itself. But it is better to have more informations...

Hercules Elf Bot - Dec 20, 2011 7:18

Originally posted by [b]dreamunreal[/b]
cRo is closing....
i can't get more test data- - ~.
perhaps it's my last time to login cro...

Hercules Elf Bot - Dec 20, 2011 7:29

Originally posted by [b]Ind[/b]
I'll ask jakered to test it for us since you wont be able to -- he plays on kRO.

Hercules Elf Bot - Dec 20, 2011 7:31

Originally posted by [b]Protimus[/b]
Well... I removed the function temporarily.

[url="http://sourceforge.net/apps/trac/rathena/changeset/15179"]http://sourceforge.net/apps/trac/rathena/changeset/15179[/url]

I'm pretty sure that it works, but if someone can test on iRO / kRO or bRO, would be good.

This post has been edited by Protimus on Dec 20, 2011 7:37