Issue information

Issue ID
#5140
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
Dec 21, 2011 21:20
Last Post
Hercules Elf Bot
Apr 5, 2012 10:26
Confirmation
N/A

Hercules Elf Bot - Dec 21, 2011 21:20

Originally posted by [b]Toshiro[/b]
/trunk/src/map/[url="http://sourceforge.net/apps/trac/rathena/browser/trunk/src/map/itemdb.c#L767"]itemdb.c:767[/url]
[code]if( id->type < 0 || id->type == IT_UNKNOWN || id->type == IT_UNKNOWN2 || ( id->type > IT_THROWWEAPON && id->type < IT_CASH ) || id->type >= IT_MAX )[/code]
should be
[code]if( id->type < 0 || id->type == IT_UNKNOWN || id->type == IT_UNKNOWN2 || ( id->type > IT_DELAYCONSUME && id->type < IT_THROWWEAPON ) || id->type >= IT_MAX )[/code]
because how it is currently, it checks if the item type is between IT_THROWWEAPON (17) and IT_CASH (18), and not for real invalid item types (12, ..., 16), which would pass this check.
The bug exists since [url="http://sourceforge.net/apps/trac/rathena/changeset/15009"]r15009[/url].

Hercules Elf Bot - Dec 22, 2011 9:08

Originally posted by [b]Ind[/b]
thanks.

This post has been edited by Ind on Dec 22, 2011 9:09

Hercules Elf Bot - Dec 22, 2011 9:10

Originally posted by [b]Ind[/b]
Fixed in [rev=15207]