Different output between original and alias atcommand

Issue information

Issue ID

#5225

Status

Fixed

Severity

Fair

Started

Hercules Elf Bot

Jan 8, 2012 23:01

Last Post

Hercules Elf Bot

Apr 19, 2012 15:35

Confirmation

Yes (1)

No (0)

Hercules Elf Bot - Jan 8, 2012 23:01

Originally posted by [b]Xantara[/b]
I think this is a related issue to the other atcommand reports but separate since the following doesn't deal with import nor reloading of the atcommands. Thus, I decided to create a new report.

[b]Info:[/b]
Different output between an alias and the original atcommand.
Revision 15409

[b]To reproduce:[/b]
atcommand_athena.conf[quote]
// Displays a list of @ commands available to the player.
commands: 0,0 [cmd][/quote]

[b]In-game:[/b]
Player with a GM level 0 uses @commands and gets an output of 6 commands (which is correct).
If the same player uses @cmd, the output shows 299 commands (ie. a list of all the commands).

This post has been edited by Xantara on Jan 8, 2012 23:01

Hercules Elf Bot - Jan 10, 2012 17:36

Originally posted by [b]Ind[/b]
ah, it's because it uses a very weird method to check wether to display @ or # commands,
[CODE]
if( gm_lvl < cmd->level && stristr(command,"commands") )
continue;
if( gm_lvl < cmd->level2 && stristr(command,"charcommands") )
continue;
[/CODE]
this needs to be fixed (i.e. finding a more accurate/efficient way to detect weather its a @ or a #)

Hercules Elf Bot - Jan 10, 2012 20:40

Originally posted by [b]Xantara[/b]
Yea. I made a fix (but I am currently at school). Not sure if my way is the best or more efficient but I'll show it to you when I get back home (in 4-5 hrs from now =[ )

This post has been edited by Xantara on Jan 10, 2012 20:59

Hercules Elf Bot - Jan 12, 2012 1:14

Originally posted by [b]Ind[/b]
Fix by xantara applied in [rev=15434]