Hercules Elf Bot - Jan 19, 2012 11:49
Originally posted by [b]calciumkid[/b]
Some classes are doing full critical hits with less than 10% critical rates. I'm really not sure how much more info I can get but that's al I have for now. I'll post up screens of the classes that crit.
Stalkers.
[img]http://i222.photobucket.com/albums/dd227/aaaronyeoh_93/screeniHeartRO214.jpg[/img]
[img]http://i222.photobucket.com/albums/dd227/aaaronyeoh_93/screeniHeartRO215.jpg[/img]
Soul Linker
[img]http://i222.photobucket.com/albums/dd227/aaaronyeoh_93/screeniHeartRO216.jpg[/img]
Clowns
[img]http://i222.photobucket.com/albums/dd227/aaaronyeoh_93/screeniHeartRO217.jpg[/img]
Lord Knights
[img]http://i222.photobucket.com/albums/dd227/aaaronyeoh_93/screeniHeartRO220.jpg[/img]
There's a chance that all the classes are affected by this. Can you check it out? Please and thank you.
Another thing is Sniper. When they have teh True Sight buff that increases Crit, their crit rate goes down.
Without True Sight
[img]http://i44.tinypic.com/sdp8yb.jpg[/img]
With True Sight
[img]http://i41.tinypic.com/90zzhv.jpg[/img]
[size=4]This happens only on a PvP situation. Crits are normal vs mobs. [/size]
Confirmations?
This post has been edited by
calciumkid
on Jan 19, 2012 11:49
Hercules Elf Bot - Jan 19, 2012 12:30
Originally posted by [b]ngek202[/b]
what SVN is this?
Hercules Elf Bot - Jan 19, 2012 12:36
Originally posted by [b]Ind[/b]
Confirmed vs players and mobs. looks like the critical value is somehow reversed -- higher critical rate = less critical while lower critical rate = more critical. maybe related to the rand math from [rev=15483]?
This post has been edited by
Ind
on Jan 19, 2012 12:39
Hercules Elf Bot - Jan 19, 2012 12:50
Originally posted by [b]calciumkid[/b]
Could be, I'm unsure the rev this began occuring in as I only update ihRO every 3/4 days.
Hercules Elf Bot - Jan 19, 2012 13:00
Originally posted by [b]Ind[/b]
[s]the random math change was applied 45h ago, are you in that revision range? [/s]
Dev Note: I've tested changing rdn() to rand() in the battle.c where the critical calculation is made, and it seems to have fixed it.
This post has been edited by
Ind
on Jan 19, 2012 13:04
Hercules Elf Bot - Jan 19, 2012 13:09
Originally posted by [b]calciumkid[/b]
Yes I'm in that range, as I last updated ihRO yesterday.
Hercules Elf Bot - Jan 19, 2012 14:46
Originally posted by [b]Gepard[/b]
I was unable to reproduce the bug in [rev=15497] on Windows 7 and Debian 32bit. Random number generator seems to work fine.
What OS are you using? What build configuration?
Are there any other issues? rnd() is used in so many places throughout the code, that is seems impossible to have it unnoticed.
Hercules Elf Bot - Jan 19, 2012 16:30
Originally posted by [b]Gepard[/b]
Ok, I've been testing it with quite high crit vs low luk targets...
To reproduce, it is required to have low crit attacker vs high crit-shield target. In such case crit will go negative and a negative-signed to unsigned random number comparison will occur, with unwanted result.
Fixed in [rev=15498].
Affected revisions are 15483-15497.
This post has been edited by
Gepard
on Jan 19, 2012 16:57