r15504 memory leaks found map-server_sql.exe.leaks
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#5261
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jan 22, 2012 19:24
Last Post
Hercules Elf Bot
Apr 19, 2012 18:07
Confirmation
Hercules Elf Bot - Jan 22, 2012 19:24
Originally posted by [b]ngek202[/b]
Fresh SVN Checkout
map-server_sql.exe.leaks
Fresh SVN Checkout
map-server_sql.exe.leaks
Hercules Elf Bot - Jan 22, 2012 22:29
Originally posted by [b]xazax[/b]
skill_blockpc_start allocates skill_cd and skill_blockpc_end removes it if it is no longer used.
I suspect, once the server is shut down, and some cooldown still last, it won't be cleaned up, and the memory manager detect those as memory leak.
Edit: I did not notice db_destroy(skillcd_db);, so cooldowns are cleaned up on shutdown.
skill_blockpc_start allocates skill_cd and skill_blockpc_end removes it if it is no longer used.
I suspect, once the server is shut down, and some cooldown still last, it won't be cleaned up, and the memory manager detect those as memory leak.
Edit: I did not notice db_destroy(skillcd_db);, so cooldowns are cleaned up on shutdown.
This post has been edited by xazax on Jan 22, 2012 22:40
Hercules Elf Bot - Jan 23, 2012 13:45
Originally posted by [b]Gepard[/b]
Fixed in [rev=15509].
Fixed in [rev=15509].
Hercules Elf Bot - Jan 23, 2012 14:48
Originally posted by [b]ngek202[/b]
[quote name='xazax' timestamp='1327271384' post='6718']
skill_blockpc_start allocates skill_cd and skill_blockpc_end removes it if it is no longer used.I suspect, once the server is shut down, and some cooldown still last, it won't be cleaned up, and the memory manager detect those as memory leak.Edit: I did not notice db_destroy(skillcd_db);, so cooldowns are cleaned up on shutdown.
[/quote]
exactly when doing @mapexit
good thing it's now fixed
[quote name='xazax' timestamp='1327271384' post='6718']
skill_blockpc_start allocates skill_cd and skill_blockpc_end removes it if it is no longer used.I suspect, once the server is shut down, and some cooldown still last, it won't be cleaned up, and the memory manager detect those as memory leak.Edit: I did not notice db_destroy(skillcd_db);, so cooldowns are cleaned up on shutdown.
[/quote]
exactly when doing @mapexit
good thing it's now fixed