Issue information

Issue ID
#5276
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jan 30, 2012 2:51
Last Post
Hercules Elf Bot
Mar 5, 2012 16:22
Confirmation
Yes (1)
No (0)

Hercules Elf Bot - Jan 30, 2012 2:51

Originally posted by [b]mkbu95[/b]
On the code below there's no need for such verification:
else if (dmdswrd_Q > 2 && dmdswrd_Q < 5) {
since after that it will switch thru dmdswrd_Q == 3 or dmdswrd_Q == 4

NPC:[CODE]cmd_in02,32,140,4 script Chief#cmd 49,{[/CODE]
Code:[CODEBOX]else if (dmdswrd_Q > 2 && dmdswrd_Q < 5) {
switch(dmdswrd_Q) {
case 3:
mes "[Tausupa]";
mes "Oh, how are my friends";
mes "doing? I really wish that";
mes "I could have delivered that";
mes "Koserahserah personally,";
mes "but I can't shirk my duties as";
mes "Village Chief and protector.";
next;
mes "^3355FFYou give Tausupa the";
mes "Meruchieligu wine that";
mes "Rochito asked you to deliver.^000000";
next;
mes "[Tausupa]";
mes "Ah... How very kind of";
mes "them! They really sent me";
mes "this wine? I'm truly touched...";
mes "Rockha must have chosen";
mes "this--I'll be sure to enjoy it.";
next;
mes "[Tausupa]";
mes "Would you please express my";
mes "thanks to my friends, ^3355FFRochito^000000,";
mes "and ^3355FFRockha^000000? It's been far too";
mes "long since I've seen them, but";
mes "I hope that I get a chance to";
mes "visit them someday soon.";
set dmdswrd_Q,4;
close;
case 4:
mes "[Tausupa]";
mes "Would you please express my";
mes "thanks to my friends, ^3355FFRochito^000000,";
mes "and ^3355FFRockha^000000? It's been far too";
mes "long since I've seen them, but";
mes "I hope that I get a chance to";
mes "visit them someday soon.";
close;
}
}[/CODEBOX]

Thanks

Hercules Elf Bot - Jan 30, 2012 2:54

Originally posted by [b]mkbu95[/b]
@edit
I forgot to mention it happens again on other npcs:
Like:[CODE]comodo,164,291,4 script Sokoko#cmd 73,{
if (dmdswrd_Q == 6 || dmdswrd_Q == 7) {
switch(dmdswrd_Q) {[/CODE]
and then only has case 6 and case 7

Hercules Elf Bot - Jan 31, 2012 17:59

Originally posted by [b]Brian[/b]
Updating status to: [b]Fixed[/b] in [rev=15535].

This post has been edited by Brian on Feb 1, 2012 4:09