Issue information

Issue ID
#5291
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Feb 5, 2012 15:57
Last Post
Hercules Elf Bot
Apr 19, 2012 18:23
Confirmation
N/A

Hercules Elf Bot - Feb 5, 2012 15:57

Originally posted by [b]Napster[/b]
Myserver report core stack dump



[quote]
Registers:
eax=2019e82c ebx=7ffde000 ecx=00000007 edx=00000001 esi=0012fd54 edi=0012fd3c
eip=0071fd4b esp=0012fbb8 ebp=0012fd3c iopl=0 nv up ei pl nz na po nc
cs=001b ss=0023 ds=0023 es=0023 fs=003b gs=0000 efl=00010206[/quote]

in unit_walktoxy_timer




[quote]
{ //Guild Aura: Likely needs to be recoded, this method seems inefficient.
struct guild *g = sd->state.gmaster_flag;
int skill, strvit= 0, agidex = 0;
if ((skill = guild_checkskill(g, GD_LEADERSHIP)) > 0) strvit |= (skill&0xFFFF)<<16;
if ((skill = guild_checkskill(g, GD_GLORYWOUNDS)) > 0) strvit |= (skill&0xFFFF);
if ((skill = guild_checkskill(g, GD_SOULCOLD)) > 0) agidex |= (skill&0xFFFF)<<16;
[b]if ((skill = guild_checkskill(g, GD_HAWKEYES)) > 0) agidex |= skill&0xFFFF; <-- this line report[/b]
if (strvit || agidex)
{ // replaced redundant foreachinrange call with smaller and much more efficient iteration
for( i = 0; i < g->max_member; i++ )
{
if( g->member[i].online && g->member[i].sd && sd->bl.m == g->member[i].sd->bl.m && check_distance_bl(&sd->bl, &g->member[i].sd->bl, 2) )
{// perform the aura on the member as appropriate
skill_guildaura_sub(g->member[i].sd, sd->bl.id, strvit, agidex);
}
}
}
}[/quote]

I don't know this ploblem :(

please check thankyou

Hercules Elf Bot - Feb 8, 2012 23:57

Originally posted by [b]Ind[/b]
[CODE]
[21:52:46] <@Ind> http://rathena.org/board/tracker/issue-5291-mapserver-crashing-unit-walktoxy-timer/ i tried to reproduce but nothing crashed, perhaps his compiler doesn't like the missing parenthesis?

<...>: no reply[/CODE]
I will hope that is the issue, otherwise I have no damn idea. let me know if it doesn't work. [rev=15549]

Hercules Elf Bot - Feb 9, 2012 21:11

Originally posted by [b]Napster[/b]
thank you Ind :)