Issue information

Issue ID
#5315
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Feb 10, 2012 16:29
Last Post
Hercules Elf Bot
Jul 1, 2012 11:49
Confirmation
Yes (1)
No (0)

Hercules Elf Bot - Feb 10, 2012 16:29

Originally posted by [b]Napster[/b]
follow bug report : 5291

crashing again



[quote]
Registers:
eax=2007c574 ebx=7ffd4000 ecx=00000000 edx=0000002b esi=0012fd54 edi=0012fd3c
eip=0071fe0f esp=0012fbb8 ebp=0012fd3c iopl=0 nv up ei pl nz na pe nc
cs=001b ss=0023 ds=0023 es=0023 fs=003b gs=0000 efl=00010202[/quote]

core dump report



[quote]
{ //Guild Aura: Likely needs to be recoded, this method seems inefficient.
struct guild *g = sd->state.gmaster_flag;
int skill, strvit= 0, agidex = 0;
if ((skill = guild_checkskill(g, GD_LEADERSHIP)) > 0) strvit |= (skill&0xFFFF)<<16;
if ((skill = guild_checkskill(g, GD_GLORYWOUNDS)) > 0) strvit |= (skill&0xFFFF);
if ((skill = guild_checkskill(g, GD_SOULCOLD)) > 0) agidex |= (skill&0xFFFF)<<16;
if ((skill = guild_checkskill(g, GD_HAWKEYES)) > 0) agidex |= (skill&0xFFFF);
if (strvit || agidex)
{// replaced redundant foreachinrange call with smaller and much more efficient iteration
for( i = 0; i < g->max_member; i++ )
{
[b]if( g->member[i].online && g->member[i].sd && sd->bl.m == g->member[i].sd->bl.m && check_distance_bl(&sd->bl, &g->member[i].sd->bl, 2) ) <--- error this line[/b]
{// perform the aura on the member as appropriate
skill_guildaura_sub(g->member[i].sd, sd->bl.id, strvit, agidex);
}
}
}
}[/quote]


Ind pls Check again
Thankyou

Hercules Elf Bot - Feb 10, 2012 17:56

Originally posted by [b]Ind[/b]
hum O_O I think this is a false positive .-. what OS you run your server under?

Hercules Elf Bot - Feb 10, 2012 18:07

Originally posted by [b]Napster[/b]
Windows 2003 R2

you want check core dump files ?

Plz check your PM

This post has been edited by Napster on Feb 10, 2012 18:30

Hercules Elf Bot - Feb 10, 2012 20:07

Originally posted by [b]Ind[/b]
Thanks for sending me them but I don't really know what to do with them XD I've only debugged on gdb :x I'll pass to a more experienced developer

Hercules Elf Bot - Feb 10, 2012 20:55

Originally posted by [b]Napster[/b]
ok ^^ thanks for your help

i hope found this problem : )

Hercules Elf Bot - Feb 11, 2012 21:13

Originally posted by [b]sketchyphoenix[/b]
Make sure to go to conf/plugin_athena.conf and uncomment one of the following, but not both.

[CODE]// Crash reporting for Windows
//plugin: exchndl

// Alternative, improved crash reporting for Windows
//plugin: dbghelpplug[/CODE]

this will allow your server to print a stackdump when it crashes.

This post has been edited by sketchyphoenix on Feb 11, 2012 21:13

Hercules Elf Bot - Feb 11, 2012 21:20

Originally posted by [b]Napster[/b]
It should be a plugin to do for windows ?

Please recommend.


[color=#880000]exchndl[/color]
or

[color=#880000]dbghelpplug
[/color]

Hercules Elf Bot - Feb 11, 2012 21:28

Originally posted by [b]sketchyphoenix[/b]
exchndl should give enough information to read.

not sure if the dbghelpplug that comes with server 2003 is up to date to support all the symbols.

Hercules Elf Bot - Feb 11, 2012 22:08

Originally posted by [b]sketchyphoenix[/b]
try using dbghelpplug so i can see if that stackdump gives more information but from what i'm seeing so far, it looks like guild/guildmaster data for guild auras is getting filled with junk.

Hercules Elf Bot - Feb 11, 2012 22:34

Originally posted by [b]Napster[/b]
[quote name='sketchyphoenix' timestamp='1328998103' post='7003']
try using dbghelpplug so i can see if that stackdump gives more information but from what i'm seeing so far, it looks like guild/guildmaster data for guild auras is getting filled with junk.
[/quote]

Ok


I will try again.
The results are reported to them. :)

Hercules Elf Bot - Jul 1, 2012 11:49

Originally posted by [b]Ind[/b]
was fixed some months ago when i rewrote the guild aura (and took it out of unit walk stuff)