Skill Points redistribution

Originally posted by [b]Rytech[/b]
No. All the skill points gained from the 2nd job must be spend on 2nd job (1st job as well) skills before you can start putting points twords 3rd.

Originally posted by [b]Kenpachi[/b]
Rytech is right.

../conf/battle/player.conf[CODE]
// When set to yes, forces skill points gained from 1st class to be put into 1st class
// skills, and forces novice skill points to be put into the basic skill. (Note 1)
player_skillup_limit: yes
[/CODE]

Originally posted by [b]Poseid0n[/b]
My setup is already on "Yes", and it doesn't work, make the test please.

player_skillup_limit works for forces skills points gained from [b]1st class[/b] to be put [b]into 1st classe only[/b], according to description
But [b]he doesn't forces skills points gained from advance classe[/b] to be put into advance class skill before putting the other points in classe 3 skills.

Originally posted by [b]Kenpachi[/b]
Sorry, I was confused and misunderstood your post.
But since it's not related to a skill: ~moved to Core~

Originally posted by [b]Ind[/b]
Should be fixed by [rev=15594]

Originally posted by [b]Poseid0n[/b]
I think a problem persists :

[CODE]
if( sd->class_&JOBL_THIRD && skill_point < 107 )//bugreport:5329, require to spend all 2.x points in your 2.x
c &= MAPID_UPPERMASK;
[/CODE]

There are two ways to go class 3 :

for exemple :

Solution 1 :

--> High Novice (9 points)
--> High Swordman (39 or 49 points), depends on the level of job when it changes in Lord Knight (job 40 or job 50)
--> Lord Knight (69 points)
--> Rune Knight (49 points)
--> Total of job point before being Rune Knight: 117 or 127 points.

Solution 2 :

--> Novice (9 points)
--> Swordman (39 or 49 points), depends on the level of job when it changes in Knight (job 40 or job 50)
--> Knight (49 points)
--> Rune Knight (49 points)
--> Total of job point before being Rune Knight: 97 or 107 points.

Poseidon

Originally posted by [b]Ind[/b]
thanks for the info;
anyone else would like to do this / knows a efficient way? I'm out of imagination >:

Originally posted by [b]Poseid0n[/b]
I have notice an another bug with your update.

When you must put your skill point in advance skill before putting in classe 3 skills, It's not possible to put skill point in advance skill.

for example, if you are Ranger, after a reset, you have to put 49 skill point, in archer skill.
After, you must put 69 points in sniper skills, but the advance skill are not available.
(you can not up "wind walk", "falcon assaut", "true sight" and "sharp shooting", but the other skill from hunter, yes).

Poseidon

Ps : for now it is best to remove the update as it does not work properly.
Ps2 : for the algorithm, somethink like this :

[CODE]
if(skill_point <= 48)
{
must put in classe 1 skill
}
else
{
if(Class == Class 3 Trans)
{
if(skill_point <= 117)
{
must put in classe 2 OR advance skill
}
else
{
put your skill point where you want
}
}
else //if Class 3 Regular
{
if(skill_point <= 97)
{
must put in classe 2 skill
}
else
{
put your skill point where you want
}
}
}
[/CODE]

Originally posted by [b]Wildcard[/b]
Fixed in [url="http://sourceforge.net/apps/trac/rathena/changeset/15625"]r15625[/url]

Originally posted by [b]Poseid0n[/b]
Hello, I up this problem again ! (Sorry about that, but there still a bug).

All work fine but :

Il a caracter has change into classe 2 at the level job 40 (or before level job 50), it will lose 10 skill points when redistributing into classe 3 skill.

Exemple :

hight novice --> job 10 --> 9 skill point
hight thief --> job 40 --> 39 skill point
Stalker --> job 70 --> 69 skill point
Shadow Chaser --> job 50 --> 49 skill point (but with the bug, only 39 skill point can be put into classe 3 skill).

there is a loss of 10 skills point into classe 3 skills, and it is very anoying.

Poseidon

Originally posted by [b]EvilPuncker[/b]
perhaps it is related to this issue, but when I create a new character and do @job to any 3rd class and then use @allskills, I don't got any 3rd job skill maxed, neither Ii can lvl up any of them


PS: reproduce it with allskills: false

Originally posted by [b]Wildcard[/b]
[quote name='Poseid0n' timestamp='1330003428' post='7196']
Shadow Chaser --> job 50 --> 49 skill point (but with the bug, only 39 skill point can be put into classe 3 skill)
[/quote]

I specifically designed around this, and as I thought, cannot reproduce what you described, it works just fine for me. If you have been wildly using @job for your testing, please be aware of a couple pitfalls with it.
[list=1]
[*]It is possible to break out of the regular job tree with this command, and doing so can result in a queer job change level between 1st and 2nd job.
[*]It is further possible to accidentally jobchange into the NON-trans version of a 3rd job from a trans job. I imagine this might cause the effect you described, and is thus not really a bug at all. A point could be made, however, to sanitize @job a little to avoid such confusion. I will make a proposition and see what the other devs think about this.
[/list]

If you are sure none of the above is the issue, please report *exactly* how to reproduce your bug, with all @commands and/or npcs used.

[quote]perhaps it is related to this issue, but when I create a new character and do @job to any 3rd class and then use @allskills, I don't got any 3rd job skill maxed, neither Ii can lvl up any of them[/quote]

True, another side-effect of those inconsistencies you cause with @job. I'll get on it. Incidentally, this particular issue is only a display glitch, and relogging will enable you to use the skills.

Thank you for your time,
Wildcard