Hercules Elf Bot - Feb 20, 2012 15:32
Originally posted by [b]Wildcard[/b]
/doc/ea_job_system.txt could also be updated to reflect the addition of third classes, but really, it's easy enough to figure it out own your own. What confused me a lot more is that the source refers to the "ea jobs"
EAJ_ as MAPID_
and "job levels"
EAJL_ as JOBL_
Opinions on whether we could unify those conventions, and if, which one should we choose?
Hercules Elf Bot - Feb 21, 2012 12:39
Originally posted by [b]Gepard[/b]
Script engine defines are in [font=courier new,courier,monospace]db/const.txt[font=arial,helvetica,sans-serif], so it actually is naming inconsistency between [font=courier new,courier,monospace]const.txt[/font] and [font=courier new,courier,monospace]map.h[/font][/font][/font][font=arial, helvetica, sans-serif].[/font]
[font=arial, helvetica, sans-serif][font=courier new,courier,monospace]map.h[/font] defines are named this way because only map-server uses this convention. Char-server uses Gravity's numbering for player classes. So [font=courier new,courier,monospace]MAPID_X[/font] totally makes sense and is also self-explanatory ("id of the class X used internally by map-server"). I wouldn[/font]'t change this.
[font=arial, helvetica, sans-serif]I'm not sure about [/font][font="'courier new"]EAJ_.[/font] It still refers to eAthena, but it doesn't feel like a valid reason to rename it (and if it was to be renamed, we shouldn't just replace [font=courier new,courier,monospace]E[/font] with [font=courier new,courier,monospace]R[/font]). It is also used in several scripts: kafraExpress scripts (custom), novice guild warper (event) and two first class tutorial quests (official) and possibly in user-created scripts (possible compatibility break).
Hercules Elf Bot - Mar 5, 2012 9:13
Originally posted by [b]Mr. No One[/b]
Keeping the current version as a working alias would save you from breaking compatibility, yet giving you more space in customization and progress.
This post has been edited by
Mr. No One
on Mar 5, 2012 9:15
Hercules Elf Bot - Sep 5, 2012 22:10
Originally posted by [b]Akkarin[/b]
I'm setting this as Working as Intended, because there's no longer a documentation issue (fixed initial statement in [rev=16239]) and the rest doesn't need to be changed.