Card Trader

Originally posted by [b]Slim[/b]
[i]Did you test it?[/i] or you're just saying, I'm not in my personal computer right now but, I'm sure I tested it and it worked just fine.

Originally posted by [b]Emistry[/b]
ya...i saw that part in the new svn also..
it should be
close;

then end; command caused the player end up stucking..xD

[url="https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/npc/other/card_trader.txt"]https://rathena.svn.sourceforge.net/svnroot/rathena/trunk/npc/other/card_trader.txt[/url]
( the last line ^^ )


and...the point gained from the npc...is only for 1 Character ? ....i though it should be Account ?
if 1 char traded the card..but the other char cant use the point.. >.<

[hr]

Beside...i was thinking...
instead of using the method like this..

[CODE]if (.@clc_name$ == "Poring Card" || .@clc_name$ == "poring card") {[/CODE]
how about using the compare() ??

like this ?
[CODE]compare( .@clc_name$,"poring card" )[/CODE]
so that every input for "poring card" string will be accepted ?

not sure is it really good..xD
maybe there is some problem for this so you guys didnt tried this haha

Originally posted by [b]Emistry[/b]
but....could the script possible to made it like this ?

[url="http://pastebin.com/raw.php?i=TAQ9ek7S"]http://pastebin.com/raw.php?i=TAQ9ek7S[/url]

to make it shorter ? xD

the different just..
in original script..player insert the Card Name..
in the link above...
it search for the script that existed in Player Inventory..

i used an array to store the Card ID..because i believe not much server will extent their inventory size larger than 127.
so it could store all the Card ID in the Array.

just an idea ~

Originally posted by [b]Aleos[/b]
@Slim
The issue is because when players select "Can I exchange the points?" option, following it down to the case 2 leads you to the prize menu. If you notice closely if the .@points value is greater than the amount needed to purchase the items (the player has enough points) then their points are reduced, they get the item, and it breaks out, which leads to the abrupt end with no close. If the player does not have enough points then they are given the close2 option. I would suggest the close2 in the else be moved outside of the if-else statement which will resolve the issue.

Originally posted by [b]Slim[/b]
i'll be working on this, been kind of busy lately.

Originally posted by [b]Slim[/b]
I will just change the end; for close; the thing is that the script is supposed to handle caps and non-caps. example:

Poring Card
and
poring card

I also thought on using (compare) when i was doing the script but, what if they put "santa poring card" it will also have "poring card" and may cause some issues.

Originally posted by [b]Slim[/b]
[b]Fixed[/b] in [url="http://sourceforge.net/apps/trac/rathena/changeset/15681/"]r15681[/url]

Originally posted by [b]Daegaladh[/b]
You can also do:
[CODE]input .@clc_name$;
strtolower(.@clc_name$);[/CODE]

and leave all conditionals in lowercaps.

BTW: v1.0 Translated from the Official [Slim]
This is not true, Aegis script was translated into english by DoJo from ASB

Originally posted by [b]Slim[/b]
Scripting Languages are also considered Languages, as in general. Therefore, I translated it.

And yes, thank you I may check that out. What's best for it to be optimized.