Atk calculation

Originally posted by [b]Poseid0n[/b]
Can someone confirm that card effect increase the total damages and not only the weapon damage ?

Originally posted by [b]Poseid0n[/b]
I have founded more informations about this subject :

[url="http://www.gatheringro.ch/wiki/Renewal_Changes#Weapon_Damage"]http://www.gatheringro.ch/wiki/Renewal_Changes#Weapon_Damage[/url]

All is explain, and confirm what I said preaviously.

Poseidon

Originally posted by [b]Aleos[/b]
I can also confirm this. The effects of cards are being attached to the status too rather than [i]just[/i] the weapon.

Originally posted by [b]Wildcard[/b]
I assume you are talking about renewal ATK here. The formula currently employed is indeed far from correct. Research on that subject is ongoing, but I expect it will be a while before we get it done.

Originally posted by [b]Poseid0n[/b]
Up.

What about the progress on this change ? Do you have more information ?

This is a major change of Renewal and without it, many skills are not balanced. (Like Cross Inpact, Arrow Storm, Sacrifice, etc ... which inflict too much damage and disrupt the gameplay).

Poseidon

Originally posted by [b]MarkZD[/b]
[url="http://rathena.org/board/tracker/issue-5588-ninja-final-strike-killing-stroke/"]http://rathena.org/b...killing-stroke/[/url]
While looking for Final Strike sources I've found in bRO and iRO that this skill is not affected by racials card, just in the weapon atk.

Only Archer skeleton card would increase its final damage.

[quote][color=#000000][font=verdana, arial, sans-serif][size=2]Archer Skel adds 10% of the final damage (eg 30k becomes 33k), as oppose to hydra which add 20% of weapon attack or zipper bear which just adds flat attack.[/size][/font][/color][/quote]
[url="http://forums.irowiki.org/archive/index.php/t-43756.html"]http://forums.irowik...hp/t-43756.html[/url]

[quote]
[left]Cartas raciais não contam para aumentar o dano de ataque mortal, o maximo que poderia ocorrer é aumentar o dano de ataque da arma contra humanoides o que nao seria perceptivel para o dano. Só para constar:[/left]
[/quote]
Racials card doesn't increase final strike damage, maybe it'd occur is the weapon damage would increase against the race, but it wouldn't be noticeable to the damage.
Just for knowing.
[url="http://sites.levelupgames.com.br/Forum/ragnarok/forums/p/469291/4416814.aspx"]http://sites.levelup...91/4416814.aspx[/url]

[quote][color=#4D4D4D][font=Tahoma, Calibri][size=4]Sim isso foi relatado no periodo beta da Renovação, as melhores opções são carta que deêm ataque como Andre, Zipper, Lobo, Zenorc e por enquanto a carta esqueleto arqueiro, que aumenta o dano total com base na % da carta.[/size][/font][/color][/quote]

It was noticed in the beta renewal period, the better options are cards that increase atk as Andre, Zipper, Wolf, Zenorc and for while Archer Skeleton Card which increase damage in the % base of the card.
[url="http://ninjasiga.forumeiros.com/t363-mudanca-no-ataque-mortal"]http://ninjasiga.for...o-ataque-mortal[/url]

I think it's related to this report in any way as it shows racial cards add just to weapon damage, not tusre if it's just to Final Strike, but as it's said in this bug report it should be to all.

Originally posted by [b]Angezerus[/b]
What's the status of this? Numerous skill and core issues are present because of this...

I post the quote here I posted in the mentioned issues. Hope it can help.
[quote]
[left][size=5][u][b][font="arial, sans-serif"][color="#000000"]ATK = sATK * 2 + wATK + eATK + masteries[/color][/font][/b][/u][/size][/left]


[u]STATUS ATK = floor ( Base level / 4 + STR + DEX / 5 + LUK / 3)[/u][list]
[*]Normally Neutral except when using Mild Wind.
[*]Ignores element resistance effects such as Raydric Card or Asprika.
[*]Ignores % ATK item effects such as The Sign or Hydra Card.
[/list]
[u]Weapon ATK = (Base Weapon ATK + Variance + STR + Bonus Refinement Bonus) * Size Penalty[/u]
[indent=1]Variance = ± 0.05 * Weapon Level * Base Weapon ATK[/indent]
[indent=1]STR Bonus = Base Weapon ATK * STR/200[/indent][list]
[*]Affected by weapon element when using a melee weapon.
[*]Affected by ammunition element when using a ranged weapon or specific skill.
[*]Affected by element resistance effects such as Raydric Card or Asprika.
[*]Increased by % ATK item effects such as The Sign or Hydra Card.
[*]Multiplied by 5 when affected by Enchant Deadly Poison .
[*]Though the STR bonus takes Element , it is still considered Neutral .
[*]STR Bonus is always reduced by Ghost armor.
[*]STR Bonus is only reduced by Neutral resistance like Raydric card, if the weapon is Neutral too.
[*]Variance is a random number ranging from (-5% * Weapon Level * Base Weapon ATK) to (5% * Weapon Level * Base Weapon ATK)
[/list]
[u]Equipment ATK is the sum of ATK gained from equips other than weapons. Support buffs tend to increase this ATK, too, but not all of them fit into this category.[/u][list]
[*]Affected by weapon element when using a melee weapon.
[*]Affected by ammunition element when using a ranged weapon or specific skill.
[*]Ammunition ATK is added here when using DEX based weapon.
[*]Any +ATK you get from cards, including cards in weapon, is added here.
[*]Affected by element resistance effects like Raydric Card or Asprika.
[*]Increased by % ATK item effects like The Sign and Hydra Card.
[*]Multiplied by 4 when affected by Enchant Deadly Poison.
[/list]
[u]Mastery ATK is a special kind of ATK that has no elemental properties. While most masteries come from Passive Skills , there are some Active Skills such as Camouflage or Zen.[/u][list]
[*]Because masteries are not elemental, they are unaffected by Ghost armors or Raydric Cards.
[*]Since masteries are direct increases to ATK, they are affected by skill modifiers, DEF and damage increasing/decreasing effects.
[/list]
[/quote]

Originally posted by [b]Smoke[/b]
I was just going through the code for this in status_base_atk and saw this :


[CODE]#ifdef RENEWAL
rstr =
#endif
str = status->dex;
dex = status->str;
} else {
#ifdef RENEWAL
rstr =
#endif
str = status->str;
dex = status->dex;[/CODE]

where str = status->dex;
dex = status->str;

does this seem alright?

Originally posted by [b]Angezerus[/b]
[quote][color=#000000]if (flag)[/color][/quote]

If "flag" means ranged (bow/instrument/whip/gun) attack, then this is the dex/str switching part. So it's okay. But still, rA doesn't use the fully renewal calculation, what is posted above.

I think this should be a high priority, because of the many bugs with attacks (and skills), just as I mentioned above.

Originally posted by [b]Smoke[/b]
Yes I just referred to my coding and saw the same flag / weapon dex/str swtiching thing.

This is the current formula used by rA and I'm testing on my current svn compared to my character on iRO.
[CODE]str = (rstr*10 + dex*10/5 + status->luk*10/3 + ((TBL_PC*)bl)->status.base_level*10/4)/10;[/CODE]
I'm not sure about rA's other status atk bonuses but this is accurate. I've got 124 batk on iRO and on my server.
Also it looks like they've removed the x2 crit bonus for katars, on iRO*.

Originally posted by [b]Angezerus[/b]
[quote name='Smoke' timestamp='1341585150' post='11664']
Yes I just referred to my coding and saw the same flag / weapon dex/str swtiching thing.This is the current formula used by rA and I'm testing on my current svn compared to my character on iRO.[CODE]str = (rstr*10 + dex*10/5 + status->luk*10/3 + ((TBL_PC*)bl)->status.base_level*10/4)/10;[/CODE]I'm not sure about rA's other status atk bonuses but this is accurate. I've got 124 batk on iRO and on my server.Also it looks like they've removed the x2 crit bonus for katars.
[/quote]

Crit bonus is working for me.

Originally posted by [b]Angezerus[/b]
Bump?

Originally posted by [b]malufett[/b]
bumpy for Wildcard...any news/progress??

Originally posted by [b]Wildcard[/b]
Pending the final word on the svn organization.. Research for melee and ranged physical damage largely done, thought lots and lots of rewriting and research on status effects and skill modifiers remain to be done.

Originally posted by [b]Lighta[/b]
Well I think status_effect and skill_modifier will probably have there own report, most of them affecting dammage anyway, ATK_ADD, wd.dammage etc....
Now about atk formula and manipulation eatk is the main problem, since right now weapon and other equipement share the same bonus wich mean increase the same atk in the end wich shouldn't be the case.
(Ok that doesn't matter for calculating basic ATK as it's show in formula (since it's just a +) but will have issue altering those value separatly, like EDP for instance should increase wtak*4 and eatk*5
Masteries give elemental issue, since one again they all glue together.

Originally posted by [b]Angezerus[/b]
I see. Well, I hope we can use it soon

Originally posted by [b]Nyx[/b]
Bump ~

Originally posted by [b]Poseid0n[/b]
Up. Some News about this main update ?

Originally posted by [b]Poseid0n[/b]
Up.

Originally posted by [b]Angezerus[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3]Bumper [====[]=======[]====][/size][/font][/color]
[color=#282828][font=helvetica, arial, sans-serif][size=3]( ●[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]●(●[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]● (●[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]● )●[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]● )●[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]● )[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]●(●[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]● )[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]● )(●[/size][/font][/color][sub]ٮ [/sub][color=#282828][font=helvetica, arial, sans-serif][size=3]●)[/size][/font][/color]

[color=#282828][font=helvetica, arial, sans-serif][size=3]Is this gonna be implemented or is there someone working on it? Do you need info or help or something? Please, we really need this stuff [/size][/font][/color]

Originally posted by [b]Poseid0n[/b]
Up ...

Without this main updage, a lot of damages are wrong ... the players begin to be bored with this bug. Can we expect a change ? Or Rathena will never fix this bug ? It is maybe the most important bug, and nobody do something ...

Originally posted by [b]emong[/b]
Bump

Originally posted by [b]jTynne[/b]
This is a rampant issue and renders many classes having to be nerfed in fresh installs, even on LR servers. Cross Impact can deal well over 140k using certain gears normally found in the game while under EDP conditions, and through exhaustive testing, cross-referencing and more, I've been nothing but frustrated. If the damage is wrong, the emulator itself is flawed. If I knew how to read/code source, I'd be all over this.. alas.

For those of you needing a quick fix, I'm making use of Lilith's damage management system. It's a custom src mod, but helps dramatically until this is fixed.

Originally posted by [b]Lighta[/b]
Main issue would be to separate differente ATK from battle, instead 1 long processing fonction. (Make it modular).
eatk_dmg,
watk_dmg,
satk_dmg,
Once this si done we could apply their modifier more easely, (like %card does't affect stak, or elemental bonus for watk etc etc...).
Even without that since the old mecanic is like 1big dammage there some things annoying, like wich dammage part should be split if multiple targets....

Originally posted by [b]Angezerus[/b]
[quote name='Lighta' timestamp='1350392832' post='15010']
Main issue would be to separate differente ATK from battle, instead 1 long processing fonction. (Make it modular).eatk_dmg,watk_dmg,satk_dmg,Once this si done we could apply their modifier more easely, (like %card does't affect stak, or elemental bonus for watk etc etc...).Even without that since the old mecanic is like 1big dammage there some things annoying, like wich dammage part should be split if multiple targets....
[/quote]

Very well said. Though it's a quite challenging job we might say

Originally posted by [b]malufett[/b]
Hi guys,

Me and Lighta will start working on it since Epoque and Wildcard disappeared for a long time and got no news about this..anyway even though Lighta didn't agreed yet however he told us that he is willing to help and he already made some part of it...so I'm encouraging him to help me..

but this will be not fulfill very soon..but still coming soon since this is a priority ..

Originally posted by [b]GM Takumirai[/b]
this is a good new, just let us know how we can help..

Originally posted by [b]Angezerus[/b]
Great news