nocommand mapflag issue
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#5525
Status
Working as Intended
Severity
None
Started
Hercules Elf Bot
Mar 31, 2012 2:36
Last Post
Hercules Elf Bot
May 18, 2012 11:45
Confirmation
Hercules Elf Bot - Mar 31, 2012 2:36
Originally posted by [b]Kaito_Kid[/b]
I was trying to disable commands on a certain map except for Event GMs
Here is my entry
[CODE]
MAP<tab>mapflag<tab>nocommand<tab>Minimum Group ID to bypass
quiz_02 mapflag nocommand 3
[/CODE]
I put it on my [b]nocommand.txt[/b] inside the mapflag folder also I added this line on [b]scripts_mapflags.conf[/b]
[CODE]
npc: conf/mapflag/nocommand.txt
[/CODE]
My entry seems valid but ingame still Group IDs equal/above 3 doesn't bypass the mapflag except for Group ID 99(Admin).
I was trying to disable commands on a certain map except for Event GMs
Here is my entry
[CODE]
MAP<tab>mapflag<tab>nocommand<tab>Minimum Group ID to bypass
quiz_02 mapflag nocommand 3
[/CODE]
I put it on my [b]nocommand.txt[/b] inside the mapflag folder also I added this line on [b]scripts_mapflags.conf[/b]
[CODE]
npc: conf/mapflag/nocommand.txt
[/CODE]
My entry seems valid but ingame still Group IDs equal/above 3 doesn't bypass the mapflag except for Group ID 99(Admin).
This post has been edited by Kaito_Kid on Mar 31, 2012 2:37
Hercules Elf Bot - May 2, 2012 8:37
Originally posted by [b]Kaito_Kid[/b]
I have solved my own issue.
This is the cause
[CODE]
if ( map[sd->bl.m].nocommand && pc_get_group_level(sd) < map[sd->bl.m].nocommand ) {
[/CODE]
Due to the changes made by rAthena that instead of an account level it was changed into group id
It should be:
[CODE]
if ( map[sd->bl.m].nocommand && pc_get_group_id(sd) < map[sd->bl.m].nocommand ) {
[/CODE]
That will fix nocommand mapflag that will allow the group id to bypass the mapflag specified on it
I have solved my own issue.
This is the cause
[CODE]
if ( map[sd->bl.m].nocommand && pc_get_group_level(sd) < map[sd->bl.m].nocommand ) {
[/CODE]
Due to the changes made by rAthena that instead of an account level it was changed into group id
It should be:
[CODE]
if ( map[sd->bl.m].nocommand && pc_get_group_id(sd) < map[sd->bl.m].nocommand ) {
[/CODE]
That will fix nocommand mapflag that will allow the group id to bypass the mapflag specified on it
Hercules Elf Bot - May 2, 2012 18:16
Originally posted by [b]Brian[/b]
I believe this is working as intended.
The 4th column is Group Level because higher GroupID doesn't always mean [i]more privileges[/i].
[code]MAP<tab>mapflag<tab>nocommand<tab>Minimum Group Level to bypass[/code]
Group [b]Level[/b] can be set in [svn=trunk/conf/groups.conf]
I believe this is working as intended.
The 4th column is Group Level because higher GroupID doesn't always mean [i]more privileges[/i].
[code]MAP<tab>mapflag<tab>nocommand<tab>Minimum Group Level to bypass[/code]
Group [b]Level[/b] can be set in [svn=trunk/conf/groups.conf]
This post has been edited by Brian on May 2, 2012 22:44
Hercules Elf Bot - May 2, 2012 22:42
Originally posted by [b]Kaito_Kid[/b]
Now I understand.
I thought the group ID was the same with the group level.
Now I understand.
I thought the group ID was the same with the group level.