Super Novice Spirit weapons

Originally posted by [b]DeePee[/b]
http://irowiki.org/wiki/Super_Novice_Spirit

[code]
if (sd->sc.data[SC_SPIRIT] && sd->sc.data[SC_SPIRIT]->val2 == SL_SUPERNOVICE) {
//Spirit of Super Novice equip bonuses. [Skotlex]
if (sd->status.base_level > 90 && item->equip & EQP_HELM)
return 1; //Can equip all helms

if (sd->status.base_level > 96 && item->equip & EQP_ARMS && item->type == IT_WEAPON)
switch(item->look) { //In weapons, the look determines type of weapon.
case W_DAGGER: //Level 4 Knives are equippable.. this means all knives, I'd guess?
case W_1HSWORD: //All 1H swords
case W_1HAXE: //All 1H Axes
case W_MACE: //All 1H Maces
case W_STAFF: //All 1H Staves
return 1;
}
}
[/code]

The description on iROWiki is a bit vague, but there's at least one mistake here.

[quote]Super Novices above Base Lv. 96 will temporarily be able to equip all [b]level four[/b] [url="http://irowiki.org/wiki/Dagger"]Daggers[/url], [url="http://irowiki.org/wiki/One_Handed_Sword"]1h Swords[/url], [url="http://irowiki.org/wiki/Axe"]Axes[/url], [url="http://irowiki.org/wiki/Mace"]Maces[/url] and [url="http://irowiki.org/wiki/Staff"]Staves[/url].[/quote]

At the very least, there should be a check whether Daggers are Level 4, which it currently does not do. However, does this Level 4 also apply to the other weapons? Like I said, the description is a bit vague, so it can be either. Would need some checking up.

http://ro.doddlercon.com/guides/soullinker.html

[quote][size="-1"]Super Novices at or above lv 96 can equip any lv 4 weapons of type One-Handed Swords, Maces, Axes, Staffs, and Daggers.[/size][/quote]

Doddler however makes it pretty clear that the Level 4 restriction applies to all weapons. So I'm pretty sure all types would need a check on whether they are Level 4.

Also, it says "1h Swords, Axes, Maces, etcetera.". This is the same vague description. Does this mean only 1h Swords or also only 1h Maces, 1h Axes, etcetera? Or should it allow 2h Staves, 2h Axes and such, too, meaning the 1h only applies to Swords?

Doddler doesn't really make this clear either. It's either "1h Swords, 1h Maces, 1h Axes" or "1h Swords, 1h/2h Maces, 1h/2h Axes". From my interpretation however, I think 2-handed Axes and 2-handed Staves should be wearable as well.

iROWiki more or less confirms on the Super Novice page that Kronos can be equipped, which is a Two-handed Staff. Daggers and Maces are always One-handed so that just leaves Axes to be confirmed. However, I think we can be certain that this can at least be the semi-correct code:

[code]
if (sd->sc.data[SC_SPIRIT] && sd->sc.data[SC_SPIRIT]->val2 == SL_SUPERNOVICE) {
//Spirit of Super Novice equip bonuses. [Skotlex]
if (sd->status.base_level > 90 && item->equip & EQP_HELM)
return 1; //Can equip all helms

if (sd->status.base_level > 96 && item->equip & EQP_ARMS && item->type == IT_WEAPON && item->wlv == 4)
switch(item->look) { //In weapons, the look determines type of weapon.
case W_DAGGER: //Level 4 Knives are equippable.. this means all knives, I'd guess?
case W_1HSWORD: //All 1H swords
case W_1HAXE: //All 1H Axes
case W_MACE: //All 1H Maces
case W_STAFF: //All 1H Staves
case W_2HSTAFF: //All 2H Staves
return 1;
}
}
[/code]