Originally posted by [b]Ai4rei[/b]
http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=560
Probably corresponding to Changelog:
CODE
2007/11/18
* Replaced jA's way of allocating npc shop data with a simple dynamic
array that gets allocated during loading and freed on unload
- automatically fixes bugreport:404, which would otherwise require
manipulating the npcname_db (the original author didn't, hence the bug)
- now a supporting variable 'count' is used for tracking the length
instead of an extra dummy entry at the end of the shop list
- partially removed the MAX_SHOPITEM restriction (if this was written
properly, the system could support an unlimited amount of entries)
The attempt to load following NPC:
CODE
prontera,163,186,3 shop TestmeCardShop 117,4001:-1,4002:-1,4003:-1,4004:-1,4005:-1,4006:-1,4007:-1,4008:-1,4009:-1,4010:-1,4011:-1,4012:-1,4013:-1,4014:-1,4015:-1,4016:-1,4017:-1,4018:-1,4019:-1,4020:-1,4021:-1,4022:-1,4023:-1,4024:-1,4025:-1,4026:-1,4027:-1,4028:-1,4029:-1,4030:-1,4031:-1,4032:-1,4033:-1,4034:-1,4035:-1,4036:-1,4037:-1,4038:-1,4039:-1,4040:-1,4041:-1,4042:-1,4043:-1,4044:-1,4045:-1,4046:-1,4047:-1,4048:-1,4049:-1,4050:-1,4051:-1,4052:-1,4053:-1,4054:-1,4055:-1,4056:-1,4057:-1,4058:-1,4059:-1,4060:-1,4061:-1,4062:-1,4063:-1,4064:-1,4065:-1,4066:-1,4067:-1,4068:-1,4069:-1,4070:-1,4071:-1,4072:-1,4073:-1,4074:-1,4075:-1,4076:-1,4077:-1,4078:-1,4079:-1,4080:-1,4081:-1,4082:-1,4083:-1,4084:-1,4085:-1,4086:-1,4087:-1,4088:-1,4089:-1,4090:-1,4091:-1,4092:-1,4093:-1,4094:-1,4095:-1,4096:-1,4097:-1,4098:-1,4099:-1,4100:-1,4101:-1,4102:-1,4103:-1,4104:-1,4105:-1,4106:-1,4107:-1,4108:-1,4109:-1,4110:-1,4111:-1,4112:-1,4113:-1,4114:-1,4115:-1,4116:-1,4117:-1,4118:-1,4119:-1,4120:-1,4121:-1,4122:-1,4123:-1,4124:-1,4125:-1,4126:-1,4127:-1,4128:-1,4129:-1,4130:-1,4131:-1,4132:-1,4133:-1,4134:-1,4135:-1,4136:-1,4137:-1,4138:-1,4139:-1,4140:-1,4141:-1,4142:-1,4143:-1,4144:-1,4145:-1,4146:-1,4147:-1,4148:-1,4149:-1,4150:-1,4151:-1,4152:-1,4153:-1,4154:-1,4155:-1,4156:-1,4157:-1,4158:-1,4159:-1,4160:-1,4161:-1,4162:-1,4163:-1,4164:-1,4165:-1,4166:-1,4167:-1,4168:-1,4169:-1,4170:-1,4171:-1,4172:-1,4173:-1,4174:-1,4175:-1,4176:-1,4177:-1,4178:-1,4179:-1,4180:-1,4181:-1,4182:-1,4183:-1,4184:-1,4185:-1,4186:-1,4187:-1,4188:-1,4189:-1,4190:-1,4191:-1,4192:-1,4193:-1,4194:-1,4195:-1,4196:-1,4197:-1,4198:-1,4199:-1,4200:-1,4201:-1,4202:-1,4203:-1,4204:-1,4205:-1,4206:-1,4207:-1,4208:-1,4209:-1,4210:-1,4211:-1,4212:-1,4213:-1,4214:-1,4215:-1,4216:-1,4217:-1,4218:-1,4219:-1,4220:-1,4221:-1,4222:-1,4223:-1,4224:-1,4225:-1,4226:-1,4227:-1,4228:-1,4229:-1,4230:-1,4231:-1,4232:-1,4233:-1,4234:-1,4235:-1,4236:-1,4237:-1,4238:-1,4239:-1,4240:-1,4241:-1,4242:-1,4243:-1,4244:-1,4245:-1,4246:-1,4247:-1,4248:-1,4249:-1,4250:-1,4251:-1,4252:-1,4253:-1,4254:-1,4255:-1,4256:-1,4257:-1,4258:-1,4259:-1,4260:-1,4261:-1,4262:-1,4263:-1,4264:-1,4265:-1,4266:-1,4267:-1,4268:-1,4269:-1,4270:-1,4271:-1,4272:-1,4273:-1,4274:-1,4275:-1,4276:-1,4277:-1,4278:-1,4279:-1,4280:-1,4281:-1,4282:-1,4283:-1,4284:-1,4285:-1,4286:-1,4287:-1,4288:-1,4289:-1,4290:-1,4291:-1,4292:-1,4293:-1,4294:-1,4295:-1,4296:-1,4297:-1,4298:-1,4299:-1,4300:-1,4301:-1,4302:-1,4303:-1,4304:-1,4305:-1,4306:-1,4307:-1,4308:-1,4309:-1,4310:-1,4311:-1,4312:-1,4313:-1,4314:-1,4315:-1,4316:-1,4317:-1,4318:-1,4319:-1,4320:-1,4321:-1,4322:-1,4323:-1,4324:-1,4325:-1,4326:-1,4327:-1,4328:-1,4329:-1,4330:-1,4331:-1,4332:-1,4333:-1,4334:-1,4335:-1,4336:-1,4337:-1,4338:-1,4339:-1,4340:-1,4341:-1,4342:-1,4343:-1,4344:-1,4345:-1,4346:-1,4347:-1,4348:-1,4349:-1,4350:-1,4351:-1,4352:-1,4353:-1,4354:-1,4355:-1,4356:-1,4357:-1,4358:-1,4359:-1,4360:-1,4361:-1,4362:-1,4363:-1,4364:-1,4365:-1,4366:-1,4367:-1,4368:-1,4369:-1,4370:-1,4371:-1,4372:-1,4373:-1,4374:-1,4375:-1,4376:-1,4377:-1,4378:-1,4379:-1,4380:-1,4381:-1,4382:-1,4383:-1,4384:-1,4385:-1,4386:-1,4387:-1,4388:-1,4389:-1,4390:-1,4391:-1,4392:-1,4393:-1,4394:-1,4395:-1,4396:-1,4397:-1,4398:-1,4399:-1,4400:-1,4401:-1,4402:-1,4403:-1,4404:-1,4405:-1,4406:-1,4407:-1,4408:-1,4409:-1,4410:-1,4411:-1,4412:-1,4413:-1,4414:-1,4415:-1,4416:-1,4417:-1,4418:-1,4419:-1,4420:-1,4421:-1,4422:-1,4423:-1,4424:-1,4425:-1,4426:-1,4427:-1,4428:-1,4429:-1,4430:-1,4431:-1,4432:-1,4433:-1,4434:-1,4435:-1,4436:-1,4437:-1,4438:-1,4439:-1,4440:-1,4441:-1
results in missing some items in the shop, and following warning:
CODE
[Warning]: npc_parsename: Name ':-1,4257:-1,4258:-1,4259:-1,4260:-1,4261:-1,4262:-1,4263:-1,4264:-1,4265:-1,4266:-1,4267:-1,4268:-1,4269:-1,4270:-1,4271:-1,4272:-1,4273:-1,4274:-1,4275:-1,4276:-1,4277:-1,4278:-1,4279:-1,4280:-1,4281:-1,4282:-1,4283:-1,4284:-1,4285:-1,4286:-1,4287:-1,4288:-1,4289:-1,4290:-1,4291:-1,4292:-1,4293:-1,4294:-1,4295:-1,4296:-1,4297:-1,4298:-1,4299:-1,4300:-1,4301:-1,4302:-1,4303:-1,4304:-1,4305:-1,4306:-1,4307:-1,4308:-1,4309:-1,4310:-1,4311:-1,4312:-1,4313:-1,4314:-1,4315:-1,4316:-1,4317:-1,4318:-1,4319:-1,4320:-1,4321:-1,4322:-1,4323:-1,4324:-1,4325:-1,4326:-1,4327:-1,4328:-1,4329:-1,4330:-1,4331:-1,4332:-1,4333:-1,4334:-1,4335:-1,4336:-1,4337:-1,4338:-1,4339:-1,4340:-1,4341:-1,4342:-1,4343:-1,4344:-1,4345:-1,4346:-1,4347:-1,4348:-1,4349:-1,4350:-1,4351:-1,4352:-1,4353:-1,4354:-1,4355:-1,4356:-1,4357:-1,4358:-1,4359:-1,4360:-1,4361:-1,4362:-1,4363:-1,4364:-1,4365:-1,4366:-1,4367:-1,4368:-1,4369:-1,4370:-1,4371:-1,4372:-1,4373:-1,4374:-1,4375:-1,4376:-1,4377:-1,4378:-1,4379:-1,4380:-1,4381:-1,4382:-1,4383:-1,4384:-1,4385:-1,4386:-1,4387:-1,4388:-1,4389:-1,4390:-1,4391:-1,4392:-1,4393:-1,4394:-1,4395:-1,4396:-1,4397:-1,4398:-1,4399:-1,4400:-1,4401:-1,4402:-1,4403:-1,4404:-1,4405:-1,4406:-1,4407:-1,4408:-1,4409:-1,4410:-1,4411:-1,4412:-1,4413:-1,4414:-1,4415:-1,4416:-1,4417:-1,4418:-1,4419:-1,4420:-1,4421:-1,4422:-1,4423:-1,4424:-1,4425:-1,4426:-1,4427:-1,4428:-1,4429:-1,4430:-1,4431:-1,4432:-1,4433:-1,4434:-1,4435:-1,4436:-1,4437:-1,4438:-1,4439:-1,4440:-1,4441:-1' is too long (len=1483) in file 'npc/kionlnpc/testm_shops.txt', line'1'. Truncating to 24 characters.
Edit#1:
- The Client actually displays only 100 items (Don't know if it's limited by packet size, or client code, but probably the 2.).
- Server-side 255 items fit into a Shop, before that warning occur.
Edit#2:
It's not really related but it occured while testing that stuff:
CODE
[Warning]: [Debug]: showmsg: dynamic buffer used, increase the static buffer siz
e to 2181 or more.npc_parsename: Name ':500000,4172:500000,4173:500000,4174:5000
00,4175:500000,4176:500000,4177:500000,4178:500000,4179:500000,4180:500000,4181:
500000,4182:500000,4183:500000,4184:500000,4185:500000,4186:500000,4187:500000,4
188:500000,4189:500000,4190:500000,4191:500000,4192:500000,4193:500000,4194:5000....
When the dynamic buffer is used, then the debug message appears inside the warning (or other message type) ; even if it's just cosmetic issue, it's still ugly.
This post has been edited by Ai4rei: Dec 7 2007, 08:44 AM