[Instance] Nydhoggs' Nest

Originally posted by [b]emong[/b]
[img]http://a2.sphotos.ak.fbcdn.net/hphotos-ak-ash3/s720x720/552077_178004672322807_100003398264579_269971_420337930_n.jpg[/img]

Here's is the message when the error happened.. How to fix this? I'm noob at scripting. Thank you..

Originally posted by [b]emong[/b]
Help me about this issue

Originally posted by [b]xRaisen[/b]
Same here. I also having that error related

Originally posted by [b]emong[/b]
Good day.. how to solve this? Thanks

Originally posted by [b]xRaisen[/b]
I dont know. it seems some other instances like this link http://rathena.org/board/topic/56456-300-monster-challenge/ is also broken.

Originally posted by [b]emong[/b]
do you have any temporary solution for that error?

Originally posted by [b]xRaisen[/b]
hmmm yes.. revert your server to [b]r15996 [/b]or [b]r15995[/b].

Originally posted by [b]emong[/b]
are you sure with that?

Originally posted by [b]xRaisen[/b]
im sure. thats what i did. im waiting for the fix before ill update it to the latest. silly, but we need that to get it running for now.

Originally posted by [b]emong[/b]
it didn't work for me..

Originally posted by [b]emong[/b]
Bump..

Originally posted by [b]xRaisen[/b]
bump*

it work for me. you might doing it wrong. use [url="http://tortoisesvn.net/downloads.html"][i]TortoiseSVN.[/i][/url]

[spoiler][img]http://i48.tinypic.com/2572czm.jpg[/img][/spoiler]
---------------------------------
[spoiler][img]http://i45.tinypic.com/2z4ckfp.jpg[/img][/spoiler]

Originally posted by [b]emong[/b]
It's really not working for me.

Originally posted by [b]xRaisen[/b]
It works for me. that's all i can help

Originally posted by [b]sizenine[/b]
epoque needs to look at this already..

Originally posted by [b]xRaisen[/b]
im sure he knew it already. hes figuring it out by now i think since hes responsible for changing it to cause the instances to broke.

Originally posted by [b]sizenine[/b]
I don't think so, nobody put the status to confirmed...

i just checked out a fresh copy of the latest svn to test it again (without any mods), confirmed to happen with any instance as long as you run it twice. the second run fails to duplicate:

[IMG]http://i.minus.com/jyj9XKvvdAml9.png[/IMG]

Originally posted by [b]emong[/b]
Yes. I also encountered this error. I'm glad someone confirmed it already Hope they'll notice this.

Originally posted by [b]xRaisen[/b]
Instances are broken. im planning to instance all of my events. but due to this, i cant make that happen.

Originally posted by [b]emong[/b]
Do you have any solution for this xRaisen?

Originally posted by [b]Ind[/b]
this is odd at first i was able to reproduce but then i recompiled and it didn't happen again o.o

Originally posted by [b]sizenine[/b]
What procedures did you take? Try running the instance a third time maybe?

Originally posted by [b]xRaisen[/b]
instances shows duplicate npc's when run it twice as for my case. i wonder when i reverted it back to the old revision [b]r15996 [/b]it runs perfect!

Originally posted by [b]sizenine[/b]
[quote name='xRaisen' timestamp='1337226704' post='9296']
instances shows duplicate npc's when run it twice as for my case. i wonder when i reverted it back to the old revision [b]r15996 [/b]it runs perfect!
[/quote]

actually, reverting to 15996 doesn't solve the problem for me. it seems to not occur as often but it still happens sometimes.

Originally posted by [b]xRaisen[/b]
Ok i'll try it again later. for what i am doing before is I go one step backwards at a time starting around from r16005 until i reach a revision that works which is r15996

and i presumed that the last revision made at that time by epoque broke it, maybe. and i was able to trace it which was the last revision at that time that the instances work.

Originally posted by [b]emong[/b]
I tried also to revert my rev to 15996 but it didn't work. It is still the same..

Originally posted by [b]Ind[/b]
still not able to reproduce, would like more information.

Originally posted by [b]sizenine[/b]
well its definitely there if all of us produced it and even Masao (confirmed) and you produced it before. I'll try again with the current latest checkout and see if it's still there.

Originally posted by [b]Masao[/b]
Well i only confirmed it and moved it to core section because you annoyed the hell out of me with this bug report.

I never tried to reproduce it so i couldn't reproduce it.

Originally posted by [b]xRaisen[/b]
im sorry if its annoying, but i always getting this kind of duplicate npc error. i suspect that the clearing of the npc variable is not clearing it correctly. maybe it does but it skips the npc on db_destroy? im sure the [CODE]instance[instance_id].vars = NULL;[/CODE] is working well for it is issuing the same map when the map is available but the npc cant be duplicated. please correct me if im pointing it wrong. heres my thread [url="http://rathena.org/board/tracker/issue-5678-instances-not-working/"]http://rathena.org/board/tracker/issue-5678-instances-not-working/[/url]

Originally posted by [b]Ind[/b]
[quote name='xRaisen' timestamp='1337922705' post='9545']
im sorry if its annoying, but i always getting this kind of duplicate npc error. i suspect that the clearing of the npc variable is not clearing it correctly. maybe it does but it skips the npc on db_destroy? im sure the [CODE]instance[instance_id].vars = NULL;[/CODE] is working well for it is issuing the same map when the map is available but the npc cant be duplicated. please correct me if im pointing it wrong. heres my thread [url="http://rathena.org/board/tracker/issue-5678-instances-not-working/"]http://rathena.org/board/tracker/issue-5678-instances-not-working/[/url]
[/quote]
not related at all, these vars stored in the instance array are for the \'\ npc variable type which is exclusive to instances and yet not used in any of the instances rathena provides.

Originally posted by [b]xRaisen[/b]
thanks Ind for the light. im kinda desperate to find whats causing it as part of my rathena source exploration.

Originally posted by [b]Pig321[/b]
Solution, modify the map.c

int cleanup_sub(struct block_list *bl, va_list ap)
{
nullpo_ret(bl);
switch(bl->type) {
case BL_PC:
map_quit((struct map_session_data *) bl);
break;
case BL_NPC:
[color=#008000]//npc_unload((struct npc_data *)bl,false);[/color]
[color=#ff0000]npc_unload((struct npc_data *)bl,true);[/color]
break;
case BL_MOB:
unit_free(bl,CLR_OUTSIGHT);
break;
case BL_PET:
//There is no need for this, the pet is removed together with the player. [Skotlex]
break;
case BL_ITEM:
map_clearflooritem(bl->id);
break;
case BL_SKILL:
skill_delunit((struct skill_unit *) bl);
break;
}
return 1;
}

Originally posted by [b]sizenine[/b]
[quote name='Masao' timestamp='1337902206' post='9544']
Well i only confirmed it and moved it to core section because you annoyed the hell out of me with this bug report.I never tried to reproduce it so i couldn't reproduce it.
[/quote]

Oh, way to go Mr. Script Dev. That's sure a smart thing to do!

[quote name='Pig321' timestamp='1338029079' post='9593']
Solution, modify the map.cint cleanup_sub(struct block_list *bl, va_list ap){nullpo_ret(bl);switch(bl->type) {case BL_PC:map_quit((struct map_session_data *) bl);break;case BL_NPC:[color=#008000]//npc_unload((struct npc_data *)bl,false);[/color][color=#ff0000]npc_unload((struct npc_data *)bl,true);[/color]break;case BL_MOB:unit_free(bl,CLR_OUTSIGHT);break;case BL_PET://There is no need for this, the pet is removed together with the player. [Skotlex]break;case BL_ITEM:map_clearflooritem(bl->id);break;case BL_SKILL:skill_delunit((struct skill_unit *) bl);break;}return 1;}
[/quote]

Thanks so much, you're the best.

Originally posted by [b]Ind[/b]
Fixed in [rev=16153] Instance NPCs will now be cleared properly. Super-Special Thanks to Pig321

Originally posted by [b]emong[/b]
Had error when I recompiled my SVN

View attached photo.

Thanks!

Originally posted by [b]xRaisen[/b]
thanks Pig321. a real good find. i cant update it yet. damn this. im heart broken cant think well...........................

Originally posted by [b]Ind[/b]
[quote name='emong' timestamp='1338131481' post='9666']
Had error when I recompiled my SVNView attached photo.Thanks!
[/quote]
try to recompile from scratch with a 'make clean && make sql'