instances not working? - Hercules bug tracker archive

Issue information

Issue ID

#5678

Status

Duplicate

Severity

None

Started

Hercules Elf Bot

Apr 30, 2012 15:31

Last Post

Hercules Elf Bot

Jun 9, 2012 21:18

Confirmation

Yes (4)

No (0)

Hercules Elf Bot - Apr 30, 2012 15:31

Originally posted by [b]xRaisen[/b]
hi,

this code below does not work anymore

[CODE]
set .@party_id,getcharid(1);
getpartymember(.@party_id);
set .@partymembercount,$@partymembercount;
copyarray .@partymembername$[0],$@partymembername$[0],.@partymembercount;

for ( set .@i, 0; .@i < .@partymembercount; set .@i, .@i +1 ){
if (has_instance(.Map$) != "") {
instance_destroy;
}
}
set $@instance, instance_create("Instances", .@party_id);

instance_attachmap(.Map$, $@instance);
instance_attach($@instance);
instance_set_timeout 1800,2,$@instance;
instance_init($@instance);
[/CODE]

it doesn't create a new instance when i come back again. is there a new syntax for this to work properly?

[b]Edit[/b]: And when the time limit reach, the display window still showing like "If you dont enter the dungeon etc..." until such time I re-log. But its just a minor, but right now it doesn't create a new instances. hmmm...

Heres the printscreen
[img]http://i45.tinypic.com/1z568mv.jpg[/img]

and the other npc like on this link is also broken. http://rathena.org/board/topic/56456-300-monster-challenge/

[b]Please give advice, thank you.[/b]

This post has been edited by xRaisen on May 2, 2012 16:17

Hercules Elf Bot - May 2, 2012 16:16

Originally posted by [b]xRaisen[/b]
*bump* Can I bump this? I hope this doesn't break a rule

Hercules Elf Bot - May 9, 2012 0:40

Originally posted by [b]sizenine[/b]
yeah i got new errors from my instance script since i updated to the latest svn revision today...

[quote][Error]: npc_duplicate4instance: the npcname (dup_1_110085505) is already in use while trying to duplicate npc #Instance Destroy in instance 1.
[Error]: npc_duplicate4instance: the npcname (dup_1_110085503) is already in use while trying to duplicate npc Gate#g7 in instance 1.
[Error]: npc_duplicate4instance: the npcname (dup_1_110085502) is already in use while trying to duplicate npc Gate#g6 in instance 1.
[Error]: npc_duplicate4instance: the npcname (dup_1_110085501) is already in use while trying to duplicate npc Gate#g5 in instance 1.
[Error]: npc_duplicate4instance: the npcname (dup_1_110085500) is already in use while trying to duplicate npc Gate#g4 in instance 1.

[Warning]: npc_parse_duplicate : duplicate event dup_1_110085497::OnInstanceInit (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085496::OnTimer10000 (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085496::OnEnable (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085496::OnInstanceInit (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085495::OnTimer3000 (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085495::OnMyMobDead2 (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085493::OnInstanceInit (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085493::OnTimer22000 (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085538::OnInstanceInit (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085538::OnTouch_ (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085542::OnInstanceInit (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085542::OnTouch_ (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085523::OnInstanceInit (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085522::OnInstanceInit (INSTANCING)
[Warning]: npc_parse_duplicate : duplicate event dup_1_110085521::OnInstanceInit (INSTANCING)[/quote]

This post has been edited by sizenine on May 9, 2012 0:43

Hercules Elf Bot - May 9, 2012 6:47

Originally posted by [b]xRaisen[/b]
I hope someone could give a revision syntax to the script to fix the existing instances
.

Hercules Elf Bot - May 9, 2012 12:05

Originally posted by [b]sizenine[/b]
Yeah looks like the change from linkeddb_node to DBMap messed instances up...

Hercules Elf Bot - May 14, 2012 10:59

Originally posted by [b]xRaisen[/b]
yeah. that might be the cause.

Hercules Elf Bot - May 15, 2012 13:06

Originally posted by [b]emong[/b]
Did you find a solution for this?

Hercules Elf Bot - May 15, 2012 19:46

Originally posted by [b]sizenine[/b]
we're pretty much waiting on epoque to look at this, but he might not since somebody changed the status to "needs more info" even though there is enough info to reproduce the bug. it should be confirmed.

This post has been edited by sizenine on May 15, 2012 19:51

Hercules Elf Bot - May 16, 2012 7:20

Originally posted by [b]xRaisen[/b]
That is correct. With all due respect, If more info is needed, try it for yourself.

Hercules Elf Bot - May 16, 2012 19:31

Originally posted by [b]sizenine[/b]
just to help devs out, this issue is the same as this one:

http://rathena.org/board/tracker/issue-5658-instance-nydhoggs-nest/

might want to check that topic out for more info on the bug; to reproduce the error, all you have to do is run an instance script twice.

This post has been edited by sizenine on May 16, 2012 19:33

Hercules Elf Bot - May 17, 2012 1:12

Originally posted by [b]Ind[/b]
I wasn't able to reproduce X__X tried 4 times with nygd instance and twice with endless tower i get no errors at either

Hercules Elf Bot - May 17, 2012 1:13

Originally posted by [b]sizenine[/b]
Did you wait for cooldown or did you just clear the quest db?

Hercules Elf Bot - May 17, 2012 1:26

Originally posted by [b]Ind[/b]
I cleared it

Hercules Elf Bot - May 17, 2012 1:39

Originally posted by [b]sizenine[/b]
maybe try Orc's Memorial/Sealed Shrine with different chars and new party creation..? i know it shouldn't matter but.. the problem definitely exists..

This post has been edited by sizenine on May 17, 2012 1:40

Hercules Elf Bot - May 23, 2012 7:44

Originally posted by [b]Ind[/b]
still not able to reproduce. needs more info

Hercules Elf Bot - May 25, 2012 5:20

Originally posted by [b]xRaisen[/b]
my reply is related posted here [url="http://rathena.org/board/tracker/issue-5658-instance-nydhoggs-nest/page__gopid__9545__st__20#entry9545"]http://rathena.org/board/tracker/issue-5658-instance-nydhoggs-nest/page__gopid__9545__st__20#entry9545[/url]

Hercules Elf Bot - May 26, 2012 6:32

Originally posted by [b]Pig321[/b]
Solution, modify the map.c

int cleanup_sub(struct block_list *bl, va_list ap)
{
nullpo_ret(bl);
switch(bl->type) {
case BL_PC:
map_quit((struct map_session_data *) bl);
break;
case BL_NPC:
[color=#008000]//npc_unload((struct npc_data *)bl,false);[/color]
[color=#ff0000]npc_unload((struct npc_data *)bl,true);[/color]
break;
case BL_MOB:
unit_free(bl,CLR_OUTSIGHT);
break;
case BL_PET:
//There is no need for this, the pet is removed together with the player. [Skotlex]
break;
case BL_ITEM:
map_clearflooritem(bl->id);
break;
case BL_SKILL:
skill_delunit((struct skill_unit *) bl);
break;
}
return 1;
}

This post has been edited by Pig321 on May 26, 2012 10:43

Hercules Elf Bot - May 26, 2012 21:52

Originally posted by [b]Ind[/b]
[bug=5658]