Atk Miscalculation
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#5685
Status
Fixed
Severity
None
Started
Hercules Elf Bot
May 2, 2012 3:51
Last Post
Hercules Elf Bot
May 27, 2012 14:53
Confirmation
Hercules Elf Bot - May 2, 2012 3:51
Originally posted by [b]ForteXX[/b]
This is from something I noticed in [url=http://rathena.org/board/tracker/issue-5660-status-info-position-of-mdef-def-mdef2-def2-not-in-re/]this[/url] report.
kRO
[img]http://i45.tinypic.com/2hnrind.jpg[/img]
rAthena
[img]http://i48.tinypic.com/1pih5w.jpg[/img]
Between the first and second images, with the same stats and levels, (s)he gained 1 atk point between kRO and rAthena. Its only 1 point of Atk, but there could be something not being calculated correctly with this.
This is from something I noticed in [url=http://rathena.org/board/tracker/issue-5660-status-info-position-of-mdef-def-mdef2-def2-not-in-re/]this[/url] report.
kRO
[img]http://i45.tinypic.com/2hnrind.jpg[/img]
rAthena
[img]http://i48.tinypic.com/1pih5w.jpg[/img]
Between the first and second images, with the same stats and levels, (s)he gained 1 atk point between kRO and rAthena. Its only 1 point of Atk, but there could be something not being calculated correctly with this.
This post has been edited by ForteXX on May 2, 2012 3:52
Hercules Elf Bot - May 2, 2012 9:07
Originally posted by [b]Angezerus[/b]
Something similar:
[url="http://rathena.org/board/tracker/issue-5404-atk-calculation/"]http://rathena.org/board/tracker/issue-5404-atk-calculation/[/url]
Something similar:
[url="http://rathena.org/board/tracker/issue-5404-atk-calculation/"]http://rathena.org/board/tracker/issue-5404-atk-calculation/[/url]
Hercules Elf Bot - May 2, 2012 11:47
Originally posted by [b]malufett[/b]
actually the formula is correct but the rounding or flooring of numbers are wrong..btw the atk & matk of rA is not yet fully renewal..
I would suggest to use multiple of 10 for it to have the close result..but somehow there still discrepancy...
and as I see the coding there is something wrong..
[CODE]#ifdef RENEWAL // renewal attack bonus formula
status->batk += (int)((float)status->luk/3 + (float)level/4); //(every 3 luk = + 1ATK) + (every 4 base level = +1 ATK)
#endif[/CODE]
and before that line is the [b]status_base_atk[/b] where it returns the result of
[CODE]dstr = str/10
str += dstr*dstr dex/5 + status->luk/5;[/CODE]
the formula supposed to be
[quote]str + dex/5 + luk/3 + base_level*/4[/quote]
actually the formula is correct but the rounding or flooring of numbers are wrong..btw the atk & matk of rA is not yet fully renewal..
I would suggest to use multiple of 10 for it to have the close result..but somehow there still discrepancy...
and as I see the coding there is something wrong..
[CODE]#ifdef RENEWAL // renewal attack bonus formula
status->batk += (int)((float)status->luk/3 + (float)level/4); //(every 3 luk = + 1ATK) + (every 4 base level = +1 ATK)
#endif[/CODE]
and before that line is the [b]status_base_atk[/b] where it returns the result of
[CODE]dstr = str/10
str += dstr*dstr dex/5 + status->luk/5;[/CODE]
the formula supposed to be
[quote]str + dex/5 + luk/3 + base_level*/4[/quote]
This post has been edited by malufett on May 2, 2012 13:31
Hercules Elf Bot - May 8, 2012 9:08
Originally posted by [b]Kenpachi[/b]
Fixed in [rev=16084].
Fixed in [rev=16084].