Birthdate not working as intended

Originally posted by [b]Kaito_Kid[/b]
Of course it should not be empty. As for as I know by default the birthdate is set to 0000-00-00(Unless you are using the Flux RE Control Panel) which is you should enter on the field "00000000"

Originally posted by [b]EvilPuncker[/b]
I know, well, I know exactly how the birthdate system work, I'm here to report that seems like rA isn't checking if user left the input box empty when deleting a character (note that it is behaving like that with either 0000-00-00 or any other date set) and it allows them to delete without entering any number at all, got it?

Originally posted by [b]Mysterious[/b]
Sorry, can't reproduce. It works fine for me. I've entered 'Blank', just hitted 'Ok' and I got denied. I checked my login and I set my birthdate at 0000-00-00, inputted that (00000000), and my char got deleted. Also, the new FluxCP Calcium worked on, he added the new birthdate system.

Originally posted by [b]EvilPuncker[/b]
ffs... don't enter anything, let it empty and try... ofc if you enter anything it will deny the deletion...

Originally posted by [b]Mysterious[/b]
Don't enter anything? Let it empty and try? Isnt that the same as leaving it empty?

Originally posted by [b]Mysterious[/b]
[quote name='EvilPuncker' timestamp='1335969569' post='8876']
Actually you can delete any of your character just by letting the input field empty when client ask for your birthdate, seems like it doesn't check if you left it empty o.O
[/quote]
What you're saying here is, if you LEAVE the field BLANK and just hit OK you get the issue? No, I tried and if I left it blank I got denied. 0000-00-00 system doesnt work either. To delete a character, you need to do 00000000.

Originally posted by [b]EvilPuncker[/b]
I still got the issue, would be nice if some dev check it out

Originally posted by [b]Ind[/b]
i'm not able to reproduce the problem oo is this exclusive to a certain client?oO

Originally posted by [b]Judas[/b]
yeah I get the same on 2012-04-10, but I know before on other clients, you had to type in the 00000000 to delete it

Nevermind, I think its something src related, I knew it worked on 2011-11-02, but when I try it now, you can just enter nothing to delete the char. Tested on 2011-04-05 as well, and same problem

Originally posted by [b]EvilPuncker[/b]
Indeed it is src related, I hope someone look into this soon since it makes the deletion system pretty useless, even for hacked accounts

Originally posted by [b]Ind[/b]
this is a client bug -- some client versions send 000000 when nothing is pressed, but the server is not able to say if the client was empty. as long as your account birthdate isn't 00-00-00 (default it to something else?) it won't bother.

Originally posted by [b]EvilPuncker[/b]
[color=#282828][font=helvetica, arial, sans-serif][size=3](note that it is behaving like that with either 0000-00-00 or [u]any other date set[/u])[/size][/font][/color]

Originally posted by [b]Ind[/b]
i wasn't able to reproduce it with any other than 00-00-00 oO

Originally posted by [b]EvilPuncker[/b]
my birthdate is set to 2012-05-02 and i've just created an new character and deleted it without entering anything

then
[url="http://localhost/us_phpmyadmin/url.php?url=http%3A%2F%2Fdev.mysql.com%2Fdoc%2Frefman%2F5.5%2Fen%2Fset.html&token=5d5d2f2c38fc41f15d5b7c96fc006ebc"][color=#990099][b]SET[/b][/color][/url][color=#444444][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)] [/background][/font][/color][color=#008000][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)]`birthdate`[/background][/font][/color][color=#444444][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)] [/background][/font][/color][color=fuchsia][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)]=[/background][/font][/color][color=#444444][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)] [/background][/font][/color][color=#008000][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)]'0000-00-00'[/background][/font][/color]

now created another character and tried the same, then it got also deleted without entering anything

Originally posted by [b]MarkZD[/b]
[quote name='EvilPuncker' timestamp='1338515987' post='9889']
my birthdate is set to 2012-05-02 and i've just created an new character and deleted it without entering anythingthen[url="http://localhost/us_phpmyadmin/url.php?url=http%3A%2F%2Fdev.mysql.com%2Fdoc%2Frefman%2F5.5%2Fen%2Fset.html&token=5d5d2f2c38fc41f15d5b7c96fc006ebc"][color=#990099][b]SET[/b][/color][/url][color=#444444][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)] [/background][/font][/color][color=#008000][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)]`birthdate`[/background][/font][/color][color=#444444][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)] [/background][/font][/color][color=fuchsia][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)]=[/background][/font][/color][color=#444444][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)] [/background][/font][/color][color=#008000][font=Verdan, Arial, Tahoma][background=rgb(229, 229, 229)]'0000-00-00'[/background][/font][/color]now created another character and tried the same, then it got also deleted without entering anything
[/quote]

We need to check the code that delete chars, where is it?

------Edit------

char.c
[CODE]
if( strcmp(sd->birthdate+2, birthdate) ) // +2 to cut off the century
{// birth date is wrong
char_delete2_accept_ack(fd, char_id, 5);
return;
}
[/CODE]
It's beeing checked in this part, maybe the server is not reaching this part, what's causing the trouble, but I didn't find any piece that bypass some kind of check.

Originally posted by [b]Brynner[/b]
so until now there is no possible fix for this issue?

Originally posted by [b]MarkZD[/b]
Any chance the client knows the birthdate so when blank field is send, it'll replace with it?