Hercules Elf Bot - May 9, 2012 10:02
Originally posted by [b]frenzmu06[/b]
i recently put a map callled "Caspen" in my server and noticed something
i was allready done with all things in adding a map and then went online to test it, when i typed @warp caspen, map server says cant find map index so i thought i just had problem with compiling the map cache and got frustrated compiling it over and over again until i turned down adding it on the server.
after 2 days while im playing i noticed something when i warped to prontera and mistakenly put it like this "@warp prOntera" w/ a big O on it and map server says cant find from index, so i retyped @warp prontera again and there i was warped so something came up on my mind "Oh maybe thats the prob".. so i tested it and it worked, case sensitivity was my only problem regarding the issue. i set up all names of it as "Caspen" with big "C" on map_index,maps.cof,gnd,rsw,gat etc w/out knowing about the case sensitivity issue.
samples using @warp:
Prontera will not work
[indent=1]prontera works[/indent]
[indent=1]prOntera will not[/indent]
[indent=1]pronterA will not[/indent]
[indent=1]izlude works[/indent]
[indent=1]izluDE will not[/indent]
"@go" is not case sensitive
is this a bug or the case sensitivity was intended
Hercules Elf Bot - May 9, 2012 10:11
Originally posted by [b]malufett[/b]
as the code says it was working as intended..
for @go it uses "[b]TOLOWER[/b]" in which it turns lower case to ignore cases...
while @warp immediate checking and turns to mapid...
but let see what will the other devs decision for this...^^
Hercules Elf Bot - May 9, 2012 12:42
Originally posted by [b]Aleos[/b]
All Gravity maps are lower case. So using the tolower function would support this just fine. That means every server that has a custom map with a capital letter in it needs to recompile their map cache to include the map name as lower case to avoid issues using @warp or NPC warp commands.
Hercules Elf Bot - May 10, 2012 0:42
Originally posted by [b]Mysterious[/b]
Exactly as mentioned; all Ragnarok Maps are all lowered case if you haven't noticed =/
Hercules Elf Bot - May 10, 2012 5:17
Originally posted by [b]Brian[/b]
I also think adding TOLOWER in @warp is a good idea.
Hercules Elf Bot - Aug 13, 2012 4:33
Originally posted by [b]Euphy[/b]
Necro-bump, Euphy also supports this.
Hercules Elf Bot - Oct 16, 2012 20:10
Originally posted by [b]MarkZD[/b]
I think it's not necessary, isn't it easiest just typing without pressing shift or caps lock?
Just put maps all lowercase.
[quote name='Brian' timestamp='1336627025' post='9124']
I also think adding TOLOWER in @warp is a good idea.
[/quote]
It's not a good idea and would not solve the problem, as in this way you could never reach a map wich is not entirely written in lowercase, unless map's names are saved in lowercase in variables, before.
This post has been edited by
MarkZD
on Oct 16, 2012 20:12
Hercules Elf Bot - Oct 17, 2012 0:15
Originally posted by [b]Lighta[/b]
Think lowercase by default is the best option since since gravity have this kind of nomenclature.
We may add a -f (force) option to disable tolower if server owner have some map wich ain't all lowercase.
That how I,d do it
Hercules Elf Bot - Nov 14, 2012 20:03
Originally posted by [b]mkbu95[/b]
I agree that we do this:
- Check if the map exists the way it was written;
- If not, TOLOWER and check again;
- If not, then display the map was not found.
That's my opinion, though.
Hercules Elf Bot - Nov 14, 2012 21:00
Originally posted by [b]Cookie[/b]
I say yes we should. I agree with mkbu95 on how we should handle it, and that way the necessary checks are initiated and nothing slips through the cracks.
Hercules Elf Bot - Nov 15, 2012 10:05
Originally posted by [b]Brian[/b]
How about when loading maps, convert all names TOLOWER and in memory store them in lowercase.
Then all functions that look up map names just convert TOLOWER, then lookup map.
Hercules Elf Bot - Nov 16, 2012 13:34
Originally posted by [b]MarkZD[/b]
[quote name='Brian' timestamp='1352973933' post='15698']
How about when loading maps, convert all names TOLOWER and in memory store them in lowercase. Then all functions that look up map names just convert TOLOWER, then lookup map.
[/quote]
You said the same I did some posts above.
[quote name='MarkZD' timestamp='1350418201' post='15015']t's not a good idea and would not solve the problem, as in this way you could never reach a map wich is not entirely written in lowercase, unless [u][b]map's names are saved in lowercase in variables[/b][/u], before.
[/quote]
I think we should open a topic about it, as this means we would remove a feature from the source, unless we add an option as Lighta said, but I think it would be better in conf instead of when compiling, so it's more flexible.
This post has been edited by
MarkZD
on Nov 16, 2012 21:04
Hercules Elf Bot - Nov 16, 2012 13:46
Originally posted by [b]EvilPuncker[/b]
[quote name='Brian' timestamp='1352973933' post='15698']
How about when loading maps, convert all names TOLOWER and in memory store them in lowercase. Then all functions that look up map names just convert TOLOWER, then lookup map.
[/quote]
I agree with this! lets implement/fix that!
Hercules Elf Bot - Nov 24, 2012 3:13
Originally posted by [b]mkbu95[/b]
Fixed in [rev=16956].