AUTOSPELLonSKILL (self skill) not working
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#5725
Status
Fixed
Severity
None
Started
Hercules Elf Bot
May 10, 2012 4:09
Last Post
Hercules Elf Bot
Jun 21, 2012 12:29
Confirmation
Hercules Elf Bot - May 10, 2012 4:09
Originally posted by [b]kyeme[/b]
Using +9 or +10 Glorious Fist once using Vigor Explosion (MO_EXPLOSIONSPIRITS) there should be follow up auto cast of Zen (CH_SOULCOLLECT) however its not working.
Using +9 or +10 Glorious Fist once using Vigor Explosion (MO_EXPLOSIONSPIRITS) there should be follow up auto cast of Zen (CH_SOULCOLLECT) however its not working.
This post has been edited by kyeme on May 10, 2012 4:21
Hercules Elf Bot - May 23, 2012 19:41
Originally posted by [b]VyL0w[/b]
yeah hopefully someone can fix this! ^^
yeah hopefully someone can fix this! ^^
Hercules Elf Bot - Jun 9, 2012 18:02
Originally posted by [b]Kenpachi[/b]
bautospellonskill seems to be broken.
I tested it with another skill (one that was in my skill list) that was in my skill list and with higher chances (even though it's already 100%).
Moving this to Core section.
bautospellonskill seems to be broken.
I tested it with another skill (one that was in my skill list) that was in my skill list and with higher chances (even though it's already 100%).
Moving this to Core section.
Hercules Elf Bot - Jun 13, 2012 7:14
Originally posted by [b]Wildcard[/b]
Unsurprisingly, since the the only call to skill_onskillusage now lives inside skill_attack(which is only called for offensive skills), and furthermore only occurs if any damage is actually dealt (compare [url="http://rathena.org/board/tracker/issue-5556-elemental-sword-skill-chain-bug/"]this bug[/url] and [url="http://sourceforge.net/apps/trac/rathena/changeset/15846"]r15846[/url]). Since a skill can take one of a million paths in *Athena depending on its type(offensive/support/ground), reason for cast (player, script) and time of the day, will need to carefully vet where to re-instate skill_onskillusage without breaking elemental sword again.
[s]I would very much like to see the leaked item scripts for these two items (elemental sword and glorious fist) to see if they indeed even use the same script, so if anyone could post them I would be much obliged.[/s]
They do. Interesting is the "Target" for CH_SOULCOLLECT
[CODE]
SetSkillAutoSpell MO_EXPLOSIONSPIRITS 1000 CH_SOULCOLLECT 1 Target
[/CODE]
[CODE]
SetSkillAutoSpell MG_COLDBOLT 1000 MG_FIREBOLT 3 Target
SetSkillAutoSpell MG_FIREBOLT 1000 MG_LIGHTNINGBOLT 3 Target
SetSkillAutoSpell MG_LIGHTNINGBOLT 1000 WZ_EARTHSPIKE 3 Target
[/CODE]
Unsurprisingly, since the the only call to skill_onskillusage now lives inside skill_attack(which is only called for offensive skills), and furthermore only occurs if any damage is actually dealt (compare [url="http://rathena.org/board/tracker/issue-5556-elemental-sword-skill-chain-bug/"]this bug[/url] and [url="http://sourceforge.net/apps/trac/rathena/changeset/15846"]r15846[/url]). Since a skill can take one of a million paths in *Athena depending on its type(offensive/support/ground), reason for cast (player, script) and time of the day, will need to carefully vet where to re-instate skill_onskillusage without breaking elemental sword again.
[s]I would very much like to see the leaked item scripts for these two items (elemental sword and glorious fist) to see if they indeed even use the same script, so if anyone could post them I would be much obliged.[/s]
They do. Interesting is the "Target" for CH_SOULCOLLECT
[CODE]
SetSkillAutoSpell MO_EXPLOSIONSPIRITS 1000 CH_SOULCOLLECT 1 Target
[/CODE]
[CODE]
SetSkillAutoSpell MG_COLDBOLT 1000 MG_FIREBOLT 3 Target
SetSkillAutoSpell MG_FIREBOLT 1000 MG_LIGHTNINGBOLT 3 Target
SetSkillAutoSpell MG_LIGHTNINGBOLT 1000 WZ_EARTHSPIKE 3 Target
[/CODE]
This post has been edited by Wildcard on Jun 13, 2012 7:23
Hercules Elf Bot - Jun 13, 2012 15:16
Originally posted by [b]malufett[/b]
Fixed @ [rev='16286']
Target means Self, Monster, Characters and other selectable object..
at Ind's fix in [color=#282828][font=helvetica, arial, sans-serif][size=3] [/size][/font][/color][url="http://sourceforge.net/apps/trac/rathena/changeset/15846"]r15846[/url] he accidentally removed the auto spell in the non damage skills where it doesn't have relationship with the said bug....
Fixed @ [rev='16286']
Target means Self, Monster, Characters and other selectable object..
at Ind's fix in [color=#282828][font=helvetica, arial, sans-serif][size=3] [/size][/font][/color][url="http://sourceforge.net/apps/trac/rathena/changeset/15846"]r15846[/url] he accidentally removed the auto spell in the non damage skills where it doesn't have relationship with the said bug....
Hercules Elf Bot - Jun 13, 2012 17:08
Originally posted by [b]kyeme[/b]
