Renewal Casting.

Originally posted by [b]Ind[/b]
as far as i know its working as intended, you'd need to provide information and/or source on this.

Originally posted by [b]frenzmu06[/b]
what do you mean? like renewal casting prevents berze cards on official servers or rathena prevents this and should be fixed?

Originally posted by [b]malufett[/b]
he means that the renewal casting is not yet fully implemented to support bonuses from items...

Originally posted by [b]mnjfx[/b]
other way to say it was what malufett said. so there is no other way to make them work right now?

Originally posted by [b]malufett[/b]
and addition to that.. Ind maybe also means that we need still more information about the official behavior....Ind correct me if the words I saying is correct...XD

Originally posted by [b]MarkZD[/b]
[quote name='malufett' timestamp='1337606335' post='9403']
he means that the renewal casting is not yet fully implemented to support bonuses from items...
[/quote]

No, he's telling it's working the way it should according to actual sources he has and not that it's not implemented.

And if you think it's wrong you need to prove providing any trustable source, so it'll be changed.

Originally posted by [b]malufett[/b]
[quote]No, he's telling it's working the way it should according to actual sources he has and not that it's not implemented.[/quote]
Really? why is that I can't see any implementation regarding castrate/fixed cast rate in the src???

Originally posted by [b]MarkZD[/b]
[quote name='malufett' timestamp='1337617246' post='9416']
[quote]No, he's telling it's working the way it should according to actual sources he has and not that it's not implemented.[/quote]Really? why is that I can't see any implementation regarding castrate/fixed cast rate in the src???
[/quote]

Are you telling about this?
Skill.c
[CODE]
#ifdef RENEWAL_CAST
int fixed = skill_get_fixed_cast(skill_id, skill_lv);
if( !fixed ) {
fixed = skill_get_cast(skill_id, skill_lv);
fixed = ( fixed > 1 ? ( fixed * 20 / 100 ) : 0 );
}
#endif
[/CODE]

Originally posted by [b]ForteXX[/b]
Going by iROwiki, it appears anything that affected cast rate in preRE only affects Variable cast time in RE (I looked at the 4 items listed, and all except Fist say variable. Fist only says Removes the cast time for [Guillotine Fist].)

Does bCastRate only affect Variable cast time? If so, then this is working correctly (unless thats broken)

Originally posted by [b]malufett[/b]
[quote name='MarkZD' timestamp='1337622997' post='9422']
[quote name='malufett' timestamp='1337617246' post='9416'][quote]No, he's telling it's working the way it should according to actual sources he has and not that it's not implemented.[/quote]Really? why is that I can't see any implementation regarding castrate/fixed cast rate in the src???[/quote]Are you telling about this?Skill.c[CODE]#ifdef RENEWAL_CASTint fixed = skill_get_fixed_cast(skill_id, skill_lv);if( !fixed ) { fixed = skill_get_cast(skill_id, skill_lv); fixed = ( fixed > 1 ? ( fixed * 20 / 100 ) : 0 );}#endif[/CODE]
[/quote]
hehehe..not that we are talking about the bonuses from items....

[quote]Does bCastRate only affect Variable cast time? [/quote]
bCastRate only affects the overall cast time....


[CODE]
// calculate cast time reduced by item/card bonuses
if( !(skill_get_castnodex(skill_id, skill_lv)&4) && sd )
{
int i;
if( sd->castrate != 100 )
time = time * sd->castrate / 100;
for( i = 0; i < ARRAYLENGTH(sd->skillcast) && sd->skillcast[i].id; i++ )
{
if( sd->skillcast[i].id == skill_id )
{
time+= time * sd->skillcast[i].val / 100;
break;
}
}
}[/CODE]

Originally posted by [b]ForteXX[/b]
Then yes, this is bugged, going by iROwiki's effect, as it says they lower only Variable Cast Time (other than fist).

Originally posted by [b]MarkZD[/b]
[quote name='malufett' timestamp='1337662100' post='9441']
hehehe..not that we are talking about the bonuses from items.... [/quote]

The problem is about Renewal Casting preventing bonuses from working, so I think RENEWAL CASTING is the problem also not totally the bonuses cause they work if re is not defined(or used to work).

It's because of the fixed cast that is added to skill in some piece like that I showed.
bCastrate doesn't reduces that piece as bFixedCastrate don't.

RE Casting maybe is beeing added after item bonus was applied or bonuses just don't change this part.
And it doesn't change what Ind said it's working the way it should, it's what "working as intended" means.

[quote name='ForteXX' timestamp='1337689411' post='9453']
Then yes, this is bugged, going by iROwiki's effect, as it says they lower only Variable Cast Time (other than fist).
[/quote]

I don't know about that, but I think the topic author is just saying is like: his cast and fixed are not beeing completely removed by -100% cast and fixed cast get from item bonuses.

Originally posted by [b]ForteXX[/b]
[url=http://db.irowiki.org/db/item-info/4145/]Beelzebub Card[/url]
[code]Reduces the variable cast time of skills by 30%.[/code]

[url=http://db.irowiki.org/db/item-info/5564/]Crown of Deceit[/url]
[code]
[*]Reduces the variable cast time of skills by 10%.
[*]If upgraded to +7 or higher:
[*]Def +2
[*]MAtk +5%
[*]Reduces the variable cast time of skills by additional 5%.
[*]If upgraded to +9 or higher:
[*]MDef +5
[*]Additional MAtk +5%
[*]Reduces the variable cast time of skills by additional 5%.
[*]Reduces the skill usage delay by 5%.[/code]
[url=http://db.irowiki.org/db/item-info/4229/]Clock Tower Manager Card[/url]
[code]Reduces the variable cast time of skills by 5%.[/code]

and the only one that would remove fixed cast:
[url=http://db.irowiki.org/db/item-info/1827/]Glorious Fist[/url]
[code]+9 upgrade bonus:
[*]Removes the cast time for [Guillotine Fist].
[*]Automaticly casts [Zen] Lv 1 when [Fury] is used.
[/code]

Originally posted by [b]MarkZD[/b]
From what is seeing cast time is not beeing changed by the ways the author thinked it should, it's the why Ind asked for sources, because if the author thinks the whole cast should be removed he'd provide his sources, but as fixed part who is preventing the cast from beeing null and according to sources it's the right, so it's working as intended, at least about the author topic.

As ForteXX mentioned, fixed part can't be removed,(just to GF) so it just proved it's working as intended, unless any source provided negates it, saying any item will influence fixed part, right?

Originally posted by [b]mnjfx[/b]
[quote name='ForteXX' timestamp='1337703631' post='9460']
[url="http://db.irowiki.org/db/item-info/4145/"]Beelzebub Card[/url][code]Reduces the variable cast time of skills by 30%.[/code][url="http://db.irowiki.org/db/item-info/5564/"]Crown of Deceit[/url][code][*]Reduces the variable cast time of skills by 10%.[*]If upgraded to +7 or higher:[*]Def +2[*]MAtk +5%[*]Reduces the variable cast time of skills by additional 5%.[*]If upgraded to +9 or higher:[*]MDef +5[*]Additional MAtk +5%[*]Reduces the variable cast time of skills by additional 5%.[*]Reduces the skill usage delay by 5%.[/code][url="http://db.irowiki.org/db/item-info/4229/"]Clock Tower Manager Card[/url][code]Reduces the variable cast time of skills by 5%.[/code]and the only one that would remove fixed cast:[url="http://db.irowiki.org/db/item-info/1827/"]Glorious Fist[/url][code]+9 upgrade bonus:[*]Removes the cast time for [Guillotine Fist].[*]Automaticly casts [Zen] Lv 1 when [Fury] is used.[/code]
[/quote]

yes I know all of that, and I did not do anything to the src, btw i am using r16090, but anyway +9 Glorious fist does not remove the cast time for Guillotine Fist. and all those w/ reduce cast times completely has no effect.

Originally posted by [b]MarkZD[/b]
bonus bCastrate is working fine, tested Beelzebub and Kathryn Keyron Card with 1 dex, 1 int, just fixed cast time is not beeing reduced, which I said previously that you think it should be removed but according to current sources the fixed part is not removed unless you provide any official source that contest it.

Glorious Fist also is removing cast but fixed part, it's reduced to something like 1 seg or less.
Maybe GF is wrong, someone has to check about fixed cast time to see if it's reduced by something and check if GF removes it too.
But as GF says: "removes the Cast Time", so I think variable and fixed are included, no just variable.

The talked GF script part:

[quote]bonus2 bAddRace,RC_DemiHuman,95; bonus2 bIgnoreDefRate,RC_DemiHuman,20; bonus bUnbreakableWeapon,0;

if(getrefine() > 5)
{ bonus2 bAddRace,RC_DemiHuman,(getrefine()-4)*(getrefine()-4); bonus2 bIgnoreDefRate,RC_DemiHuman,5; }

[b]if(getrefine() > 8) { bonus2 bCastrate,271,-100;[/b] bonus4 bautospellonskill,\"MO_EXPLOSIONSPIRITS\",\"CH_SOULCOLLECT\",1,1000; }[/quote]

But if it needs to be changed to decrease bFixedCastrate, it's a subject to an other report.

There're only 2 items if I'm not wrong which really change fixed cast.
Puente Robe [1]
Rafini Staff [0]