Issue information

Issue ID
#5828
Status
Fixed
Severity
None
Started
Hercules Elf Bot
May 26, 2012 15:31
Last Post
Hercules Elf Bot
Jun 9, 2012 21:20
Confirmation
Yes (0)
No (1)

Hercules Elf Bot - May 26, 2012 15:31

Originally posted by [b]jTynne[/b]
I'm not sure if this is a bug or not, however, the current login configuration is a bit.. janked. It only allows ONE user group online or it allows everyone (-1) online.

Is this working correctly? The old configuration allowed GM Level X or higher online.. the same should be true for the current.. =/

Please look into this!

Hercules Elf Bot - May 26, 2012 18:36

Originally posted by [b]Ind[/b]
indeed o-o [code]

if( login_config.group_id_to_connect >= 0 && sd->group_id != login_config.group_id_to_connect )
[/code]

Hercules Elf Bot - May 26, 2012 18:56

Originally posted by [b]jTynne[/b]
The old configuration allowed for GM levels above the one defined in the login config file to connect. Why was that removed with the introduction of groups? o.O Is it possible to allow multiple groups? Or groups that inherit the usergroup's rights that are defined to be able to log on?

e.g. I'm an administrator (group 99), and none of my staff members (group ID's 10, 11, and 12) can log on. =X It used to be that you could simply set it so that anything above a certain GM level could sign on. x_x;


Edit: Lol, I srsly just QQ faced when I realized you said it was confirmed. I thought you said, "NO", lol. Someone's playing games with my heart and I'm finna fight.

This post has been edited by jTynne on May 26, 2012 18:57

Hercules Elf Bot - May 26, 2012 23:25

Originally posted by [b]jTynne[/b]
[color=#000088]if[/color][color=#666600]([/color][color=#000000] login_config[/color][color=#666600].[/color][color=#000000]group_id_to_connect [/color][color=#666600]>=[/color][color=#000000] [/color][color=#006666]0[/color][color=#000000] [/color][color=#666600]&&[/color][color=#000000] sd[/color][color=#666600]->[/color][color=#000000]group_id [/color][color=#ff0000]<[/color][color=#000000] login_config[/color][color=#666600].[/color][color=#000000]group_id_to_connect [/color][color=#666600])[/color]
[color=#666600]I'm guessing the red < is all that's required to fix this. Going to test it now, oh look at me doing dev shit. #proud[/color]

This post has been edited by jTynne on May 26, 2012 23:44

Hercules Elf Bot - May 26, 2012 23:48

Originally posted by [b]jTynne[/b]
Si, change that line in: [svn=trunk/src/login/login.c]

ThankyouInd<3

This post has been edited by Brian on May 26, 2012 23:59

Hercules Elf Bot - May 31, 2012 18:51

Originally posted by [b]Ind[/b]
since they provide different functionality I've re-added the old behavior back as a new config.
Fixed in [rev=16185]