Party Exp Share on MVP monster.
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#5862
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
May 29, 2012 18:56
Last Post
Hercules Elf Bot
Jun 23, 2012 23:22
Confirmation
Hercules Elf Bot - May 29, 2012 18:56
Originally posted by [b]Vali[/b]
Hi,
I tested it with the Eddga MVP in RE mode in a x5 server. Also I have activated the party_even_share_bonus to 10 extra for party member.
If I kill the MVP myself I get 990000 of bexp and 742500 of jexp.
===============================================================
After that I did a party with another GM with the exp mode "Each Take":
I got 147350 and 110513
He got 1090149 and 817611
Total 1237499 and 928124
Taking in consideration that the MVP exp in RE is must not be affected by the exp penalty in total we are receiving:
1237499 - (990000 + 10%990000) = 148499 more base experience than expected.
928124 - (742500 + 10%742500) = 111374 more job experience than expected.
[attachment=2073:screenROcommerce027.jpg][attachment=2074:screenROcommerce002.jpg]
===============================================================
Now with the exp mode in "Even Share"
I got 68062 and 51046
He got 238218 and 178663
Total 306280 and 229709
Taking in consideration that the MVP exp in RE is must not be affected by the exp penalty in total we are receiving:
306280 - (990000 + 10%990000) = -782720 less base experience than expected.
229709 - (742500 + 10%742500) = -587041 less job experience than expected.
[attachment=2075:screenROcommerce028.jpg][attachment=2076:screenROcommerce003.jpg]
===============================================================
I tested it only with the MVP Eddga, not with other MVP or normal monsters.
Vali~
Hi,
I tested it with the Eddga MVP in RE mode in a x5 server. Also I have activated the party_even_share_bonus to 10 extra for party member.
If I kill the MVP myself I get 990000 of bexp and 742500 of jexp.
===============================================================
After that I did a party with another GM with the exp mode "Each Take":
I got 147350 and 110513
He got 1090149 and 817611
Total 1237499 and 928124
Taking in consideration that the MVP exp in RE is must not be affected by the exp penalty in total we are receiving:
1237499 - (990000 + 10%990000) = 148499 more base experience than expected.
928124 - (742500 + 10%742500) = 111374 more job experience than expected.
[attachment=2073:screenROcommerce027.jpg][attachment=2074:screenROcommerce002.jpg]
===============================================================
Now with the exp mode in "Even Share"
I got 68062 and 51046
He got 238218 and 178663
Total 306280 and 229709
Taking in consideration that the MVP exp in RE is must not be affected by the exp penalty in total we are receiving:
306280 - (990000 + 10%990000) = -782720 less base experience than expected.
229709 - (742500 + 10%742500) = -587041 less job experience than expected.
[attachment=2075:screenROcommerce028.jpg][attachment=2076:screenROcommerce003.jpg]
===============================================================
I tested it only with the MVP Eddga, not with other MVP or normal monsters.
Vali~
Hercules Elf Bot - Jun 1, 2012 20:38
Originally posted by [b]Vali[/b]
Anyone can confirm this?
Anyone can confirm this?
Hercules Elf Bot - Jun 2, 2012 6:32
Originally posted by [b]Vali[/b]
What type of info you need Ind? I will try to explain it better or got it.
What type of info you need Ind? I will try to explain it better or got it.
Hercules Elf Bot - Jun 2, 2012 12:50
Originally posted by [b]Ind[/b]
I flagged as needs more info because you asked for it to be confirmed also I'm not gonna be the one to fix this -- I'm horrible with math.
I flagged as needs more info because you asked for it to be confirmed also I'm not gonna be the one to fix this -- I'm horrible with math.
Hercules Elf Bot - Jun 2, 2012 13:03
Originally posted by [b]Vali[/b]
Ok. :3
Ok. :3
Hercules Elf Bot - Jun 21, 2012 10:37
Originally posted by [b]Vali[/b]
Any dev can look into this? the MVPs are not giving the correct exp if you are in party. >_<
Any dev can look into this? the MVPs are not giving the correct exp if you are in party. >_<
Hercules Elf Bot - Jun 21, 2012 10:45
Originally posted by [b]GreenBox[/b]
probably must check if src is a mob and if it a boss on party_exp_share before party_renewal_exp_mod
need to confirm that but i'm out of time ;/
probably must check if src is a mob and if it a boss on party_exp_share before party_renewal_exp_mod
need to confirm that but i'm out of time ;/
Hercules Elf Bot - Jun 21, 2012 13:34
Originally posted by [b]Ikari Gendo[/b]
same on our server, from my info you get the exp lvl penalty in a share party
testet on eddga with high lvl char >30lvl more and i got only 10% of the monsterexp, but normal MVP reward
same on our server, from my info you get the exp lvl penalty in a share party
testet on eddga with high lvl char >30lvl more and i got only 10% of the monsterexp, but normal MVP reward
Hercules Elf Bot - Jun 21, 2012 23:37
Originally posted by [b]jTynne[/b]
Same on my server (are you playing CasualRO as Vali? Because there's someone with your name!). Hit yes to confirm.
Same on my server (are you playing CasualRO as Vali? Because there's someone with your name!). Hit yes to confirm.
Hercules Elf Bot - Jun 22, 2012 7:26
Originally posted by [b]Vali[/b]
No, I have my own server heh.
No, I have my own server heh.
Hercules Elf Bot - Jun 22, 2012 9:22
Originally posted by [b]Ind[/b]
question, RENEWAL_EXP is in use here?
question, RENEWAL_EXP is in use here?
Hercules Elf Bot - Jun 22, 2012 9:46
Originally posted by [b]Vali[/b]
Yes, the only thing is not in use is RENEWAL_DROP.
Yes, the only thing is not in use is RENEWAL_DROP.
Hercules Elf Bot - Jun 22, 2012 9:47
Originally posted by [b]ozzey[/b]
i think the problem is on the PARTY .
not only exp , but quest, and Alchemy skill is trouble with it.
CMIIW
i think the problem is on the PARTY .
not only exp , but quest, and Alchemy skill is trouble with it.
CMIIW
Hercules Elf Bot - Jun 22, 2012 10:32
Originally posted by [b]Ind[/b]
ah o-o math skills shouldn't be required then, i'll propose a test change, if any of you feel comfortable testing please do so and let me know about the results.
in party.c::party_exp_share()
find
[code]
party_renewal_exp_mod(&b_exp,&j_exp,sd[i]->status.base_level,src_lvl);
[/code]
and change to
[code]
if( !(src && src->type == BL_MOB && ((TBL_MOB*)src)->db->mexp) )
party_renewal_exp_mod(&b_exp,&j_exp,sd[i]->status.base_level,src_lvl);
[/code]
ah o-o math skills shouldn't be required then, i'll propose a test change, if any of you feel comfortable testing please do so and let me know about the results.
in party.c::party_exp_share()
find
[code]
party_renewal_exp_mod(&b_exp,&j_exp,sd[i]->status.base_level,src_lvl);
[/code]
and change to
[code]
if( !(src && src->type == BL_MOB && ((TBL_MOB*)src)->db->mexp) )
party_renewal_exp_mod(&b_exp,&j_exp,sd[i]->status.base_level,src_lvl);
[/code]
Hercules Elf Bot - Jun 22, 2012 11:15
Originally posted by [b]Vali[/b]
Tomorrow is my maintenance, I will do the change.
Tomorrow is my maintenance, I will do the change.
Hercules Elf Bot - Jun 23, 2012 23:22
Originally posted by [b]Ind[/b]
Fixed in [rev=16332]
Fixed in [rev=16332]