Issue information

Issue ID
#5883
Status
Fixed
Severity
None
Started
Hercules Elf Bot
May 31, 2012 19:39
Last Post
Hercules Elf Bot
Jun 9, 2012 21:12
Confirmation
Yes (1)
No (0)

Hercules Elf Bot - May 31, 2012 19:39

Originally posted by [b]Ikari Gendo[/b]
line 33 should be: if ((Class == Job_Sage || Class == Job_Professor || Class == Job_Baby_Sage) && (job_soc < 1)){
atm it is if (Class == Job_Sage || Class == Job_Professor || Class == Job_Baby_Sage && (job_soc < 1)){ so the if is true regardless of job_soc

and most of the other npc have the same problem

This post has been edited by Ikari Gendo on May 31, 2012 19:40

Hercules Elf Bot - May 31, 2012 20:14

Originally posted by [b]Masao[/b]
As if i'm not complety wrong, but i'm pretty sure both work the exact same way.

Working As Intended.

Hercules Elf Bot - May 31, 2012 21:12

Originally posted by [b]Ikari Gendo[/b]
if you don't set the () arount the "or" parts, only the baby job have the job_soc < 1 "and" expression

i have tryed it on our server with the current SVN and only with those corrections the quest works

Hercules Elf Bot - May 31, 2012 21:49

Originally posted by [b]Vali[/b]
In C the && have precedence over the || if there is not parenthesis () will not work correctly:

http://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B#Operator_precedence

This post has been edited by Vali on May 31, 2012 21:52

Hercules Elf Bot - May 31, 2012 22:06

Originally posted by [b]Masao[/b]
Ok thanks for the info, didn't knew that ^^

Fixed in [rev=16192] .

This post has been edited by Masao on May 31, 2012 22:13