Changeset 16183 - instance problem
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#5886
Status
Confirmed
Severity
Fair
Started
Hercules Elf Bot
Jun 1, 2012 8:53
Last Post
Hercules Elf Bot
Jun 1, 2012 15:22
Confirmation
Hercules Elf Bot - Jun 1, 2012 8:53
Originally posted by [b]saithis[/b]
In npc.c the instances get now destroyed after @reloadscript, and a line after that it tries to reinitialize them:
[CODE]
do_final_instance();
for( i = 0; i < ARRAYLENGTH(instance); ++i )
instance_init(instance[i].instance_id);
[/CODE]
Also some scripts supported reinitialization after @reloadscript, this scripts are now broken.
For example [url="http://saithis.de/endless_tower.txt"]my ET[/url] script just restarted the last stage they were on.
So wouldn't it be better to rewrite the instance scripts to support reinitialization instead of removing this feature for all scripts?
In npc.c the instances get now destroyed after @reloadscript, and a line after that it tries to reinitialize them:
[CODE]
do_final_instance();
for( i = 0; i < ARRAYLENGTH(instance); ++i )
instance_init(instance[i].instance_id);
[/CODE]
Also some scripts supported reinitialization after @reloadscript, this scripts are now broken.
For example [url="http://saithis.de/endless_tower.txt"]my ET[/url] script just restarted the last stage they were on.
So wouldn't it be better to rewrite the instance scripts to support reinitialization instead of removing this feature for all scripts?
This post has been edited by saithis on Jun 1, 2012 8:54
Hercules Elf Bot - Jun 1, 2012 11:51
Originally posted by [b]Ind[/b]
thank you for the suggestion -- the bug tracker isn't for suggestions though. but i wrote a topic for you here :3 http://rathena.org/board/topic/64704-making-instances-persistent-to-reloadscript/ (i believe this doesn't count as a bug report because the official instance scripts rathena provides all break in reloadscript)
thank you for the suggestion -- the bug tracker isn't for suggestions though. but i wrote a topic for you here :3 http://rathena.org/board/topic/64704-making-instances-persistent-to-reloadscript/ (i believe this doesn't count as a bug report because the official instance scripts rathena provides all break in reloadscript)
This post has been edited by Ind on Jun 1, 2012 11:51
Hercules Elf Bot - Jun 1, 2012 14:56
Originally posted by [b]saithis[/b]
i tought is is a bug, because the new code tries to reinitialize the instance, after destroying it
maybe it doesn't break the code(didn't test what happens there), but it's definitelly not the right thing^^
But thanks for making the suggestion topic
i tought is is a bug, because the new code tries to reinitialize the instance, after destroying it
maybe it doesn't break the code(didn't test what happens there), but it's definitelly not the right thing^^
But thanks for making the suggestion topic
Hercules Elf Bot - Jun 1, 2012 15:22
Originally posted by [b]Ind[/b]
whops sorry you're right.
whops sorry you're right.