Issue information

Issue ID
#5929
Status
Fixed
Severity
Fair
Started
Hercules Elf Bot
Jun 4, 2012 10:04
Last Post
Hercules Elf Bot
Jun 12, 2012 9:59
Confirmation
Yes (1)
No (0)

Hercules Elf Bot - Jun 4, 2012 10:04

Originally posted by [b]Lemongrass[/b]
For the latest revision:
[url="http://sourceforge.net/apps/trac/rathena/changeset/16227/"]http://sourceforge.net/apps/trac/rathena/changeset/16227/[/url]

Shouldn't the function

static int vending_checknearnpc_sub(struct block_list* bl, va_list args)

return 0 in the case that the NPC is invisible? The check would be kind of meaningless if it should not.

Hercules Elf Bot - Jun 4, 2012 11:38

Originally posted by [b]malufett[/b]
Confirmed!
[CODE]static int vending_checknearnpc_sub(struct block_list* bl, va_list args) {
struct npc_data *nd = (struct npc_data*)bl;

if( nd->sc.option & (OPTION_HIDE|OPTION_INVISIBLE) )
return 1;

return 1;
}[/CODE]

Hercules Elf Bot - Jun 4, 2012 12:11

Originally posted by [b]Ind[/b]
indeed was a typo d: lack of attention by my part

Hercules Elf Bot - Jun 4, 2012 16:07

Originally posted by [b]Ind[/b]
should be fixed in [rev=16229]