Issue information

Issue ID
#6044
Status
Started
Severity
Fair
Started
Hercules Elf Bot
Jun 17, 2012 2:19
Last Post
Hercules Elf Bot
Aug 5, 2012 0:20
Confirmation
Yes (5)
No (0)

Hercules Elf Bot - Jun 17, 2012 2:19

Originally posted by [b]Daegaladh[/b]
Homunculus, mercenaries and elementals don't warp to the master position

Only mercenaries do, but not correctly, they're warping instantly and not after 3 seconds as it should be:

unit.c :
[CODE] if( sd->md && !check_distance_bl(&sd->bl, &sd->md->bl, MAX_MER_DISTANCE) )
{// mercenary is too far from the master so warp the master's position
unit_warp( &sd->md->bl, sd->bl.m, sd->bl.x, sd->bl.y, CLR_TELEPORT );
}[/CODE]
[CODE]
else if( mrd && mrd->master && !check_distance_bl(&mrd->master->bl, bl, MAX_MER_DISTANCE) )
{// mercenary is too far from the master so warp the master's position
unit_warp( bl, mrd->master->bl.id, mrd->master->bl.x, mrd->master->bl.y, CLR_TELEPORT );
}[/CODE]


[u][b]How it should work (tested on kRO and iRO)[/b]:[/u]
All, homunculus, mercenaries and elementals should warp to the master position when they are more than 14 cells from you (or 13 cells between you and them) away for 3 seconds.
That means, if you go away from them more than 14 cells but come back to the range before the time is over, they don't warp.

So, the distance should be double checked, first when you go away and starts the 3 seconds timer, and again when the timer is over to check if they're still away or not.

Hercules Elf Bot - Jun 17, 2012 3:00

Originally posted by [b]frenzmu06[/b]
confirmed this to homunc and elemental, also have problem with this
how about the pet? also is their walk speed behavior after warping to your position already fixed?

This post has been edited by frenzmu06 on Jun 17, 2012 3:02

Hercules Elf Bot - Jun 17, 2012 3:39

Originally posted by [b]Daegaladh[/b]
Don't know about pets, but mercenaries and elementals should mimic their master's speed on each change map, as homunculus do.

Hercules Elf Bot - Jun 17, 2012 4:18

Originally posted by [b]frenzmu06[/b]
what i remember on pet is that after they warp to you they sometimes do abnormal movement speed (they get max movespeed and resets only to normal after relogging) ill try test pets later if i have time

edit:
the pet is fine

This post has been edited by frenzmu06 on Jun 27, 2012 7:34

Hercules Elf Bot - Jun 21, 2012 10:42

Originally posted by [b]GreenBox[/b]
Partial fix on [rev=16327].

Hercules Elf Bot - Jun 25, 2012 11:27

Originally posted by [b]Daegaladh[/b]
Please, don't forget to add this too:


[CODE]
Index: clif.c
===================================================================
--- clif.c (revision 16345)
+++ clif.c (working copy)
@@ -9170,6 +9170,7 @@
clif_spawn(&sd->md->bl);
clif_mercenary_info(sd);
clif_mercenary_skillblock(sd);
+ status_calc_bl(&sd->md->bl, SCB_SPEED); //Mercenary mimic their master's speed on each map change
}

if( sd->ed ) {
@@ -9179,6 +9180,7 @@
clif_elemental_updatestatus(sd,SP_HP);
clif_hpmeter_single(sd->fd,sd->ed->bl.id,sd->ed->battle_status.hp,sd->ed->battle_status.matk_max);
clif_elemental_updatestatus(sd,SP_SP);
+ status_calc_bl(&sd->ed->bl, SCB_SPEED); //Elemental mimic their master's speed on each map change
}

if(sd->state.connect_new) {
[/CODE]

This post has been edited by Daegaladh on Jun 25, 2012 11:27