Issue information

Issue ID
#6214
Status
Invalid
Severity
None
Started
Hercules Elf Bot
Jul 12, 2012 4:37
Last Post
Hercules Elf Bot
Jul 12, 2012 15:28
Confirmation
Yes (0)
No (2)

Hercules Elf Bot - Jul 12, 2012 4:37

Originally posted by [b]mofo[/b]
r16405

can't disable renewal settings even after putting comment ///

example:

trunk/src/map/config/renewal.h

///#define RENEWAL_CAST

trunk/conf/battle/skill.conf

castrate_dex_scale: 180

updated svn, edited, recompiled, still not getting "no cast" after getting >= 180 dex

Hercules Elf Bot - Jul 12, 2012 5:11

Originally posted by [b]Brynner[/b]
still working for me.

[CODE]
// Copyright (c) rAthena Dev Teams - Licensed under GNU GPL
// For more information, see LICENCE in the main folder
#ifndef _CONFIG_RENEWAL_H_
#define _CONFIG_RENEWAL_H_
/**
* rAthena configuration file (http://rathena.org)
* For detailed guidance on these check http://rathena.org/wiki/SRC/map/config/
**/
/**
* @INFO: This file holds general-purpose renewal settings, for class-specific ones check /src/map/config/Skills folder
**/
/// game renewal server mode
/// (disable by commenting the line)
///
/// leave this line to enable renewal specific support such as renewal formulas
#define RENEWAL
/// renewal cast time
/// (disable by commenting the line)
///
/// leave this line to enable renewal casting time algorithms
/// cast time is decreased by DEX * 2 + INT while 20% of the cast time is not reduced by stats.
/// example:
/// on a skill whos cast time is 10s, only 8s may be reduced. the other 2s are part of a
/// "fixed cast time" which can only be reduced by specialist items and skills
//#define RENEWAL_CAST
/// renewal drop rate algorithms
/// (disable by commenting the line)
///
/// leave this line to enable renewal item drop rate algorithms
/// while enabled a special modified based on the difference between the player and monster level is applied
/// based on the http://irowiki.org/wiki/Drop_System#Level_Factor table
#define RENEWAL_DROP
/// renewal exp rate algorithms
/// (disable by commenting the line)
///
/// leave this line to enable renewal item exp rate algorithms
/// while enabled a special modified based on the difference between the player and monster level is applied
#define RENEWAL_EXP
/// renewal level modifier on damage
/// (disable by commenting the line)
///
// leave this line to enable renewal base level modifier on skill damage (selected skills only)
#define RENEWAL_LVDMG
/// renewal cast time variable cast requirement
///
/// this is the value required for no variable cast-time with stats.
/// formula: (DEX * 2) + INT
/// default: 530
//#define RENEWAL_CAST_VMIN 530
/// renewal enchant deadly poison algorithm
///
/// leave this line to enable the renewed EDP algorithm
/// under renewal mode:
/// - damage is NOT increased by 400%
/// - it does NOT affect grimtooth
/// - weapon and status ATK are increased
#define RENEWAL_EDP
/// renewal ASPD [malufett]
/// (disable by commenting the line)
///
/// leave this line to enable renewal ASPD
/// - shield penalty is applied
/// - agi has a greater factor to your ASPD increase
/// - there is a change in how skill/items give ASPD
/// - some skills/items ASPD bonus won't stack
#define RENEWAL_ASPD
#endif // _CONFIG_RENEWAL_H_
[/CODE]

Hercules Elf Bot - Jul 12, 2012 6:02

Originally posted by [b]mofo[/b]
i'm reviewing r16382, and check for changes. maybe i missed something.

@Brynner
which revision are you using?


ok i think i see what i did wrong. there are two renewal.h files.

one is inside trunk/src/config
the other one is in trunk/src/map/config

i don't know which one dictates how the settings behave so i just edited them both to my preference.

Sorry for posting in bug tracker right away. I just didn't know where to put it in forums.

This post has been edited by mofo on Jul 12, 2012 6:19

Hercules Elf Bot - Jul 12, 2012 7:32

Originally posted by [b]Brynner[/b]
the latest revision. on the latest revision. they move the trunk/src/map/config to trunk/src/config. the old trunk/src/map/config is no longer functional.