Magic Book Quest Typo
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6279
Status
Unable to Reproduce
Severity
None
Started
Hercules Elf Bot
Jul 20, 2012 0:25
Last Post
Hercules Elf Bot
Jul 20, 2012 16:05
Confirmation
Hercules Elf Bot - Jul 20, 2012 0:25
Originally posted by [b]Aleos[/b]
There are two locations in the quest that doesn't allow players to get past the base level, Tetra Vortex, and Comet check.
[code]if ((BaseLevel < 140) || (getskilllv(2217) < 1) && (getskilllv(2213) < 1)) {[/code] Lines 1686 and 1896
[url=http://irowiki.org/wiki/Ultimate_Spellbooks_Quest]iRO Wiki[/url] says that Tetra Vortex and/or Comet are/is required. So changing the && to || will resolve this issue.
There are two locations in the quest that doesn't allow players to get past the base level, Tetra Vortex, and Comet check.
[code]if ((BaseLevel < 140) || (getskilllv(2217) < 1) && (getskilllv(2213) < 1)) {[/code] Lines 1686 and 1896
[url=http://irowiki.org/wiki/Ultimate_Spellbooks_Quest]iRO Wiki[/url] says that Tetra Vortex and/or Comet are/is required. So changing the && to || will resolve this issue.
Hercules Elf Bot - Jul 20, 2012 2:10
Originally posted by [b]Euphy[/b]
The scripting isn't standard, but it's not incorrect. I could get past the checks having either skill.
The scripting isn't standard, but it's not incorrect. I could get past the checks having either skill.
Hercules Elf Bot - Jul 20, 2012 6:50
Originally posted by [b]malufett[/b]
[quote]The scripting isn't standard, but it's not incorrect. I could get past the checks having either skill.[/quote]
hmm...
[quote]if( true || false && true)[/quote]
will result to true where it says I passed the minimum level and I have either the skills
but what if
[quote]if( true || false && false)[/quote]
will also result to true where it says I passed the minimum level and I don't have either the two skills
and what about if
[quote]if( false || true && true)[/quote]
resulting to true where I fail the minimum level and I have the two skills..
anyway this is just my observation but I don't know what the quest really does...
[quote]The scripting isn't standard, but it's not incorrect. I could get past the checks having either skill.[/quote]
hmm...
[quote]if( true || false && true)[/quote]
will result to true where it says I passed the minimum level and I have either the skills
but what if
[quote]if( true || false && false)[/quote]
will also result to true where it says I passed the minimum level and I don't have either the two skills
and what about if
[quote]if( false || true && true)[/quote]
resulting to true where I fail the minimum level and I have the two skills..
anyway this is just my observation but I don't know what the quest really does...
Hercules Elf Bot - Jul 20, 2012 16:05
Originally posted by [b]Euphy[/b]
I honestly have no idea how the conditionals work when mixing &&/||, but from what I tested:[list]
[*]True ~ False ~ False = Check failed
[*]False ~ True ~ False = Check failed
[*]False ~ False ~ True = Check failed
[*]False ~ False ~ False = Check failed
[/list]
All other cases pass the check, so it works.
I honestly have no idea how the conditionals work when mixing &&/||, but from what I tested:[list]
[*]True ~ False ~ False = Check failed
[*]False ~ True ~ False = Check failed
[*]False ~ False ~ True = Check failed
[*]False ~ False ~ False = Check failed
[/list]
All other cases pass the check, so it works.