Duplicated entry in skill.c that cause after-cast delay not working properly
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6284
Status
Working as Intended
Severity
None
Started
Hercules Elf Bot
Jul 20, 2012 7:51
Last Post
Hercules Elf Bot
Jul 21, 2012 9:59
Confirmation
Hercules Elf Bot - Jul 20, 2012 7:51
Originally posted by [b]Brynner[/b]
this entry is already added at line 8844-8853. before revision [color=#282828][font=helvetica, arial, sans-serif][size=3]16422.[/size][/font][/color]
[CODE]
if( sd && skill_get_cooldown(ud->skillid,ud->skilllv) > 0 ){
int i, cooldown = skill_get_cooldown(ud->skillid, ud->skilllv);
for (i = 0; i < ARRAYLENGTH(sd->skillcooldown) && sd->skillcooldown[i].id; i++) { // Increases/Decreases cooldown of a skill by item/card bonuses.
if (sd->skillcooldown[i].id == ud->skillid){
cooldown += sd->skillcooldown[i].val;
break;
}
}
skill_blockpc_start(sd, ud->skillid, cooldown);
}
[/CODE]
but on the revision 16422. the duplicate entry appears which cause to the kiel card not working on some skills.
on line 9068-9077
[CODE]
if( sd && skill_get_cooldown(ud->skillid,ud->skilllv) > 0 ){
int i, cooldown = skill_get_cooldown(ud->skillid, ud->skilllv);
for (i = 0; i < ARRAYLENGTH(sd->skillcooldown) && sd->skillcooldown[i].id; i++) { // Increases/Decreases cooldown of a skill by item/card bonuses.
if (sd->skillcooldown[i].id == ud->skillid){
cooldown += sd->skillcooldown[i].val;
break;
}
}
skill_blockpc_start(sd, ud->skillid, cooldown);
}
[/CODE]
this entry is already added at line 8844-8853. before revision [color=#282828][font=helvetica, arial, sans-serif][size=3]16422.[/size][/font][/color]
[CODE]
if( sd && skill_get_cooldown(ud->skillid,ud->skilllv) > 0 ){
int i, cooldown = skill_get_cooldown(ud->skillid, ud->skilllv);
for (i = 0; i < ARRAYLENGTH(sd->skillcooldown) && sd->skillcooldown[i].id; i++) { // Increases/Decreases cooldown of a skill by item/card bonuses.
if (sd->skillcooldown[i].id == ud->skillid){
cooldown += sd->skillcooldown[i].val;
break;
}
}
skill_blockpc_start(sd, ud->skillid, cooldown);
}
[/CODE]
but on the revision 16422. the duplicate entry appears which cause to the kiel card not working on some skills.
on line 9068-9077
[CODE]
if( sd && skill_get_cooldown(ud->skillid,ud->skilllv) > 0 ){
int i, cooldown = skill_get_cooldown(ud->skillid, ud->skilllv);
for (i = 0; i < ARRAYLENGTH(sd->skillcooldown) && sd->skillcooldown[i].id; i++) { // Increases/Decreases cooldown of a skill by item/card bonuses.
if (sd->skillcooldown[i].id == ud->skillid){
cooldown += sd->skillcooldown[i].val;
break;
}
}
skill_blockpc_start(sd, ud->skillid, cooldown);
}
[/CODE]
This post has been edited by Brynner on Jul 20, 2012 7:58
Hercules Elf Bot - Jul 20, 2012 7:57
Originally posted by [b]malufett[/b]
it was working as intended.....
the first occurrence is for target skills and the second one is for ground skills...
and as I stated in
[url="http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/page__gopid__12161#entry12161"]http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/page__gopid__12161#entry12161[/url]
that Kiel Card is working fine,,,,..
it was working as intended.....
the first occurrence is for target skills and the second one is for ground skills...
and as I stated in
[url="http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/page__gopid__12161#entry12161"]http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/page__gopid__12161#entry12161[/url]
that Kiel Card is working fine,,,,..
Hercules Elf Bot - Jul 20, 2012 9:20
Originally posted by [b]freakmastersx[/b]
i confirm this. this is also happen to when before i update the server. the kiel card will be useless if this will be implemented. but thanks for finding the reason while the kiel card doesn't work.
i confirm this. this is also happen to when before i update the server. the kiel card will be useless if this will be implemented. but thanks for finding the reason while the kiel card doesn't work.
Hercules Elf Bot - Jul 20, 2012 11:29
Originally posted by [b]malufett[/b]
do you guys really don't know what is the difference of cooldown and cast delay?? or you are just confused??
so here I show you an illustration..
[img]http://i49.tinypic.com/2s84nsj.jpg[/img]
so notice the darker shade that is the cast delay that is the one that Kiel card/other related item reduces...
so here an example I put a 'clif_displaymessage' for you to see the actual value of cast delay when casted....
so here without the card..
[img]http://i45.tinypic.com/2usc1e8.jpg[/img]
and with 2 Kiel Cards
[img]http://i48.tinypic.com/2mqokkm.jpg[/img]
so the value now is 400( 1000 - 60%)
and as you notice it shows two times that is because I put two skill in my shortcut key list...
I hope you mesmerize with my demo...
do you guys really don't know what is the difference of cooldown and cast delay?? or you are just confused??
so here I show you an illustration..
[img]http://i49.tinypic.com/2s84nsj.jpg[/img]
so notice the darker shade that is the cast delay that is the one that Kiel card/other related item reduces...
so here an example I put a 'clif_displaymessage' for you to see the actual value of cast delay when casted....
so here without the card..
[img]http://i45.tinypic.com/2usc1e8.jpg[/img]
and with 2 Kiel Cards
[img]http://i48.tinypic.com/2mqokkm.jpg[/img]
so the value now is 400( 1000 - 60%)
and as you notice it shows two times that is because I put two skill in my shortcut key list...
I hope you mesmerize with my demo...
This post has been edited by malufett on Jul 20, 2012 11:30
Hercules Elf Bot - Jul 21, 2012 3:24
Originally posted by [b]Mysterious[/b]
Very sexy indeed Malufett!
Very sexy indeed Malufett!
Hercules Elf Bot - Jul 21, 2012 9:59
Originally posted by [b]close23[/b]
i confirm this also. before the problem on sorcerer skill is can be spammed without using kiel card.but its already fix. but after revision [color=#282828][font=helvetica, arial, sans-serif][size=3]16422.some skill is no longer supported the kiel card which is a bug if im not mistaken it will also decrease the delay cast of the skill. but it doesn't decease anything specially on some sorcerer skill.[/size][/font][/color]
[color=#282828][font=helvetica, arial, sans-serif][size=3]i found the other regarding on the kiel card.[/size][/font][/color]
[url="http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/"]http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/[/url]
i confirm this also. before the problem on sorcerer skill is can be spammed without using kiel card.but its already fix. but after revision [color=#282828][font=helvetica, arial, sans-serif][size=3]16422.some skill is no longer supported the kiel card which is a bug if im not mistaken it will also decrease the delay cast of the skill. but it doesn't decease anything specially on some sorcerer skill.[/size][/font][/color]
[color=#282828][font=helvetica, arial, sans-serif][size=3]i found the other regarding on the kiel card.[/size][/font][/color]
[url="http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/"]http://rathena.org/board/tracker/issue-6275-kiel-card-is-not-working-on-latest-revision/[/url]