Brandish Spear bug for rune knight

Originally posted by [b]Kenpachi[/b]
Indeed, in script_require_db.txt the field [i]RequiredState [/i]can't hold more than one state but for Brandish Spear it should be [i]riding[/i] AND [i]dragon[/i].

BTW; The legend is outdated. please edit it along with fixxing the bug.

Originally posted by [b]Brynner[/b]
thanks for the confirm

Originally posted by [b]Brynner[/b]
any update for this?

Originally posted by [b]Brynner[/b]
bump for this

Originally posted by [b]Kenpachi[/b]
Dude, seriously. We are no machines....

Originally posted by [b]Brynner[/b]
[quote name='Kenpachi' timestamp='1343382290' post='12574']
Dude, seriously. We are no machines....
[/quote]

since there is no one fix the brandish spear bug. here is my fix for this bug.

Originally posted by [b]Euphy[/b]
@Brynner: That's quite a workaround for a single skill edit. What Kenpachi stated was that a field value should be expanded, not that the "Riding" status itself should be changed...

Originally posted by [b]Brynner[/b]
[quote name='Euphy' timestamp='1343680220' post='12737']
@Brynner: That's quite a workaround for a single skill edit. What Kenpachi stated was that a field value should be expanded, not that the "Riding" status itself should be changed...
[/quote]


[b] Brandish Spear bug for rune knight is now working if you are using dragon mount. which means rune knight cannot use brandish spear because they are not using peco anymore. but on the solution that i made the brandish spear can now be use even you are riding on dragon.[/b]

Originally posted by [b]malufett[/b]
Euphy has a point..
anyway I'll make it so support multiple state as sir Kenpachi suggested...

Originally posted by [b]hendra814[/b]
any update for this problem, beside using patch?

Originally posted by [b]hendra814[/b]
bump

Originally posted by [b]hendra814[/b]
need update fot this bug.
Thanks

Originally posted by [b]AppleGirl[/b]
buuump please fix..

Originally posted by [b]Jhedzkie[/b]
are there any fix for this yet? thanks

Originally posted by [b]hendra814[/b]
bump... please fix this problem
Thanks

Originally posted by [b]MarkZD[/b]
There's no need to make it use more than one state as any skill you can use in peco you can use in Ferus.

In scr/map/skill.c
[b]Just change:[/b]
[CODE]
case ST_RIDING:
if(!pc_isriding(sd)) {
clif_skill_fail(sd,skill,USESKILL_FAIL_LEVEL,0);
return 0;
}
[/CODE]
[b]To:[/b]
[CODE]
case ST_RIDING:
if(!(pc_isriding(sd) || pc_isridingdragon(sd))) {
clif_skill_fail(sd,skill,USESKILL_FAIL_LEVEL,0);
return 0;
}
[/CODE]

Originally posted by [b]hendra814[/b]
how about this
[url="http://code.google.com/p/idathena/source/detail?r=281"]http://code.google.com/p/idathena/source/detail?r=281[/url]

Originally posted by [b]exneval[/b]
it's just same, i made that since rA still working on expanding the RequireState

Originally posted by [b]hendra814[/b]
ok, i'm wait the fixing for this bug.
Thanks Exneval

[quote name="Kenpachi" timestamp="1343119180"]
Originally posted by [b]Kenpachi[/b]
Indeed, in script_require_db.txt the field [i]RequiredState [/i]can't hold more than one state but for Brandish Spear it should be [i]riding[/i] AND [i]dragon[/i].

BTW; The legend is outdated. please edit it along with fixxing the bug.[/quote]its not AND, its OR D: but i was mislead as well I didnt think it fully, wrote a faux fix :{ [url="http://herc.ws/board/blog/1/entry-3-wasted-time-t-t/"]http://herc.ws/board/blog/1/entry-3-wasted-time-t-t/[/url]

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/e15fe6131c970f8f7574d38f3a3cc62e1873a072"]https://github.com/HerculesWS/Hercules/commit/e15fe6131c970f8f7574d38f3a3cc62e1873a072[/url]