Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6320
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jul 25, 2012 9:23
Last Post
Hercules Elf Bot
Jul 25, 2012 12:09
Confirmation
Yes (2)
No (0)
Hercules Elf Bot - Jul 25, 2012 9:23
Originally posted by [b]DeePee[/b] A player reported this to us. I will just copypaste his report to us as it explains it pretty well.
[quote]
It has come to my attention that there is a bug involving the trading system that can be abused in a few manners.
These manners being harassment from one player to another, disruption of PvM, disruption of PvP, and disruption of WoE.
I will first explain how the bug works in text. If player [color=blue]A[/color] requests a deal with player [color=green]B[/color], player [color=green]B[/color] can choose neither to accept or decline the trade. After this, player [color=green]B[/color] can then request a deal with player [color=yellow]C[/color], in which player [color=green]B[/color] can hit 'Ok' on the request player [color=blue]A[/color] sent him. When player [color=green]B[/color] does this, it will automatically open up a trade box between player [color=green]B[/color] and [color=yellow]C[/color], even if player [color=yellow]C[/color] chose not to click any option.
This could EASILY be abuseable by anyone with the ability to dual-client.
Below are some screenshots that show how the steps are enacted.
The result is Obstacle automatically being brought into a trade without hitting either 'Ok' or 'Cancel'.
The reason that a bug like this could be abused in the ways that I have mentioned is because of how big the trade box is. This would cause players to be unable to click areas on a large portion of their map, or be forced to run towards an area which may or may not be beneficial to them in order to kite the monster or player their fighting while they hit cancel.
[b]Not to mention: [color=red]This can be used as often as player [/color][color=blue]A[/color] [color=red]sends a trade request to player[/color] [color=green]B[/color] [color=red]which could result in a lot of problems for player[/color] [color=yellow]C[/color][color=red].[/color][/b]
[/quote]
Hercules Elf Bot - Jul 25, 2012 10:01
Originally posted by [b]GM Takumirai[/b] - good explanation..
- this may be abuse during WOE .. even if player dont accept the deal..
- but he can counter this by using or doing /nt
- but we don't know what do this bug will do - it might be used exploiting or dupplicating items.. - we don't know yet.. but hope we can do some action regarding this..
Hercules Elf Bot - Jul 25, 2012 11:34
Originally posted by [b]shadowseph[/b] Hello, here is a fix for that. It will restrict trading if you are in a potential trade.
[CODE]
Index: trade.c
===================================================================
--- trade.c (revision 31)
+++ trade.c (working copy)
@@ -53,6 +53,10 @@
return;
}
}
+ if(sd->trade_partner != 0) {
+ clif_tradestart(sd, 2); // You are in another trade *bug fix*
+ return;
+ }
if (target_sd->trade_partner != 0) {
clif_tradestart(sd, 2); // person is in another trade
[/CODE]
Hercules Elf Bot - Jul 25, 2012 11:43
Originally posted by [b]malufett[/b] I tried it in iRO...this is how it works..when I already have someone in trade or the prompting stage then tries to trade another one the first one will be cancelled saying that the trade has been cancel then it will now continue to the next one..
I'll commit the fixes later...
This post has been edited by
malufett
on Jul 25, 2012 11:57
Hercules Elf Bot - Jul 25, 2012 12:09
Originally posted by [b]malufett[/b] Fixed @ [rev='16499']