Issue information

Issue ID
#6324
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jul 26, 2012 6:33
Last Post
Hercules Elf Bot
Aug 3, 2012 6:49
Confirmation
Yes (2)
No (0)

Hercules Elf Bot - Jul 26, 2012 6:33

Originally posted by [b]Ron[/b]
[color=#555555]When you kill a monster who is nonaggressive, after its dead and it respawns, the aggressive-ness remains on it and it will come attack you.[/color]
[color=#555555][background=rgb(243, 243, 243)]Been tested on Les, Zerom, and Sohee's[/background][/color]
[font="Helvetica Neue, Arial, Helvetica, sans-serif"][size="2"][color="#555555"]Any fix?[/color][/size][/font]

Hercules Elf Bot - Jul 26, 2012 10:01

Originally posted by [b]Vali[/b]
I can confirm this.

Hercules Elf Bot - Jul 26, 2012 15:29

Originally posted by [b]Ron[/b]
it gets annoying when a random passivemob suddenly attacks you.

Hercules Elf Bot - Jul 27, 2012 3:15

Originally posted by [b]Ron[/b]
BumP?

Hercules Elf Bot - Jul 27, 2012 3:18

Originally posted by [b]Ind[/b]
I'm unable to test right now but the first thing that comes to my mind is that the monster doesn't unlock its target when it dies, and since data from mobs with respawn isn't cleared after death I think it'll chase the previous target as long as he is still in range when it respawns (a mob_unlocktarget on mob_dead should fix if i'm correct)

Hercules Elf Bot - Jul 27, 2012 8:08

Originally posted by [b]Angezerus[/b]
Confirmed on Mi Gaos.

Testable with fixed+insta spawn mobs (probaby custom, cause I couldn't find any :P), or maybe on very small maps. If they spawn near to you, they walk to you even from outside of the screen. If they spawn too far, they will return to passive state, cause they "can't reach" you.

I think this is related to another problem:
If you kill a monster for example with dual bolt, but the first bolt kills the mob, then the secound kills it again as it respawns somewhere in the map (ofc if you can make 1hit kill). This applies to bowling bash, dual bolting, party killing.
So it seems that the killed monster respawns with exactly the same entity, and respawning does not cancel previous events on the entity.

This post has been edited by Angezerus on Jul 27, 2012 8:08

Hercules Elf Bot - Jul 27, 2012 21:46

Originally posted by [b]Ind[/b]
i couldn't reproduce this, tried against sohees and mi gaos, created a custom respawn point for both nearby where they're killed -- they didn't chase me after respawing (tried with no respawn time and with 10s respawn time, no difference)

Hercules Elf Bot - Jul 27, 2012 21:54

Originally posted by [b]Ron[/b]
I am using pre-renewal..
its still happening as of today~

Hercules Elf Bot - Jul 27, 2012 23:23

Originally posted by [b]Ind[/b]
i need better directions on how to reproduce it then

Hercules Elf Bot - Jul 28, 2012 1:20

Originally posted by [b]Ron[/b]
Apparently this is an official settings, asked couple of friends.
And I just basically had rAthena Pre-Renewal and thats what it was doing.

Hercules Elf Bot - Jul 28, 2012 15:27

Originally posted by [b]Vali[/b]
[quote name='Ind' timestamp='1343431394' post='12590']
i need better directions on how to reproduce it then
[/quote]

r16519: http://www.youtube.com/watch?v=uUigBnBmYwk You can see that after kill the monster it come to you and start hitting you.

Hercules Elf Bot - Jul 28, 2012 17:08

Originally posted by [b]Ron[/b]
And I'm running on r16425~

Hercules Elf Bot - Jul 28, 2012 17:32

Originally posted by [b]Ron[/b]
I think this is proof enough/?

Hercules Elf Bot - Jul 29, 2012 1:53

Originally posted by [b]Ind[/b]
proof enough isn't the problem, i'm only able to fix something that I can reproduce, and thanks to vali i could reproduce (it seems you have to kill it while it is at full health), will try to fix it now.

Hercules Elf Bot - Jul 29, 2012 2:07

Originally posted by [b]Ind[/b]
Fixed in [rev=16527] Thanks to you all

Hercules Elf Bot - Aug 1, 2012 1:07

Originally posted by [b]Ron[/b]
Looks like not fixed afterall..

[img]http://i.imgur.com/zMWge.gif[/img]

[img]http://i.imgur.com/IqX7O.gif[/img]

Hercules Elf Bot - Aug 1, 2012 16:02

Originally posted by [b]malufett[/b]
confirmed,,,,but once they detect and attack the one who killed them then it will return again to passive mode...
however this will happen conditionally...[s]when it re-spawn next to the killer or once it doesn't do anything like walking or[/s] when the mob dies and the same time it does its attack..

sir Ind I suggest to put the
[CODE] md->attacked_id = 0; [/CODE]

to the 'mob_spawn' so that clashing of death and aggressiveness won't ignore the fix.... :)

This post has been edited by malufett on Aug 1, 2012 16:17

Hercules Elf Bot - Aug 2, 2012 0:24

Originally posted by [b]Ind[/b]
malufett I'm not able to reproduce that, being you're able to, please issue the fix. thank you very much.

Hercules Elf Bot - Aug 2, 2012 1:53

Originally posted by [b]malufett[/b]
BTW as I am going into deeper I found out that the target is being release
[CODE]mob_unlocktarget((struct mob_data *)src,tick);[/CODE]
that is inside 'mob_dead' while there is again

[CODE]
md->attacked_id = 0;
md->target_id = 0;[/CODE]
inside 'mob_spawn'


so my theory is that the state of aggressiveness is not totally remove when re-spawn in some special case..anyway I'll try to fix it...

found it
I'll commit the fixes later..:)

This post has been edited by malufett on Aug 2, 2012 5:42

Hercules Elf Bot - Aug 2, 2012 6:27

Originally posted by [b]Ron[/b]
yay cant wait..

Hercules Elf Bot - Aug 2, 2012 14:31

Originally posted by [b]malufett[/b]
Fixed @ [rev='16560']

Hercules Elf Bot - Aug 2, 2012 22:52

Originally posted by [b]Ron[/b]
I'm attempting to do add it manually.
Can you show me which you have changed?

Hercules Elf Bot - Aug 3, 2012 0:57

Originally posted by [b]EvilPuncker[/b]
[quote name='Ron' timestamp='1343947949' post='12884']
I'm attempting to do add it manually.Can you show me which you have changed?
[/quote]
[url="http://trac.rathena.org/changeset/16560/rathena#file7"]http://trac.rathena.org/changeset/16560/rathena#file7[/url]

Hercules Elf Bot - Aug 3, 2012 1:29

Originally posted by [b]Ron[/b]
So just the mob.c file?

Hercules Elf Bot - Aug 3, 2012 6:49

Originally posted by [b]malufett[/b]
yup just the mob.c

to briefly explain the problem..it was cause by its attacking state where it was delayed when it was killed so it will land the suspended attack till it re-spawn..