map_athena crash after using any skill

Originally posted by [b]Vali[/b]
Having the same issue but I can reproduce it when someone uses the repair item and select the item.

Vali~

Originally posted by [b]Vali[/b]
I only can reproduce it in linux, not in windows.

Originally posted by [b]EvilPuncker[/b]
a gdb core dump would be nice for devs I think

Originally posted by [b]Lelouch vi Britannia[/b]
Lol!! same problem then this message appears in the map server
[code]
[Error]: Server recieved crush cignal! Attempting to save all online characters![/code]

Originally posted by [b]Vali[/b]
[quote name='EvilPuncker' timestamp='1343500054' post='12631']
a gdb core dump would be nice for devs I think
[/quote]

To be truth, I was not able to do it. I did it work one time but I don't know how.

Originally posted by [b]hissash[/b]
I've been having the same issue... I'm able to reproduce it every time I try to do anything involving attacking an enemy.... I'm on windows btw

Originally posted by [b]Lelouch vi Britannia[/b]
not just attacking enemy like monster or player also even using any kind of skills will cause the map server crashed

i forgot im using linux anyway

Originally posted by [b]hissash[/b]
As far as I can tell I can still use skills at least First aid doesn't give me an issue...... Give me a sec to test job skills

Edit: Nvm I cant do anything without crash now

Originally posted by [b]Lelouch vi Britannia[/b]
Wew all skills are not affected with this crash .the only part when the map server crashed is when you attack any kind of monster including players in PvP

Originally posted by [b]Brynner[/b]
i hope this issue will be fixed.

Originally posted by [b]Brynner[/b]
anyone got a fix for this issue?

Originally posted by [b]Ind[/b]
to be blamed on oboru talisman stuff, workign on it.

Originally posted by [b]Ind[/b]
Fixed [rev=16526]

Originally posted by [b]hendra814[/b]
Thanks, it's working good now.

Originally posted by [b]Vali[/b]
Still crashing when someone use weapon repair. But only in Linux and if the --enable-debug=gdb is not set in the debug o.o

I tried 3 times without that, 3 times it crashed the map server, I enabled the --enable-debug=gdb and no more crashes... any idea?(And i think is irrelevant, the time the server not crashed also the target was sitting).

Originally posted by [b]Ind[/b]
wow o_o hmmm

Originally posted by [b]Vali[/b]
[quote name='Ind' timestamp='1343706498' post='12749']
wow o_o hmmm
[/quote]

I don't know if your reaction is good or bad.... xD

Originally posted by [b]Ind[/b]
i have no idea on what you've just told me it's quite odd, maybe gdb has some software-induced ECC which protects it from crashing over -- which is the scary part since it means there is a problem we cannot detect.

Originally posted by [b]Vali[/b]
There is something I can do to know where is the error, I will be in debug until this f is fixed and if crash again (that now is not happening) I will post the dump but I cant be in debug mode for ever :S

Originally posted by [b]Ind[/b]
what is the scenario? like i tried with a blacksmith in prontera to use weapon repair on other character that had a silk robe broken -- nothing crashed -> fixed silk robe.

Originally posted by [b]Vali[/b]
Weapon repair over other char that has the Eden Armour broken. After select the item to repair the map server crashes. The item is not repaired.

Originally posted by [b]Vali[/b]
Double post, sorry.

Originally posted by [b]Ind[/b]
whats the item id of that

Originally posted by [b]Vali[/b]
15031
Also this is happening to me only in linux CentOS and when I'm not using debug.

Originally posted by [b]Ind[/b]
i've disabled --enable-debug on my local, recompiled the whole thing, got a whitesmith to break 15031 on target character with meltdown, tried to use weapon repair twice, first w/o the item required for the armor, then with steel, fixed the armor -- no crashing x-x i'm not sure what can be causing that to you, do you have any customs in your source code?

Originally posted by [b]Vali[/b]
Nothing, no customs.

Originally posted by [b]Ind[/b]
whats the revision you're currently using?

Originally posted by [b]Vali[/b]
16537

Originally posted by [b]Ind[/b]
i reverted to that revision and tried the following all over
[quote]
i've disabled --enable-debug on my local, recompiled the whole thing, got a whitesmith to break 15031 on target character with meltdown, tried to use weapon repair twice, first w/o the item required for the armor, then with steel, fixed the armor[/quote]
and no crashing at all +___+ and you said you've got no customs so i'm clueless +___+

Originally posted by [b]Ind[/b]
the only thing i can think of that was recently changed in the repair stuff was clif_item_repaireffect at http://trac.rathena.org/changeset/16500/rathena although i fail to see how it could be of any harm

Originally posted by [b]Brynner[/b]
i confirmed the weapon repair problem.
1st i got this following item.
6 Iron Ore,
6 Iron,
6 Steal;
6 Rough Oridecon.

then i destroy the item of the player using melt down.
when i try to repair.

You have failed to repair this item. Please check the distance between you and the opponent.

then i try to go near with him around 1cell.
then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.

Originally posted by [b]Ind[/b]
[quote name='Brynner' timestamp='1343997110' post='12913']
i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.
[/quote]
i can't reproduce even with your directions X_X i get the "Please check the distance between you and the opponent" stuff but then i move and cast and it fix the item and no crash.
[hr]
mm what are you guys options? renewal enabled etc?

Originally posted by [b]malufett[/b]
what platforms are you using? sir Ind does it effects? I also tried it but unlucky I can't reproduce....

Originally posted by [b]Brynner[/b]
[quote name='Ind' timestamp='1343997771' post='12916']
[quote name='Brynner' timestamp='1343997110' post='12913']i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.[/quote]i can't reproduce even with your directions X_X i get the "Please check the distance between you and the opponent" stuff but then i move and cast and it fix the item and no crash.[hr]mm what are you guys options? renewal enabled etc?
[/quote]

yup renewal mechanic. but disabled renewal cast.

Originally posted by [b]Ind[/b]
not able to reproduce even with that X_X

Originally posted by [b]Vali[/b]
Renewal enables, the only thing I have out is the RE drop.

Originally posted by [b]Vali[/b]
[quote name='malufett' timestamp='1343997891' post='12917']
what platforms are you using? sir Ind does it effects? I also tried it but unlucky I can't reproduce....
[/quote]

I'm on CentOS 5.

Originally posted by [b]Ind[/b]
which client version are you guys using?

Originally posted by [b]Vali[/b]
2012-03-28
http://svn6.assembla.com/svn/ClientSide/Packets/Packet_db/packets_2012-03-28gRagexeRE.txt

Originally posted by [b]Brynner[/b]
2012-04-10

Originally posted by [b]Ind[/b]
i'm on 2012-04-10 as well and can't reproduce uhm. my my this is scary.

Originally posted by [b]close23[/b]
the server is now become unstable on the latest revision due to server crashed problem.

[quote name='Brynner' timestamp='1343997110' post='12913']
i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.
[/quote]

try to revert the changes on this revision [url="http://trac.rathena.org/changeset/16500/rathena"]http://trac.rathena.org/changeset/16500/rathena[/url] then you problem will be fix. this also happen for me before. when character use weapon repair even you are on the battle. but after i tried to revert the changes it works again normally. at this time there are still no map crashed happen.

Originally posted by [b]Vali[/b]
[quote name='close23' timestamp='1344008501' post='12943']
the server is now become unstable on the latest revision due to server crashed problem.[quote name='Brynner' timestamp='1343997110' post='12913']i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.[/quote]try to revert the changes on this revision [url="http://trac.rathena.org/changeset/16500/rathena"]http://trac.rathena....t/16500/rathena[/url] then you problem will be fix. this also happen for me before. when character use weapon repair even you are on the battle. but after i tried to revert the changes it works again normally. at this time there are still no map crashed happen.
[/quote]

That is not the way I think, the objective is have a stable emulator for all. We must find what is causing the crash to fix it, not leave it apart.

Originally posted by [b]Ind[/b]
since no developers were able to reproduce so far i need a gdb report at the very least, otherwise there is no way to tell whats causing that.

Originally posted by [b]EvilPuncker[/b]
hey ind what about that line:

[color=#000000][font=monospace][size=2][background=rgb(255, 221, 221)]if ([/background][/size][/font][/color][s]itemdb_type(item->nameid)==[/s][color=#000000][font=monospace][size=2][background=rgb(255, 221, 221)]IT_WEAPON)[/background][/size][/font][/color]
[color=#000000][font=monospace][size=2][background=rgb(221, 255, 221)]if ([/background][/size][/font][/color] sd->inventory_data[idx]->type == [color=#000000][font=monospace][size=2][background=rgb(221, 255, 221)]IT_WEAPON)[/background][/size][/font][/color]

it wasn't supposed to be changed in any patch file, maybe that is the cause?

Originally posted by [b]Brynner[/b]
[quote name='Vali' timestamp='1344084885' post='12962']
[quote name='close23' timestamp='1344008501' post='12943']the server is now become unstable on the latest revision due to server crashed problem.[quote name='Brynner' timestamp='1343997110' post='12913']i confirmed the weapon repair problem.1st i got this following item.6 Iron Ore,6 Iron,6 Steal;6 Rough Oridecon.then i destroy the item of the player using melt down.when i try to repair.You have failed to repair this item. Please check the distance between you and the opponent.then i try to go near with him around 1cell.then the skill works. i choose the weapon that i want to repair. but the server crashed. the required item still there.[/quote]try to revert the changes on this revision [url="http://trac.rathena.org/changeset/16500/rathena"]http://trac.rathena....t/16500/rathena[/url] then you problem will be fix. this also happen for me before. when character use weapon repair even you are on the battle. but after i tried to revert the changes it works again normally. at this time there are still no map crashed happen.[/quote] That is not the way I think, the objective is have a stable emulator for all. We must find what is causing the crash to fix it, not leave it apart.
[/quote]

yah you're right. we should find what is the cause of server crashed. i hope someone will figure it out of what causing server crashed.

Originally posted by [b]xmetal[/b]
Was this bug fixed ? Because i use my lastest svn but the map server still crashing when someone used this Repair Weapon skill.

Anyone?

Originally posted by [b]EvilPuncker[/b]
have anyone tried changing:

if ( sd->inventory_data[idx]->type == IT_WEAPON)


into

if (itemdb_type(item->nameid)==IT_WEAPON)


and recompiling?


since in eAthena code it is still:

[img]http://3.imgland.net/1hU6vU.png[/img]

but Ind changed it, so it might be the problem?

Originally posted by [b]Ind[/b]
[quote name='EvilPuncker' timestamp='1344631987' post='13220']
have anyone tried changing:if ( sd->inventory_data[idx]->type == IT_WEAPON)intoif (itemdb_type(item->nameid)==IT_WEAPON)and recompiling?since in eAthena code it is still:[img]http://3.imgland.net/1hU6vU.png[/img]but Ind changed it, so it might be the problem?
[/quote]
ah. silly me. so it crashes when there isn't said idx in the target inventory thank you very much.

Originally posted by [b]Ind[/b]
Fixed in [rev=16623] thanks to EvilPuncker

Originally posted by [b]Brynner[/b]
finally its working now without server crashed. thanks.