Skill quests official behavior.
Warning! This is the old Hercules bugtracker archive, and may not reflect the current state of Hercules. The current bugtracker is on GitHub Issues.
Issue information
Issue ID
#6374
Status
Fixed
Severity
None
Started
Hercules Elf Bot
Jul 30, 2012 23:21
Last Post
Hercules Elf Bot
Aug 1, 2012 23:44
Confirmation
Hercules Elf Bot - Jul 30, 2012 23:21
Originally posted by [b]Vali[/b]
I got a report about the Skill quest, to be more precise about the Arrow Crafting of Archer.
To get that skill the player needs job level 30, but.. is still needs job level 30 even being Hunter or Sniper? What is the official behavior of the quests in this case?
Vali~
I got a report about the Skill quest, to be more precise about the Arrow Crafting of Archer.
To get that skill the player needs job level 30, but.. is still needs job level 30 even being Hunter or Sniper? What is the official behavior of the quests in this case?
Vali~
This post has been edited by Vali on Jul 30, 2012 23:22
Hercules Elf Bot - Jul 30, 2012 23:38
Originally posted by [b]Joseph[/b]
They don't need to be.
[url="http://ratemyserver.net/quest_db.php?type=50000&qid=50004"]http://ratemyserver.net/quest_db.php?type=50000&qid=50004[/url]
They don't need to be.
[url="http://ratemyserver.net/quest_db.php?type=50000&qid=50004"]http://ratemyserver.net/quest_db.php?type=50000&qid=50004[/url]
Hercules Elf Bot - Jul 31, 2012 0:00
Originally posted by [b]Euphy[/b]
Fixed in [rev=16538]. Turns out all of the quests were broken, so you get bonus points~ :3
Fixed in [rev=16538]. Turns out all of the quests were broken, so you get bonus points~ :3
Hercules Elf Bot - Jul 31, 2012 9:20
Originally posted by [b]Vali[/b]
I thing there is a little mistake:
[CODE]
else if (JobLevel >= 30 || (BaseJob == Job_Hunter || BaseJob == Job_Bard || BaseJob == Job_Dancer)) {
[/CODE]
Should be
[CODE]
else if (( JobLevel >= 30 || (BaseJob == Job_Hunter || BaseJob == Job_Bard || BaseJob == Job_Dancer)) && BaseClass == Job_Archer) {
[/CODE]
If not, a super novice or any other class with job level 30 will be able to get the skill. Same with other class skills.
Vali~
I thing there is a little mistake:
[CODE]
else if (JobLevel >= 30 || (BaseJob == Job_Hunter || BaseJob == Job_Bard || BaseJob == Job_Dancer)) {
[/CODE]
Should be
[CODE]
else if (( JobLevel >= 30 || (BaseJob == Job_Hunter || BaseJob == Job_Bard || BaseJob == Job_Dancer)) && BaseClass == Job_Archer) {
[/CODE]
If not, a super novice or any other class with job level 30 will be able to get the skill. Same with other class skills.
Vali~
This post has been edited by Vali on Jul 31, 2012 9:23
Hercules Elf Bot - Jul 31, 2012 16:07
Originally posted by [b]JoWei[/b]
In fact, it could be something like this since it has to be specified classes + being job level 30 or up:
[CODE]else if ( JobLevel >= 30 && (BaseJob == Job_Hunter || BaseJob == Job_Bard || BaseJob == Job_Dancer) ) {[/CODE]
Edit: typos
In fact, it could be something like this since it has to be specified classes + being job level 30 or up:
[CODE]else if ( JobLevel >= 30 && (BaseJob == Job_Hunter || BaseJob == Job_Bard || BaseJob == Job_Dancer) ) {[/CODE]
Edit: typos
This post has been edited by JoWei on Jul 31, 2012 16:08
Hercules Elf Bot - Jul 31, 2012 16:15
Originally posted by [b]Euphy[/b]
@Vali: No, that's all under this "if" bracket, so it'd be redundant:
[CODE]if (BaseClass == Job_Archer) {[/CODE]
@JoWei: The 1-1 class can also get the skill.
@Vali: No, that's all under this "if" bracket, so it'd be redundant:
[CODE]if (BaseClass == Job_Archer) {[/CODE]
@JoWei: The 1-1 class can also get the skill.
Hercules Elf Bot - Jul 31, 2012 16:45
Originally posted by [b]JoWei[/b]
Oh right O_o
Forgotten about them...
Oh right O_o
Forgotten about them...
Hercules Elf Bot - Jul 31, 2012 17:14
Originally posted by [b]Vali[/b]
[quote name='Euphy' timestamp='1343751300' post='12772']
@Vali: No, that's all under this "if" bracket, so it'd be redundant:[CODE]if (BaseClass == Job_Archer) {[/CODE]@JoWei: The 1-1 class can also get the skill.
[/quote]
Ops, sorry, I only saw the diff file >_< my mistake.
Vali~
[quote name='Euphy' timestamp='1343751300' post='12772']
@Vali: No, that's all under this "if" bracket, so it'd be redundant:[CODE]if (BaseClass == Job_Archer) {[/CODE]@JoWei: The 1-1 class can also get the skill.
[/quote]
Ops, sorry, I only saw the diff file >_< my mistake.
Vali~
Hercules Elf Bot - Aug 1, 2012 21:08
Originally posted by [b]Vali[/b]
Found another error with the archer skill quest
[CODE]
if ((countitem(907) > 19) && (countitem(921) > 6) && (countitem(906) > 40) && (countitem(1019) > 12) && (countitem(501) > 0) && (BaseClass == Job_Archer) && (JobLevel >= 30)) {
[/CODE]
should be
[CODE]
if ((countitem(907) > 19) && (countitem(921) > 6) && (countitem(906) > 40) && (countitem(1019) > 12) && (countitem(501) > 0) ) {
[/CODE]
The class and job requirements were done before. If it's not changed the player that is not an archer with level 30 on job or greater will stuck anyways.
Vali~
Found another error with the archer skill quest
[CODE]
if ((countitem(907) > 19) && (countitem(921) > 6) && (countitem(906) > 40) && (countitem(1019) > 12) && (countitem(501) > 0) && (BaseClass == Job_Archer) && (JobLevel >= 30)) {
[/CODE]
should be
[CODE]
if ((countitem(907) > 19) && (countitem(921) > 6) && (countitem(906) > 40) && (countitem(1019) > 12) && (countitem(501) > 0) ) {
[/CODE]
The class and job requirements were done before. If it's not changed the player that is not an archer with level 30 on job or greater will stuck anyways.
Vali~
Hercules Elf Bot - Aug 1, 2012 21:16
Originally posted by [b]Euphy[/b]
Oh, sorry. x.x I'll get that in my next commit, thanks!
Oh, sorry. x.x I'll get that in my next commit, thanks!
Hercules Elf Bot - Aug 1, 2012 21:48
Originally posted by [b]Vali[/b]
It's fine, you are doing a great job
It's fine, you are doing a great job
Hercules Elf Bot - Aug 1, 2012 23:44
Originally posted by [b]Euphy[/b]
Done in [rev=16553].
Done in [rev=16553].