Issue information

Issue ID
#6396
Status
Confirmed
Severity
None
Started
Hercules Elf Bot
Aug 2, 2012 6:09
Last Post
Kenpachi
May 1, 2013 0:27
Confirmation
Yes (2)
No (0)

Hercules Elf Bot - Aug 2, 2012 6:09

Originally posted by [b]kyeme[/b]
[b]#1 On Official Server:[/b] ITEM CP_Helm_Scroll and other chemical protection scroll are ITEM TYPE 11. And "skill has failed" if the users dont have Coating Bottle and NO EQUIPMENT.

[b]#2 On Official Server:[/b] SKILL Chemical Protection of alchemist class "skill has failed" if the targetNO EQUIPMENT.

@edit #2 already fixed.

This post has been edited by kyeme on Dec 18, 2015 8:04

Hercules Elf Bot - Aug 2, 2012 14:31

Originally posted by [b]malufett[/b]
[quote][b]On Official Server:[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] SKILL Chemical Protection of alchemist class "skill has failed" if the target is NO EQUIPMENT.[/size][/font][/color][/quote]
Fixed @ [rev='16560']

[quote][b]On Official Server:[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] ITEM CP_Helm_Scroll and other chemical protection scroll are ITEM TYPE 11. And "skill has failed" if the users dont have Coating Bottle and NO EQUIPMENT.[/size][/font][/color][/quote]
I'll left this work to the db/script dev... /no1

This post has been edited by malufett on Aug 2, 2012 14:33

Hercules Elf Bot - Aug 2, 2012 14:57

Originally posted by [b]kyeme[/b]
Thank you sir.

Hercules Elf Bot - Aug 2, 2012 15:44

Originally posted by [b]kyeme[/b]
I used the latest SVN, the only fixed AM_CP_WEAPON, AM_CP_SHIELD, AM_CP_ARMOR, and AM_CP_HELM but CR_FULLPROTECTION is still used in areas without equipment.. Thank you again sir.

Hercules Elf Bot - Aug 2, 2012 16:01

Originally posted by [b]malufett[/b]
ooops..sorry forgot..:)

Hercules Elf Bot - Aug 2, 2012 16:11

Originally posted by [b]kyeme[/b]
Its ok, thanks again. Hahaha hirap na ako mag ingles nyahaha.

This post has been edited by kyeme on Nov 26, 2012 19:04

Hercules Elf Bot - Aug 2, 2012 16:16

Originally posted by [b]malufett[/b]
lols...I think you really need to listen to your English teacher better..
anyway I'll commit the follow up fixes tomorrow really need to get sleep now..:)

Hercules Elf Bot - Aug 3, 2012 14:19

Originally posted by [b]malufett[/b]
[quote]I used the latest SVN, the only fixed AM_CP_WEAPON, AM_CP_SHIELD, AM_CP_ARMOR, and AM_CP_HELM but CR_FULLPROTECTION is still used in areas without equipment.. Thank you again sir.[/quote]
ok done in [rev='16567'] /no1

Hercules Elf Bot - Aug 3, 2012 14:46

Originally posted by [b]kyeme[/b]
Thank you very much! 143 /kis

Hercules Elf Bot - Aug 3, 2012 15:38

Originally posted by [b]malufett[/b]
Euphy its not yet fixed...

[quote][b]On Official Server:[/b][color=#282828][font=helvetica, arial, sans-serif][size=3] ITEM CP_Helm_Scroll and other chemical protection scroll are ITEM TYPE 11. And "skill has failed" if the users dont have Coating Bottle and NO EQUIPMENT.[/size][/font][/color][/quote]

must change the SC change script of the item...

Hercules Elf Bot - Aug 22, 2012 10:45

Originally posted by [b]Kenpachi[/b]
So the only thing left is to change the item type to 11?
If that's all I'd like to wait for the outcome of [url="http://rathena.org/board/tracker/issue-5966-item-usable-with-delayed-consumption-item-scroll/"]this report[/url] since it implies that item type 11 is kind of unneeded.

Kenpachi - Apr 29, 2013 21:08

Fixed in [url="https://github.com/HerculesWS/Hercules/commit/7a625b95742b780622482dc5d4de2c6622aac9ae"]https://github.com/HerculesWS/Hercules/commit/7a625b95742b780622482dc5d4de2c6622aac9ae[/url]

kyeme - Apr 30, 2013 5:13

Still bug, the scroll is self skill. In official this scroll is item type 11 (target skills)

Kenpachi - Apr 30, 2013 6:23

Hmm, I see. Let me see what can be done...

Kenpachi - May 1, 2013 0:27

Okay, I did some investigation and the only way to make this useable like the original skill (you can choose the target) is to use the [i]itemskill[/i] command. Unfortunately this command does not check for required items (catalysts) so I had to create a new [url="http://herc.ws/board/index.php?app=tracker&showissue=7210"]bug report[/url]. I'll update the item scripts when this is done...

This post has been edited by Kenpachi on May 1, 2013 0:27